Message uses the display_name sometimes and nick sometimes

[rbignon]

I join a channel:

16:58:40 . romain (romain@127.0.0.1) has joined #guild.something
16:58:40 |(Users #guild.something)
16:58:40  romain  Someone 
16:58:40 . Irssi: #guild.something: Total of 2 nicks (0 ops, 0 halfops, 0 voices, 2 normal)
16:58:40 . ServerMode/#guild.something (+v romain) by symlink.me
17:05:46  Someone> Dino s'y met aussi xD

Then I use /topic log:

17:36:48 !core --- Replaying new messages since 2025-02-28T15:38:57000Z
17:36:49 . Irssi: (default) critical nicklist_set_host: assertion 'host != NULL' failed
17:36:49 . Irssi: (default) critical nicklist_set_host: assertion 'host != NULL' failed
17:36:49 . Irssi: (default) critical nicklist_set_host: assertion 'host != NULL' failed
17:36:49 . Irssi: (default) critical nicklist_set_host: assertion 'host != NULL' failed
17:36:49 . Irssi: (default) critical nicklist_set_host: assertion 'host != NULL' failed
17:36:49 . Irssi: (default) critical nicklist_set_host: assertion 'host != NULL' failed
17:36:49 . A·Long·Nickname () has joined #guild.something
17:36:49  A·Long·Nickname> [2025-02-28 17:05:46] Dino s'y met aussi xD

When I try to use /topic info on both users, I get:

17:38:54 !core --- List of user(s) matching: 'A·Long·Nickname' in [ XXX ]
17:38:55 !core [ { 'avatar': None,
17:38:55 !core     'banner': None,
17:38:55 !core     'communication_disabled_until': None,
17:38:55 !core     'deaf': False,
17:38:55 !core     'discord': [{'id': 'XXXXX', 'name': XXXXX'}],
17:38:55 !core     'flags': 0,
17:38:55 !core     'mute': False,
17:38:55 !core     'nick': 'Someone',
17:38:55 !core     'pending': False,
17:38:55 !core     'premium_since': None,
17:38:55 !core     'rdircd_names': {'discord': 'Someone', 'irc': 'Someone'},
17:38:55 !core     'roles': [ 'XXXXX'],
17:38:55 !core     'user': { 'avatar': 'XXXXX',
17:38:55 !core               'avatar_decoration_data': None,
17:38:55 !core               'bot': False,
17:38:55 !core               'clan': None,
17:38:55 !core               'discriminator': '0',
17:38:55 !core               'display_name': 'A Long Nickname',
17:38:55 !core               'global_name': 'A Long Nickname',
17:38:55 !core               'id': '12345',
17:38:55 !core               'primary_guild': None,
17:38:55 !core               'public_flags': 0,
17:38:55 !core               'username': 'alongnickname'}}]
17:38:55 !core --- end of list

I guess sometimes it takes the display_name as source, but it is not obvious for me in the source code.

[mk-fg]

Yeah, intended behavior with default name preference order option is that it should use "Someone" from that info.

Given that in your example it seem to be different incoming channel messages, doubt there should be incosistency between which data those have, so likely a parser bug in that complicated Discord.user_name() thing.
I don't use that default preference order myself (just use "login" from there), so should probably be somewhat easy to reproduce by feeding that parser couple msgs in sequence like in your example above.

[rbignon]

Oh I haven't seen this option, I'll set it to login too, it will be more readable, thank you.

However I think it would be necessary to display received payloads to see if the nickname is missing in the logs messages from discord or something like that.

[mk-fg]

However I think it would be necessary to display received payloads to see if the nickname is missing in the logs messages from discord or something like that.

Yeah, there's protocol log for that, which should be easy to enable in config or anytime at runtime too:
https://github.com/mk-fg/reliable-discord-client-irc-daemon#debug-protocol-log

And --test=msg-parse option to run message parser on JSON from those to test changes for that code, but don't think it currently supports multiple messages in sequence, should probably add that and test sometime.