fix bug with empty filename on editing filename

Author: Alex Mitrakhovich

app/Http/Controllers/FileController.php

@@ -106,7 +106,7 @@ public function edit($id, Request $request)
         }
 
         $this->validate($request, [
-            'name' => 'unique:files'
+            'name' => 'required|unique:files'
         ]);
 
         $old_filename = '/public/' . $this->getUserDir() . '/' . $file->type . '/' . $file->name . '.' . $file->extension;

resources/assets/js/app.js

@@ -149,31 +149,26 @@ const app = new Vue({
         endEditing(file) {
             this.editingFile = {};
 
-            if (file.name.trim() === '') {
-                alert('Filename cannot be empty!');
-                this.fetchFile(this.activeTab);
-            } else {
-                let formData = new FormData();
-                formData.append('name', file.name);
-                formData.append('type', file.type);
-                formData.append('extension', file.extension);
-
-                axios.post('files/edit/' + file.id, formData)
-                    .then(response => {
-                        if (response.data === true) {
-                            this.showNotification('Filename successfully changed!', true);
-
-                            var src = document.querySelector('[alt="' + file.name +'"]').getAttribute("src");
-                            document.querySelector('[alt="' + file.name +'"]').setAttribute('src', src);
-                        }
-                    })
-                    .catch(error => {
-                        this.errors = error.response.data.errors;
-                        this.showNotification(error.response.data.message, false);
-                    });
-
-                this.fetchFile(this.activeTab, this.pagination.current_page);
-            }
+            let formData = new FormData();
+            formData.append('name', file.name);
+            formData.append('type', file.type);
+            formData.append('extension', file.extension);
+
+            axios.post('files/edit/' + file.id, formData)
+                .then(response => {
+                    if (response.data === true) {
+                        this.showNotification('Filename successfully changed!', true);
+
+                        var src = document.querySelector('[alt="' + file.name +'"]').getAttribute("src");
+                        document.querySelector('[alt="' + file.name +'"]').setAttribute('src', src);
+                    }
+                })
+                .catch(error => {
+                    this.errors = error.response.data.errors;
+                    this.showNotification(error.response.data.message, false);
+                });
+
+            this.fetchFile(this.activeTab, this.pagination.current_page);
         },
 
         showNotification(text, success) {

resources/views/layouts/confirm.blade.php

@@ -18,4 +18,4 @@
             </div>
         </div>
     </div>
-  </transition>
+</transition>

resources/views/main.blade.php

@@ -84,8 +84,8 @@
                                      Download
                                 </a>
                             </div>
-                      </div>
-                      <div class="card-content">
+                        </div>
+                        <div class="card-content">
                             <div class="content">
                                 <p v-if="file !== editingFile" @dblclick="editFile(file)" :title="'Double click for editing filename'">
                                     @{{ file.name + '.' + file.extension}}