Skip to content

Commit fa23579

Browse files
authored
Feature/improve api logging (#284)
* Disable fetchData rpc logging * Catch substituteParams errors
1 parent 4535825 commit fa23579

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

apps/src/metabase/helpers/dashboard/appState.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,10 @@ async function getDashcardInfoWithSQLAndOutputTableMd(
141141
return null;
142142

143143
// replace parameters
144-
sql = await substituteParameters(sql, dashcard, dashboardMetabaseState['dashboards'][dashboardId]?.param_fields, dashboardMetabaseState.parameterValues)
144+
try {
145+
sql = await substituteParameters(sql, dashcard, dashboardMetabaseState['dashboards'][dashboardId]?.param_fields, dashboardMetabaseState.parameterValues)
146+
} catch (e) {
147+
}
145148
const obj = {
146149
id,
147150
name,

web/src/app/rpc.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ export const fetchData = (
103103
csrfInfo?: { cookieKey: string; headerKey: string }
104104
) =>
105105
sendMessage('fetchData', [url, method, body, headers || {}, csrfInfo], {
106-
log_rpc: true,
106+
log_rpc: false,
107107
})
108108
export const queryURL = () => sendMessage('queryURL', [])
109109
export const getMXToken = () => sendMessage('getMXToken', [])

0 commit comments

Comments
 (0)