Skip to content

Different env var names for test server host #92

@uuf6429

Description

@uuf6429

Shouldn't these two points use the same environment variable (at least for the port)?

if (!isset($_SERVER['WEB_FIXTURES_HOST'])) {
and
host=${MINK_HOST-localhost:8002}

In minkphp/webdriver-classic-driver#23, I was considering to use the mink-test-server script instead of calling PHP directly in the bootstrap.php file, but from what I understand it wouldn't work, unless I force MINK_HOST with:

$parsedUrl = parse_url(WebdriverClassicConfig::getInstance()->getWebFixturesUrl());
$process = new Process(..., ['MINK_HOST' => $parsedUrl['host'] . ':' . $parsedUrl['port']])`

@aik099 that's another reason I wasn't relying on the old/current (broken) approach.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions