Skip to content

Commit c803451

Browse files
authored
Separate out dependency vulnerability checks in CI (#2480)
1 parent 95bdc70 commit c803451

File tree

1 file changed

+53
-32
lines changed

1 file changed

+53
-32
lines changed

.github/workflows/jobs.yaml

Lines changed: 53 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ jobs:
2323
- lint-job
2424
- no-warnings-and-make-assets
2525
- reuse-golang-dependencies
26-
- vulnerable-dependencies-checks
2726
- semgrep-static-code-analysis
2827
runs-on: [ ubuntu-latest ]
2928

@@ -91,7 +90,6 @@ jobs:
9190
- lint-job
9291
- no-warnings-and-make-assets
9392
- reuse-golang-dependencies
94-
- vulnerable-dependencies-checks
9593
- semgrep-static-code-analysis
9694
runs-on: ubuntu-latest
9795

@@ -165,7 +163,6 @@ jobs:
165163
- lint-job
166164
- no-warnings-and-make-assets
167165
- reuse-golang-dependencies
168-
- vulnerable-dependencies-checks
169166
- semgrep-static-code-analysis
170167
runs-on: ubuntu-latest
171168

@@ -283,8 +280,8 @@ jobs:
283280
pip3 install semgrep
284281
semgrep --config semgrep.yaml $(pwd)/portal-ui --error
285282
286-
no-warnings-and-make-assets:
287-
name: "React Code Has No Vulnerabilities, Warnings & is Prettified, then Make Assets"
283+
react-code-known-vulnerabilities:
284+
name: "React Code Has No Known Vulnerable Deps"
288285
runs-on: ubuntu-latest
289286
strategy:
290287
matrix:
@@ -338,6 +335,57 @@ jobs:
338335
continue-on-error: false
339336
run: |
340337
yarn audit
338+
339+
no-warnings-and-make-assets:
340+
name: "React Code Has No Warnings & is Prettified, then Make Assets"
341+
runs-on: ubuntu-latest
342+
strategy:
343+
matrix:
344+
go-version: [ 1.18.x ]
345+
os: [ ubuntu-latest ]
346+
steps:
347+
- name: Set up Go ${{ matrix.go-version }} on ${{ matrix.os }}
348+
uses: actions/setup-go@v2
349+
with:
350+
go-version: ${{ matrix.go-version }}
351+
id: go
352+
353+
- name: Check out code into the Go module directory
354+
uses: actions/checkout@v2
355+
356+
- name: Read .nvmrc
357+
id: node_version
358+
run: echo ::set-output name=NVMRC::$(cat .nvmrc)
359+
360+
- uses: actions/setup-node@v2
361+
with:
362+
node-version: ${{ env.NVMRC }}
363+
364+
- name: Get yarn cache directory path
365+
id: yarn-cache-dir-path
366+
run: echo "::set-output name=dir::$(yarn cache dir)"
367+
368+
- uses: actions/cache@v3
369+
id: yarn-cache
370+
name: Yarn Cache
371+
with:
372+
path: |
373+
${{ steps.yarn-cache-dir-path.outputs.dir }}
374+
./portal-ui/node_modules/
375+
key: ${{ runner.os }}-yarn-${{ hashFiles('./portal-ui/yarn.lock') }}
376+
restore-keys: |
377+
${{ runner.os }}-yarn-
378+
379+
- uses: actions/cache@v3
380+
id: assets-cache
381+
name: Assets Cache
382+
with:
383+
path: |
384+
./portal-ui/build/
385+
key: ${{ runner.os }}-assets-${{ github.run_id }}
386+
restore-keys: |
387+
${{ runner.os }}-assets-
388+
341389
- name: Install Dependencies
342390
working-directory: ./portal-ui
343391
continue-on-error: false
@@ -392,7 +440,6 @@ jobs:
392440
- lint-job
393441
- no-warnings-and-make-assets
394442
- reuse-golang-dependencies
395-
- vulnerable-dependencies-checks
396443
- semgrep-static-code-analysis
397444
runs-on: [ ubuntu-latest ]
398445
timeout-minutes: 10
@@ -496,7 +543,6 @@ jobs:
496543
- lint-job
497544
- no-warnings-and-make-assets
498545
- reuse-golang-dependencies
499-
- vulnerable-dependencies-checks
500546
- semgrep-static-code-analysis
501547
runs-on: [ ubuntu-latest ]
502548
timeout-minutes: 10
@@ -593,7 +639,6 @@ jobs:
593639
- lint-job
594640
- no-warnings-and-make-assets
595641
- reuse-golang-dependencies
596-
- vulnerable-dependencies-checks
597642
- semgrep-static-code-analysis
598643
runs-on: [ ubuntu-latest ]
599644
timeout-minutes: 10
@@ -691,7 +736,6 @@ jobs:
691736
- lint-job
692737
- no-warnings-and-make-assets
693738
- reuse-golang-dependencies
694-
- vulnerable-dependencies-checks
695739
- semgrep-static-code-analysis
696740
runs-on: [ ubuntu-latest ]
697741
timeout-minutes: 15
@@ -778,7 +822,6 @@ jobs:
778822
- lint-job
779823
- no-warnings-and-make-assets
780824
- reuse-golang-dependencies
781-
- vulnerable-dependencies-checks
782825
- semgrep-static-code-analysis
783826
runs-on: [ ubuntu-latest ]
784827
strategy:
@@ -864,7 +907,6 @@ jobs:
864907
- lint-job
865908
- no-warnings-and-make-assets
866909
- reuse-golang-dependencies
867-
- vulnerable-dependencies-checks
868910
- semgrep-static-code-analysis
869911
runs-on: [ ubuntu-latest ]
870912
strategy:
@@ -950,7 +992,6 @@ jobs:
950992
- lint-job
951993
- no-warnings-and-make-assets
952994
- reuse-golang-dependencies
953-
- vulnerable-dependencies-checks
954995
- semgrep-static-code-analysis
955996
runs-on: [ ubuntu-latest ]
956997
strategy:
@@ -1036,7 +1077,6 @@ jobs:
10361077
- lint-job
10371078
- no-warnings-and-make-assets
10381079
- reuse-golang-dependencies
1039-
- vulnerable-dependencies-checks
10401080
- semgrep-static-code-analysis
10411081
runs-on: [ ubuntu-latest ]
10421082
strategy:
@@ -1122,7 +1162,6 @@ jobs:
11221162
- lint-job
11231163
- no-warnings-and-make-assets
11241164
- reuse-golang-dependencies
1125-
- vulnerable-dependencies-checks
11261165
- semgrep-static-code-analysis
11271166
runs-on: [ ubuntu-latest ]
11281167
strategy:
@@ -1218,7 +1257,6 @@ jobs:
12181257
- lint-job
12191258
- no-warnings-and-make-assets
12201259
- reuse-golang-dependencies
1221-
- vulnerable-dependencies-checks
12221260
- semgrep-static-code-analysis
12231261
runs-on: [ ubuntu-latest ]
12241262
strategy:
@@ -1321,7 +1359,6 @@ jobs:
13211359
- lint-job
13221360
- no-warnings-and-make-assets
13231361
- reuse-golang-dependencies
1324-
- vulnerable-dependencies-checks
13251362
- semgrep-static-code-analysis
13261363
runs-on: [ ubuntu-latest ]
13271364
strategy:
@@ -1424,7 +1461,6 @@ jobs:
14241461
- lint-job
14251462
- no-warnings-and-make-assets
14261463
- reuse-golang-dependencies
1427-
- vulnerable-dependencies-checks
14281464
- semgrep-static-code-analysis
14291465
runs-on: ${{ matrix.os }}
14301466
strategy:
@@ -1518,7 +1554,6 @@ jobs:
15181554
- lint-job
15191555
- no-warnings-and-make-assets
15201556
- reuse-golang-dependencies
1521-
- vulnerable-dependencies-checks
15221557
- semgrep-static-code-analysis
15231558
runs-on: ${{ matrix.os }}
15241559
strategy:
@@ -1612,7 +1647,6 @@ jobs:
16121647
- lint-job
16131648
- no-warnings-and-make-assets
16141649
- reuse-golang-dependencies
1615-
- vulnerable-dependencies-checks
16161650
- semgrep-static-code-analysis
16171651
runs-on: ${{ matrix.os }}
16181652
strategy:
@@ -1706,7 +1740,6 @@ jobs:
17061740
# - lint-job
17071741
# - no-warnings-and-make-assets
17081742
# - reuse-golang-dependencies
1709-
# - vulnerable-dependencies-checks
17101743
# - semgrep-static-code-analysis
17111744
# runs-on: ${{ matrix.os }}
17121745
# strategy:
@@ -1800,7 +1833,6 @@ jobs:
18001833
# - lint-job
18011834
# - no-warnings-and-make-assets
18021835
# - reuse-golang-dependencies
1803-
# - vulnerable-dependencies-checks
18041836
# - semgrep-static-code-analysis
18051837
# runs-on: ${{ matrix.os }}
18061838
# strategy:
@@ -1894,7 +1926,6 @@ jobs:
18941926
- lint-job
18951927
- no-warnings-and-make-assets
18961928
- reuse-golang-dependencies
1897-
- vulnerable-dependencies-checks
18981929
- semgrep-static-code-analysis
18991930
runs-on: ${{ matrix.os }}
19001931
strategy:
@@ -1932,7 +1963,6 @@ jobs:
19321963
- lint-job
19331964
- no-warnings-and-make-assets
19341965
- reuse-golang-dependencies
1935-
- vulnerable-dependencies-checks
19361966
- semgrep-static-code-analysis
19371967
runs-on: ${{ matrix.os }}
19381968
strategy:
@@ -1970,7 +2000,6 @@ jobs:
19702000
- lint-job
19712001
- no-warnings-and-make-assets
19722002
- reuse-golang-dependencies
1973-
- vulnerable-dependencies-checks
19742003
- semgrep-static-code-analysis
19752004
runs-on: ${{ matrix.os }}
19762005
strategy:
@@ -2008,7 +2037,6 @@ jobs:
20082037
- lint-job
20092038
- no-warnings-and-make-assets
20102039
- reuse-golang-dependencies
2011-
- vulnerable-dependencies-checks
20122040
- semgrep-static-code-analysis
20132041
runs-on: ${{ matrix.os }}
20142042
strategy:
@@ -2046,7 +2074,6 @@ jobs:
20462074
- lint-job
20472075
- no-warnings-and-make-assets
20482076
- reuse-golang-dependencies
2049-
- vulnerable-dependencies-checks
20502077
- semgrep-static-code-analysis
20512078
runs-on: ${{ matrix.os }}
20522079
strategy:
@@ -2084,7 +2111,6 @@ jobs:
20842111
- lint-job
20852112
- no-warnings-and-make-assets
20862113
- reuse-golang-dependencies
2087-
- vulnerable-dependencies-checks
20882114
- semgrep-static-code-analysis
20892115
runs-on: ${{ matrix.os }}
20902116
strategy:
@@ -2122,7 +2148,6 @@ jobs:
21222148
- lint-job
21232149
- no-warnings-and-make-assets
21242150
- reuse-golang-dependencies
2125-
- vulnerable-dependencies-checks
21262151
- semgrep-static-code-analysis
21272152
runs-on: ${{ matrix.os }}
21282153
strategy:
@@ -2160,7 +2185,6 @@ jobs:
21602185
- lint-job
21612186
- no-warnings-and-make-assets
21622187
- reuse-golang-dependencies
2163-
- vulnerable-dependencies-checks
21642188
- semgrep-static-code-analysis
21652189
runs-on: ${{ matrix.os }}
21662190
strategy:
@@ -2206,7 +2230,6 @@ jobs:
22062230
- lint-job
22072231
- no-warnings-and-make-assets
22082232
- reuse-golang-dependencies
2209-
- vulnerable-dependencies-checks
22102233
- semgrep-static-code-analysis
22112234
runs-on: ${{ matrix.os }}
22122235
strategy:
@@ -2252,7 +2275,6 @@ jobs:
22522275
- lint-job
22532276
- no-warnings-and-make-assets
22542277
- reuse-golang-dependencies
2255-
- vulnerable-dependencies-checks
22562278
- semgrep-static-code-analysis
22572279
runs-on: ubuntu-latest
22582280

@@ -2345,7 +2367,6 @@ jobs:
23452367
- lint-job
23462368
- no-warnings-and-make-assets
23472369
- reuse-golang-dependencies
2348-
- vulnerable-dependencies-checks
23492370
- semgrep-static-code-analysis
23502371
runs-on: ubuntu-latest
23512372
steps:

0 commit comments

Comments
 (0)