Skip to content

Commit a778a1e

Browse files
authored
Fix failing tests and remove sleep statement for GitHub Actions (#1432)
1 parent 5f28151 commit a778a1e

File tree

2 files changed

+14
-16
lines changed

2 files changed

+14
-16
lines changed

.github/workflows/permissions.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ jobs:
5858
5959
- name: Start Console, front-end app and initialize users/policies
6060
run: |
61-
(./console server && sleep 180) & (make initialize-permissions && sleep 180)
61+
(./console server) & (make initialize-permissions)
6262
6363
- name: Run TestCafe Tests
6464
uses: DevExpress/testcafe-action@latest

portal-ui/tests/permissions/diagnostics.ts

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -60,22 +60,20 @@ test("Start Diagnostic button can be clicked", async (t) => {
6060
.click(elements.startDiagnosticButton);
6161
});
6262

63-
// TODO: Fix test failing sporadically on GitHub Actions
64-
65-
// test("Download button exists after Diagnostic is completed", async (t) => {
66-
// const downloadExists = elements.downloadButton.exists;
67-
// await t
68-
// .navigateTo("http://localhost:9090/support/diagnostics")
69-
// .click(elements.startDiagnosticButton)
70-
// .expect(downloadExists).ok();
71-
// });
63+
test("Download button exists after Diagnostic is completed", async (t) => {
64+
const downloadExists = elements.downloadButton.exists;
65+
await t
66+
.navigateTo("http://localhost:9090/support/diagnostics")
67+
.click(elements.startDiagnosticButton)
68+
.expect(downloadExists).ok();
69+
});
7270

73-
// test("Download button is clickable after Diagnostic is completed", async (t) => {
74-
// await t
75-
// .navigateTo("http://localhost:9090/support/diagnostics")
76-
// .click(elements.startDiagnosticButton)
77-
// .click(elements.downloadButton);
78-
// });
71+
test("Download button is clickable after Diagnostic is completed", async (t) => {
72+
await t
73+
.navigateTo("http://localhost:9090/support/diagnostics")
74+
.click(elements.startDiagnosticButton)
75+
.click(elements.downloadButton);
76+
});
7977

8078
test("Start New Diagnostic button exists after Diagnostic is completed", async (t) => {
8179
const startNewDiagnosticButtonExists =

0 commit comments

Comments
 (0)