Skip to content

Commit 7b83f4b

Browse files
authored
Restored ENV var display support in Console Configuration pages. (#3112)
Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
1 parent 7d9910d commit 7b83f4b

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed

portal-ui/src/screens/Console/Configurations/types.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
// along with this program. If not, see <http://www.gnu.org/licenses/>.
1616

1717
import { SelectorTypes } from "../../../common/types";
18+
import { EnvOverride } from "../../../api/consoleApi";
1819

1920
export type KVFieldType =
2021
| "string"
@@ -51,15 +52,10 @@ export interface IConfigurationElement {
5152
url?: string;
5253
}
5354

54-
export interface IEnvOverride {
55-
name: string;
56-
value: string;
57-
}
58-
5955
export interface IElementValue {
6056
key: string;
6157
value: string;
62-
env_override?: IEnvOverride;
58+
env_override?: EnvOverride;
6359
}
6460

6561
export interface IConfigurationSys {

portal-ui/src/screens/Console/Configurations/utils.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -429,8 +429,8 @@ export const overrideFields = (formFields: IElementValue[]): IOverrideEnv => {
429429
// it has override values, we construct the value
430430
if (envItem.env_override) {
431431
const value: OverrideValue = {
432-
value: envItem.env_override.value,
433-
overrideEnv: envItem.env_override.name,
432+
value: envItem.env_override.value || "",
433+
overrideEnv: envItem.env_override.name || "",
434434
};
435435

436436
overrideReturn = { ...overrideReturn, [envItem.key]: value };

portal-ui/src/screens/Console/EventDestinations/CustomForms/EditConfiguration.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ const EditConfiguration = ({
9191

9292
const fieldsConfig: KVField[] = fieldsConfigurations[configId];
9393

94-
const keyVals = fieldsConfig.map((field) => {
94+
const keyVals: IElementValue[] = fieldsConfig.map((field) => {
9595
const includedValue = values.find(
9696
(element: ConfigurationKV) => element.key === field.name,
9797
);
@@ -102,6 +102,7 @@ const EditConfiguration = ({
102102
value: field.customValueProcess
103103
? field.customValueProcess(customValue)
104104
: customValue,
105+
env_override: includedValue?.env_override,
105106
};
106107
});
107108

0 commit comments

Comments
 (0)