Skip to content

Commit 71ac8d7

Browse files
authored
Replaced top breadcrumbs & redesign of bucket breadcrumbs (#1498)
1 parent 5258ac3 commit 71ac8d7

File tree

6 files changed

+107
-34
lines changed

6 files changed

+107
-34
lines changed

portal-ui/src/common/BackLink.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,9 @@ const styles = (theme: Theme) =>
4040
display: "flex",
4141
alignItems: "center",
4242
justifyContent: "center",
43+
"& svg.min-icon": {
44+
width: 12,
45+
},
4346
},
4447
});
4548

portal-ui/src/screens/Console/Buckets/BucketDetails/BrowserHandler.tsx

Lines changed: 23 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ import {
4141
IAM_SCOPES,
4242
} from "../../../../common/SecureComponent/permissions";
4343
import SearchBox from "../../Common/SearchBox";
44+
import BackLink from "../../../../common/BackLink";
4445

4546
interface IBrowserHandlerProps {
4647
fileMode: boolean;
@@ -60,6 +61,12 @@ const styles = (theme: Theme) =>
6061
textDecoration: "none",
6162
color: "black",
6263
},
64+
backToBuckets: {
65+
color: "#000",
66+
fontSize: 14,
67+
padding: 0,
68+
marginTop: -8,
69+
},
6370
...containerForHeader(theme.spacing(4)),
6471
});
6572

@@ -88,10 +95,22 @@ const BrowserHandler = ({
8895
<PageHeader
8996
label={
9097
<Fragment>
91-
<Link to={"/buckets"} className={classes.breadcrumLink}>
92-
Buckets
93-
</Link>{" "}
94-
&gt; {bucketName}
98+
{fileMode ? (
99+
<Fragment>
100+
<Link to={"/buckets"} className={classes.breadcrumLink}>
101+
Buckets
102+
</Link>{" "}
103+
&gt; {bucketName}
104+
</Fragment>
105+
) : (
106+
<Fragment>
107+
<BackLink
108+
label={"Back to Buckets"}
109+
to={"/buckets"}
110+
className={classes.backToBuckets}
111+
/>
112+
</Fragment>
113+
)}
95114
</Fragment>
96115
}
97116
actions={

portal-ui/src/screens/Console/Buckets/ListBuckets/Objects/ListObjects/ListObjects.tsx

Lines changed: 37 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,12 @@ import SecureComponent, {
8989

9090
import withSuspense from "../../../../Common/Components/withSuspense";
9191
import { displayName } from "./utils";
92-
import { DownloadIcon, PreviewIcon, ShareIcon } from "../../../../../../icons";
92+
import {
93+
BucketsIcon,
94+
DownloadIcon,
95+
PreviewIcon,
96+
ShareIcon,
97+
} from "../../../../../../icons";
9398
import UploadFilesButton from "../../UploadFilesButton";
9499
import DetailsListPanel from "./DetailsListPanel";
95100
import ObjectDetailPanel from "./ObjectDetailPanel";
@@ -100,9 +105,6 @@ const AddFolderIcon = React.lazy(
100105
const HistoryIcon = React.lazy(
101106
() => import("../../../../../../icons/HistoryIcon")
102107
);
103-
const FolderIcon = React.lazy(
104-
() => import("../../../../../../icons/FolderIcon")
105-
);
106108
const RefreshIcon = React.lazy(
107109
() => import("../../../../../../icons/RefreshIcon")
108110
);
@@ -127,7 +129,7 @@ const PreviewFileModal = withSuspense(
127129
const styles = (theme: Theme) =>
128130
createStyles({
129131
browsePaper: {
130-
height: "calc(100vh - 280px)",
132+
height: "calc(100vh - 210px)",
131133
"&.actionsPanelOpen": {
132134
height: "100%",
133135
},
@@ -690,9 +692,9 @@ const ListObjects = ({
690692
};
691693

692694
const openPath = (idElement: string) => {
693-
if(idElement.endsWith("/")) {
695+
if (idElement.endsWith("/")) {
694696
const newPath = `/buckets/${bucketName}/browse${
695-
idElement ? `/${encodeFileName(idElement)}` : ``
697+
idElement ? `/${encodeFileName(idElement)}` : ``
696698
}`;
697699
history.push(newPath);
698700
return;
@@ -1091,6 +1093,28 @@ const ListObjects = ({
10911093
if (currentPath.length > 0) {
10921094
uploadPath = uploadPath.concat(currentPath);
10931095
}
1096+
1097+
// TODO: Add bucket information panel
1098+
/*
1099+
*
1100+
* subTitle={
1101+
<Fragment>
1102+
<Grid item xs={12} className={classes.bucketDetails}>
1103+
<span className={classes.detailsSpacer}>
1104+
Created:&nbsp;&nbsp;&nbsp;<strong></strong>
1105+
</span>
1106+
<span className={classes.detailsSpacer}>
1107+
Access:&nbsp;&nbsp;&nbsp;<strong></strong>
1108+
</span>
1109+
<span className={classes.detailsSpacer}>
1110+
SIZE / TOTAL OBJECTS
1111+
</span>
1112+
</Grid>
1113+
</Fragment>
1114+
}
1115+
*
1116+
* */
1117+
10941118
return (
10951119
<React.Fragment>
10961120
{shareFileModalOpen && selectedPreview && (
@@ -1144,19 +1168,15 @@ const ListObjects = ({
11441168
className={classes.screenTitle}
11451169
icon={
11461170
<Fragment>
1147-
<FolderIcon width={40} />
1171+
<BucketsIcon width={40} />
11481172
</Fragment>
11491173
}
11501174
title={
1151-
currentPath.length > 0 ? currentPath[currentPath.length - 1] : "/"
1152-
}
1153-
subTitle={
1154-
<Fragment>
1155-
<BrowserBreadcrumbs
1156-
bucketName={bucketName}
1157-
internalPaths={pageTitle}
1158-
/>
1159-
</Fragment>
1175+
<BrowserBreadcrumbs
1176+
bucketName={bucketName}
1177+
internalPaths={pageTitle}
1178+
fullSizeBreadcrumbs
1179+
/>
11601180
}
11611181
actions={
11621182
<Fragment>
@@ -1194,9 +1214,6 @@ const ListObjects = ({
11941214
}
11951215
/>
11961216
</Grid>
1197-
<Grid item xs={12}>
1198-
<br />
1199-
</Grid>
12001217
<div
12011218
id="object-list-wrapper"
12021219
{...getRootProps({ style: { ...dndStyles } })}

portal-ui/src/screens/Console/Common/FormComponents/common/styleLibrary.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -371,11 +371,23 @@ export const objectBrowserCommon = {
371371
textDecoration: "underline",
372372
},
373373
},
374+
"&.fullSize": {
375+
fontSize: 18,
376+
marginLeft: 10,
377+
}
374378
},
375379
smallLabel: {
376380
color: "#9C9C9C",
377381
fontSize: 15,
378382
},
383+
bucketDetails: {
384+
marginLeft: 10,
385+
fontSize:14,
386+
color: "#969FA8"
387+
},
388+
detailsSpacer: {
389+
marginRight: 18,
390+
},
379391
};
380392

381393
export const selectorsCommon = {

portal-ui/src/screens/Console/Common/PageHeader/PageHeader.tsx

Lines changed: 29 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ const styles = (theme: Theme) =>
7676
display: "flex",
7777
justifyContent: "center",
7878
alignItems: "center",
79-
}
79+
},
8080
});
8181

8282
const PageHeader = ({
@@ -87,7 +87,7 @@ const PageHeader = ({
8787
operatorMode,
8888
managerObjects,
8989
toggleList,
90-
middleComponent,
90+
middleComponent,
9191
}: IPageHeader) => {
9292
return (
9393
<Grid
@@ -96,9 +96,16 @@ const PageHeader = ({
9696
direction="row"
9797
alignItems="center"
9898
>
99-
<Grid item xs={12} sm={12} md={middleComponent? 3: 6} className={classes.label} sx={{
100-
paddingTop: ["15px", "15px", "0", "0"],
101-
}}>
99+
<Grid
100+
item
101+
xs={12}
102+
sm={12}
103+
md={middleComponent ? 3 : 6}
104+
className={classes.label}
105+
sx={{
106+
paddingTop: ["15px", "15px", "0", "0"],
107+
}}
108+
>
102109
{!sidebarOpen && (
103110
<div className={classes.logo}>
104111
{operatorMode ? <OperatorLogo /> : <ConsoleLogo />}
@@ -109,11 +116,24 @@ const PageHeader = ({
109116
</Typography>
110117
</Grid>
111118
{middleComponent && (
112-
<Grid item xs={12} sm={12} md={6} className={classes.middleComponent}>
113-
{middleComponent}
114-
</Grid>
119+
<Grid
120+
item
121+
xs={12}
122+
sm={12}
123+
md={6}
124+
className={classes.middleComponent}
125+
sx={{ marginTop: ["10px", "10px", "0", "0"] }}
126+
>
127+
{middleComponent}
128+
</Grid>
115129
)}
116-
<Grid item xs={12} sm={12} md={middleComponent? 3:6} className={classes.rightMenu}>
130+
<Grid
131+
item
132+
xs={12}
133+
sm={12}
134+
md={middleComponent ? 3 : 6}
135+
className={classes.rightMenu}
136+
>
117137
{actions && actions}
118138
{managerObjects && managerObjects.length > 0 && (
119139
<IconButton

portal-ui/src/screens/Console/ObjectBrowser/BrowserBreadcrumbs.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ interface IObjectBrowser {
3737
internalPaths: string;
3838
rewindEnabled?: boolean;
3939
rewindDate?: any;
40+
fullSizeBreadcrumbs?: boolean;
4041
}
4142

4243
const styles = (theme: Theme) =>
@@ -50,6 +51,7 @@ const BrowserBreadcrumbs = ({
5051
internalPaths,
5152
rewindEnabled,
5253
rewindDate,
54+
fullSizeBreadcrumbs,
5355
}: IObjectBrowser) => {
5456
let paths = internalPaths;
5557

@@ -92,7 +94,7 @@ const BrowserBreadcrumbs = ({
9294
</Grid>
9395
)}
9496

95-
<Grid item xs={12} className={classes.breadcrumbs}>
97+
<Grid item xs={12} className={`${classes.breadcrumbs} ${fullSizeBreadcrumbs ? "fullSize" : ""}`}>
9698
<React.Fragment>
9799
<Link to={`/buckets/${bucketName}/browse`}>{bucketName}</Link>
98100
{listBreadcrumbs.length > 0 && <span> / </span>}

0 commit comments

Comments
 (0)