Skip to content

Commit 60f5eb6

Browse files
authored
remove warning message in delete bucket replication rule (#2931)
1 parent 420ed00 commit 60f5eb6

File tree

2 files changed

+8
-11
lines changed

2 files changed

+8
-11
lines changed

portal-ui/src/screens/Console/Buckets/BucketDetails/BucketReplicationPanel.tsx

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,10 @@ const BucketReplicationPanel = ({ classes }: IBucketReplicationProps) => {
242242
ruleToDelete={selectedRRule}
243243
rulesToDelete={selectedRepRules}
244244
remainingRules={replicationRules.length}
245-
allSelected={selectedRepRules.length === replicationRules.length}
245+
allSelected={
246+
replicationRules.length > 0 &&
247+
selectedRepRules.length === replicationRules.length
248+
}
246249
deleteSelectedRules={deleteSelectedRules}
247250
/>
248251
)}
@@ -277,7 +280,10 @@ const BucketReplicationPanel = ({ classes }: IBucketReplicationProps) => {
277280
label={"Remove Selected Rules"}
278281
icon={<TrashIcon />}
279282
color={"secondary"}
280-
disabled={selectedRepRules.length === 0}
283+
disabled={
284+
selectedRepRules.length === 0 ||
285+
replicationRules.length === 0
286+
}
281287
variant={"secondary"}
282288
/>
283289
</TooltipWrapper>

portal-ui/src/screens/Console/Buckets/BucketDetails/DeleteReplicationRule.tsx

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import ConfirmDialog from "../../Common/ModalWrapper/ConfirmDialog";
2424
import { ConfirmDeleteIcon } from "mds";
2525
import Grid from "@mui/material/Grid";
2626
import InputBoxWrapper from "../../Common/FormComponents/InputBoxWrapper/InputBoxWrapper";
27-
import WarningMessage from "../../Common/WarningMessage/WarningMessage";
2827
import { setErrorSnackMessage } from "../../../../systemSlice";
2928
import { useAppDispatch } from "../../../../store";
3029

@@ -101,10 +100,6 @@ const DeleteReplicationRule = ({
101100
<DialogContentText>
102101
{deleteSelectedRules ? (
103102
<Fragment>
104-
<WarningMessage
105-
title={"Warning"}
106-
label={"The corresponding remote buckets will also be deleted."}
107-
/>
108103
Are you sure you want to remove the selected replication rules for
109104
bucket <b>{selectedBucket}</b>?<br />
110105
<br />
@@ -123,10 +118,6 @@ const DeleteReplicationRule = ({
123118
</Fragment>
124119
) : (
125120
<Fragment>
126-
<WarningMessage
127-
title={"Warning"}
128-
label={"The corresponding remote bucket will also be deleted."}
129-
/>
130121
Are you sure you want to delete replication rule{" "}
131122
<b>{ruleToDelete}</b>?
132123
</Fragment>

0 commit comments

Comments
 (0)