Skip to content

Commit 56f22a4

Browse files
authored
Fix storageClass on EditLifecycleModal (#3379)
1 parent 7b88d3a commit 56f22a4

File tree

1 file changed

+20
-11
lines changed

1 file changed

+20
-11
lines changed

web-app/src/screens/Console/Buckets/BucketDetails/EditLifecycleConfiguration.tsx

Lines changed: 20 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,9 @@ const EditLifecycleConfiguration = ({
9292

9393
return { label: value, value: value };
9494
});
95-
9695
setTiersList(objList);
9796
if (objList.length > 0) {
98-
setStorageClass(objList[0].value);
97+
setStorageClass(lifecycleRule.transition?.storage_class || "");
9998
}
10099
}
101100
setLoadingTiers(false);
@@ -104,18 +103,28 @@ const EditLifecycleConfiguration = ({
104103
setLoadingTiers(false);
105104
});
106105
}
107-
}, [loadingTiers]);
106+
}, [loadingTiers, lifecycleRule.transition?.storage_class]);
108107

109108
useEffect(() => {
110109
let valid = true;
111110

112111
if (ilmType !== "expiry") {
113-
if (storageClass === "") {
112+
if (
113+
(transitionDays !== "0" && storageClass === "") ||
114+
(NCTransitionDays !== "0" && NCTransitionSC === "")
115+
) {
114116
valid = false;
115117
}
116118
}
117119
setIsFormValid(valid);
118-
}, [ilmType, expiryDays, transitionDays, storageClass]);
120+
}, [
121+
ilmType,
122+
expiryDays,
123+
transitionDays,
124+
storageClass,
125+
NCTransitionDays,
126+
NCTransitionSC,
127+
]);
119128

120129
useEffect(() => {
121130
if (lifecycleRule.status === "Enabled") {
@@ -439,15 +448,15 @@ const EditLifecycleConfiguration = ({
439448
value={NCTransitionDays}
440449
min="0"
441450
/>
442-
<InputBox
451+
<Select
452+
label="Non-current Version Transition Storage Class"
443453
id="noncurrentversion_t_SC"
444454
name="noncurrentversion_t_SC"
445-
onChange={(e: React.ChangeEvent<HTMLInputElement>) => {
446-
setNCTransitionSC(e.target.value);
447-
}}
448-
placeholder="Set Non-current Version Transition Storage Class"
449-
label="Non-current Version Transition Storage Class"
450455
value={NCTransitionSC}
456+
onChange={(value) => {
457+
setNCTransitionSC(value);
458+
}}
459+
options={tiersList}
451460
/>
452461
</Fragment>
453462
)}

0 commit comments

Comments
 (0)