Delete secrets on tenant deletion (#253)

Author: cesnietor

k8s/operator-console/base/console-cluster-role.yaml

@@ -14,6 +14,7 @@ rules:
       - list
       - patch
       - update
+      - deletecollection
   - apiGroups:
       - ""
     resources:
@@ -22,6 +23,7 @@ rules:
       - services
       - events
       - resourcequotas
+      - nodes
     verbs:
       - get
       - watch
@@ -34,6 +36,8 @@ rules:
       - persistentvolumeclaims
     verbs:
       - deletecollection
+      - list
+      - get
   - apiGroups:
       - "storage.k8s.io"
     resources:

restapi/admin_tenants.go

@@ -189,7 +189,12 @@ func deleteTenantAction(
 		opts := metav1.ListOptions{
 			LabelSelector: fmt.Sprintf("%s=%s", operator.TenantLabel, tenantName),
 		}
-		return clientset.PersistentVolumeClaims(namespace).DeleteCollection(ctx, metav1.DeleteOptions{}, opts)
+		err = clientset.PersistentVolumeClaims(namespace).DeleteCollection(ctx, metav1.DeleteOptions{}, opts)
+		if err != nil {
+			return err
+		}
+		// delete all tenant's secrets only if deletePvcs = true
+		return clientset.Secrets(namespace).DeleteCollection(ctx, metav1.DeleteOptions{}, opts)
 	}
 	return nil
 }