Skip to content

Commit 275d87f

Browse files
config set should always use on/off not true/false (#1899)
fixes minio/minio#14516
1 parent 509f495 commit 275d87f

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

portal-ui/src/screens/Console/NotificationEndpoints/ConfTargetGeneric.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export const valueDef = (
5252
type: string,
5353
defaults: IElementValue[]
5454
) => {
55-
let defValue = type === "on|off" ? "false" : "";
55+
let defValue = type === "on|off" ? "off" : "";
5656

5757
if (defaults.length > 0) {
5858
const storedConfig = defaults.find((element) => element.key === key);
@@ -105,20 +105,20 @@ const ConfTargetGeneric = ({
105105
const fieldDefinition = (field: KVField, item: number) => {
106106
switch (field.type) {
107107
case "on|off":
108-
const value = valueHolder[item] ? valueHolder[item].value : "false";
108+
const value = valueHolder[item] ? valueHolder[item].value : "off";
109109

110110
return (
111111
<FormSwitchWrapper
112112
onChange={(e: React.ChangeEvent<HTMLInputElement>) => {
113-
const value = e.target.checked ? "true" : "false";
113+
const value = e.target.checked ? "on" : "off";
114114
setValueElement(field.name, value, item);
115115
}}
116116
id={field.name}
117117
name={field.name}
118118
label={field.label}
119119
value={"switch_on"}
120120
tooltip={field.tooltip}
121-
checked={value === "true"}
121+
checked={value === "on"}
122122
/>
123123
);
124124
case "csv":

0 commit comments

Comments
 (0)