Skip to content

Conversation

@hadipash
Copy link
Collaborator

What does this PR do?

Fixes # (issue)

Adds # (feature)

  • Update the README to reflect MS2.7 support.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes? E.g. record bug fixes or new features in What's New. Here are the
    documentation guidelines
  • Did you build and run the code without any errors?
  • Did you report the running environment (NPU type/MS version) and performance in the doc? (better record it for data loading, model inference, or training tasks)
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hadipash, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the OmniGen2 example's README.md file to reflect the newly added support for MindSpore version 2.7.0. This ensures that the documentation accurately represents the compatible software environments, providing clear guidance for users setting up and running the OmniGen2 project.

Highlights

  • MindSpore 2.7.0 Support: The README for OmniGen2 has been updated to include MindSpore version 2.7.0 and its corresponding CANN toolkit/kernel 8.2.RC1 in the compatibility table.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README.md to add support for MindSpore 2.7.0. The change is correct, but it creates an inconsistency with the installation instructions section, which has not been updated to reflect the new CANN toolkit version. I have added a comment to address this.

| MindSpore | Ascend Driver | Firmware | CANN toolkit/kernel |
|:---------:|:-------------:|:-----------:|:-------------------:|
| 2.6.0 | 24.1.rc3 | 7.7.0.1.238 | 8.1.RC1 |
| 2.7.0 | 24.1.rc3 | 7.7.0.1.238 | 8.2.RC1 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While you've correctly added support for MindSpore 2.7.0 which uses CANN toolkit 8.2.RC1, the installation instructions below (line 38) still only provide a link for CANN 8.1.RC1. To avoid confusion, please also update the installation instructions to include a link for CANN 8.2.RC1.

@vigo999 vigo999 self-requested a review October 17, 2025 10:55
@vigo999 vigo999 added this to mindone Oct 17, 2025
@vigo999 vigo999 moved this to In Progress in mindone Oct 17, 2025
@vigo999 vigo999 enabled auto-merge October 17, 2025 10:56
@vigo999 vigo999 disabled auto-merge October 18, 2025 03:10
@vigo999 vigo999 merged commit 470e7e1 into mindspore-lab:master Oct 18, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in mindone Oct 18, 2025
@hadipash hadipash deleted the omnigen2_readme branch October 31, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants