Skip to content

Conversation

@LiTingyu1997
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Adds # (feature)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes? E.g. record bug fixes or new features in What's New. Here are the
    documentation guidelines
  • Did you build and run the code without any errors?
  • Did you report the running environment (NPU type/MS version) and performance in the doc? (better record it for data loading, model inference, or training tasks)
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@xxx

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @LiTingyu1997, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the documentation for the VAR example to ensure it accurately reflects compatibility and performance with newer versions of the MindSpore framework. By adding requirements and benchmarks for MindSpore 2.6.0 and 2.7.0, the PR provides current and comprehensive information for users, enhancing the clarity and utility of the README.md file.

Highlights

  • MindSpore Version Support: The README.md has been updated to reflect support for MindSpore versions 2.6.0 and 2.7.0, including their corresponding firmware and CANN toolkit/kernel requirements.
  • Performance Benchmarks: New performance benchmarks for the VAR-d16 model have been added for MindSpore 2.6.0 and 2.7.0 in pynative mode, covering both training and inference metrics.
  • Documentation Refinement: An outdated performance entry for VAR-d16 on a single card has been removed, and the inference command example has been updated from --var_ckpt to --var_checkpoint for consistency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the README.md file to include the requirements and performance metrics for MindSpore versions 2.6.0 and 2.7.0. It also corrects a typo in the inference demo command. The review focuses on ensuring the accuracy and clarity of the added information.


Here are a inference demo.
```shell
python inference_demo.py --var_ckpt path/to/var-d16.ckpt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The argument name should be consistent with the code. It's better to use var_checkpoint instead of var_ckpt.

Suggested change
python inference_demo.py --var_ckpt path/to/var-d16.ckpt
python inference_demo.py --var_checkpoint path/to/var-d16.ckpt

@vigo999 vigo999 added this to mindone Oct 17, 2025
@vigo999 vigo999 moved this to In Progress in mindone Oct 17, 2025
@vigo999 vigo999 self-requested a review October 17, 2025 11:00
@vigo999 vigo999 added this pull request to the merge queue Oct 18, 2025
Merged via the queue into mindspore-lab:master with commit 9feb07e Oct 18, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in mindone Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants