-
Notifications
You must be signed in to change notification settings - Fork 87
[Bug Fix] Janus-Pro runnable with MS2.6/2.7 #1378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request makes the Janus examples compatible with MindSpore 2.6/2.7. The changes include updating environment and performance documentation, applying necessary compatibility fixes for graph mode in newer MindSpore versions, resolving a broadcast error during training, and cleaning up script arguments and configurations. The changes are well-justified and align with the PR's objective. I've added one comment regarding a minor naming inconsistency for future code maintainability improvement.
- Added PR links to model components where specific PRs exist (#1288, #1148) - Added PR links to examples models that have individual PRs (#1378, #1233, #1363, #1243, #687, #1362, #1227, #1346, #1200, #1369) - Noted that some components were added as part of broader pipeline implementations - Improved traceability for specific model additions
What does this PR do?
Make examples/janus to be runnable with MS2.6/2.7
Fixes # (issue)
_support_cache_class=Falseto be compatible with graph mode. We manually added this attribute ininference.pyandgeneration_inference.py.enable_compile_cache=Truesetting caused some unknown errors, so we removed it.Adds # (feature)
Before submitting
What's New. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@xxx