Skip to content

Conversation

@LiTingyu1997
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Adds # (feature)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes? E.g. record bug fixes or new features in What's New. Here are the
    documentation guidelines
  • Did you build and run the code without any errors?
  • Did you report the running environment (NPU type/MS version) and performance in the doc? (better record it for data loading, model inference, or training tasks)
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@xxx

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @LiTingyu1997, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the sparktts example's documentation to ensure users have the most current information regarding MindSpore version compatibility and associated hardware/software dependencies. Additionally, it provides valuable performance benchmarks for the model, allowing users to understand expected training efficiency on Ascend NPUs.

Highlights

  • MindSpore Version Upgrade: The sparktts example's README has been updated to reflect compatibility with MindSpore versions 2.6.0 and 2.7.0, along with their corresponding Ascend driver, firmware, and CANN toolkit/kernel versions.
  • Performance Metrics Added: A new 'Performance' section has been introduced, providing detailed training performance metrics for the sparktts model on Ascend NPUs for both MindSpore 2.6.0 and 2.7.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the SparkTTS README.md file to reflect changes in MindSpore, Ascend Driver, Firmware, and CANN Toolkit/Kernel versions. It also adds a performance section with evaluation results on Ascend NPUs for MindSpore versions 2.6.0 and 2.7.0. I have added a review comment to address a potential typo in the markdown table.

Comment on lines +212 to +214
| model name | cards | batch size | jit level | kv cache | attn type | step time | token/s |
|:----------:|:-----:|:----------:|:---------:|:--------:|:---------:|:---------:|:-------:|
| sparktts | 1 | 1 | O0 | OFF | eager | 0.198s | 5.25 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The table header |:-----------|:------|:-----------|:---------:|:--------:|:---------:|:---------:|:-------:| seems to have inconsistent spacing between the colons and hyphens. While this doesn't affect rendering, standardizing it improves readability in the source markdown. Consider adjusting the spacing to be consistent throughout the table header.

For example, use |:----------:|:------:|:----------:|:--------:|:--------:|:--------:|:--------:|:-------:| for centered alignment.

@vigo999 vigo999 added this to mindone Oct 18, 2025
@vigo999 vigo999 moved this to In Progress in mindone Oct 18, 2025
@vigo999 vigo999 self-requested a review October 18, 2025 03:14
@vigo999 vigo999 merged commit 8bb92c8 into mindspore-lab:master Oct 18, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in mindone Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants