Recentering after consult-buffer and consult-register does not work

[fredmorcos]

I think the recenter function from the consult-after-jump-hook is not called when using consult-buffer and consult-register if preview is not triggered (i.e. consult-preview-key is nil). Looking at the code, that seems to be the case. The hooks are called in the preview function consult--jump-preview, but never in the top-level functions so I think when previewing is not active, recentering and the hooks in general are not triggered.

[minad]

Yes, as intended, the consult-after-jump-hooks are only triggered by commands like consult-line, which jump to markers.

[fredmorcos]

What would be the correct way to recenter after consult-buffer and consult-register?

[hmelman]

I think it should be triggered whenever consult moves to a location (which is what the docstring suggests). So I agree that merely switching to a buffer shouldn't trigger it, but if I save a position in a register, and jump to it via consult-register, I think it should trigger it whether preview is enabled or not. FWIW, I don't have preview enabled and consult-register for a position doesn't seem to trigger it for me, though I rarely use registers.