`make verifiers` doesn't succeed on the master branch #35056

ashkrisk · 2024-07-29T05:18:28Z

ashkrisk
Jul 29, 2024

When I try to run make verifiers on the master branch, the command seems to fail during static-check. I'm not sure if this is a real issue, or a problem with my configuration. What am I doing wrong?

make verifiers

Error log

Running static-check check
Start check core packages
internal/querycoordv2/balance/score_based_balancer_test.go:568:18: ineffectual assignment to channelPlans (ineffassign)
                        segmentPlans, channelPlans = suite.getCollectionBalancePlans(balancer, c.collectionID)
                                      ^
internal/proxy/task.go:462: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task.go:530: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task.go:598: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task.go:938: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task.go:1075: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task.go:1158: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task.go:1266: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task.go:1340: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task.go:1745: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task.go:1839: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task.go:1989: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task.go:2094: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task.go:2159: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task.go:2227: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task.go:2292: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task.go:2418: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task.go:2483: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task.go:2557: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task_alias.go:92: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task_alias.go:243: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task_alias.go:387: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task_database.go:275: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task_database.go:354: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task_index.go:189: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task_index.go:443: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task_index.go:557: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task_index.go:669: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task_index.go:794: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task_index.go:912: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task_index.go:1023: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task_index.go:1113: File is not `gofumpt`-ed (gofumpt)

internal/proxy/task_index_test.go:57: File is not `gofumpt`-ed (gofumpt)
}
internal/proxy/task_index_test.go:620: File is not `gofumpt`-ed (gofumpt)
                assert.Equal(t, cit.newIndexParams, []*commonpb.KeyValuePair{{Key: common.IndexTypeKey, Value: indexparamcheck.IndexHybrid},
                        {Key: common.BitmapCardinalityLimitKey, Value: strconv.Itoa(paramtable.DefaultBitmapIndexCardinalityBound)}})
internal/proxy/task_index_test.go:662: File is not `gofumpt`-ed (gofumpt)
                assert.Equal(t, cit.newIndexParams, []*commonpb.KeyValuePair{{Key: common.IndexTypeKey, Value: indexparamcheck.IndexHybrid},
                        {Key: common.BitmapCardinalityLimitKey, Value: strconv.Itoa(paramtable.DefaultBitmapIndexCardinalityBound)}})
internal/proxy/task_index_test.go:889: File is not `gofumpt`-ed (gofumpt)
                assert.Equal(t, cit.newIndexParams, []*commonpb.KeyValuePair{{Key: common.IndexTypeKey, Value: indexparamcheck.IndexHybrid},
                        {Key: common.BitmapCardinalityLimitKey, Value: strconv.Itoa(paramtable.DefaultBitmapIndexCardinalityBound)}})
internal/proxy/task_index_test.go:917: File is not `gofumpt`-ed (gofumpt)
                assert.Equal(t, cit.newIndexParams, []*commonpb.KeyValuePair{{Key: common.IndexTypeKey, Value: indexparamcheck.IndexHybrid},
                        {Key: common.BitmapCardinalityLimitKey, Value: strconv.Itoa(paramtable.DefaultBitmapIndexCardinalityBound)}})
internal/proxy/task_index_test.go:945: File is not `gofumpt`-ed (gofumpt)
                assert.Equal(t, cit.newIndexParams, []*commonpb.KeyValuePair{{Key: common.IndexTypeKey, Value: indexparamcheck.IndexHybrid},
                        {Key: common.BitmapCardinalityLimitKey, Value: strconv.Itoa(paramtable.DefaultBitmapIndexCardinalityBound)}})
internal/proxy/task_index.go:174:12: indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
                                } else {
                                        return Params.AutoIndexConfig.ScalarVarcharIndexType.GetValue()
                                }
internal/proxy/task_index.go:185:12: indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
                                } else {
                                        return "", fmt.Errorf("create auto index on type:%s is not supported", dataType.String())
                                }
internal/proxy/task.go:461: unnecessary leading newline (whitespace)
func (t *dropCollectionTask) PreExecute(ctx context.Context) error {

internal/proxy/task.go:529: unnecessary leading newline (whitespace)
func (t *hasCollectionTask) PreExecute(ctx context.Context) error {

internal/proxy/task.go:597: unnecessary leading newline (whitespace)
func (t *describeCollectionTask) PreExecute(ctx context.Context) error {

internal/proxy/task.go:937: unnecessary leading newline (whitespace)
func (t *alterCollectionTask) PreExecute(ctx context.Context) error {

internal/proxy/task.go:1074: unnecessary leading newline (whitespace)
func (t *createPartitionTask) PreExecute(ctx context.Context) error {

internal/proxy/task.go:1157: unnecessary leading newline (whitespace)
func (t *dropPartitionTask) PreExecute(ctx context.Context) error {

internal/proxy/task.go:1265: unnecessary leading newline (whitespace)
func (t *hasPartitionTask) PreExecute(ctx context.Context) error {

internal/proxy/task.go:1339: unnecessary leading newline (whitespace)
func (t *showPartitionsTask) PreExecute(ctx context.Context) error {

internal/proxy/task.go:1744: unnecessary leading newline (whitespace)
func (t *releaseCollectionTask) PreExecute(ctx context.Context) error {

internal/proxy/task.go:1838: unnecessary leading newline (whitespace)
func (t *loadPartitionsTask) PreExecute(ctx context.Context) error {

internal/proxy/task.go:1988: unnecessary leading newline (whitespace)
func (t *releasePartitionsTask) PreExecute(ctx context.Context) error {

internal/proxy/task.go:2093: unnecessary leading newline (whitespace)
func (t *CreateResourceGroupTask) PreExecute(ctx context.Context) error {

internal/proxy/task.go:2158: unnecessary leading newline (whitespace)
func (t *UpdateResourceGroupsTask) PreExecute(ctx context.Context) error {

internal/proxy/task.go:2226: unnecessary leading newline (whitespace)
func (t *DropResourceGroupTask) PreExecute(ctx context.Context) error {

internal/proxy/task.go:2291: unnecessary leading newline (whitespace)
func (t *DescribeResourceGroupTask) PreExecute(ctx context.Context) error {

internal/proxy/task.go:2417: unnecessary leading newline (whitespace)
func (t *TransferNodeTask) PreExecute(ctx context.Context) error {

internal/proxy/task.go:2482: unnecessary leading newline (whitespace)
func (t *TransferReplicaTask) PreExecute(ctx context.Context) error {

internal/proxy/task.go:2556: unnecessary leading newline (whitespace)
func (t *ListResourceGroupsTask) PreExecute(ctx context.Context) error {

internal/proxy/task_alias.go:91: unnecessary leading newline (whitespace)
func (t *CreateAliasTask) PreExecute(ctx context.Context) error {

internal/proxy/task_alias.go:242: unnecessary leading newline (whitespace)
func (t *AlterAliasTask) PreExecute(ctx context.Context) error {

internal/proxy/task_alias.go:386: unnecessary leading newline (whitespace)
func (a *ListAliasesTask) PreExecute(ctx context.Context) error {

internal/proxy/task_database.go:274: unnecessary leading newline (whitespace)
func (t *alterDatabaseTask) PreExecute(ctx context.Context) error {

internal/proxy/task_database.go:353: unnecessary leading newline (whitespace)
func (t *describeDatabaseTask) PreExecute(ctx context.Context) error {

internal/proxy/task_index.go:195: unnecessary trailing newline (whitespace)

                }
internal/proxy/task_index.go:442: unnecessary leading newline (whitespace)
func (cit *createIndexTask) PreExecute(ctx context.Context) error {

internal/proxy/task_index.go:556: unnecessary leading newline (whitespace)
func (t *alterIndexTask) PreExecute(ctx context.Context) error {

internal/proxy/task_index.go:668: unnecessary leading newline (whitespace)
func (dit *describeIndexTask) PreExecute(ctx context.Context) error {

internal/proxy/task_index.go:793: unnecessary leading newline (whitespace)
func (dit *getIndexStatisticsTask) PreExecute(ctx context.Context) error {

internal/proxy/task_index.go:911: unnecessary leading newline (whitespace)
func (dit *dropIndexTask) PreExecute(ctx context.Context) error {

internal/proxy/task_index.go:1022: unnecessary leading newline (whitespace)
func (gibpt *getIndexBuildProgressTask) PreExecute(ctx context.Context) error {

internal/proxy/task_index.go:1112: unnecessary leading newline (whitespace)
func (gist *getIndexStateTask) PreExecute(ctx context.Context) error {

make: *** [Makefile:164: static-check] Error 1

Answered by yhmo

Jul 30, 2024

@ashkrisk
The pr #35084 has fixed this issue. You can try it again.

View full answer

yhmo · 2024-07-29T07:47:23Z

yhmo
Jul 29, 2024
Collaborator

I got the same error. I guess the reason is related to Go version. My Go version is 1.20, the milvus source code requires Go 1.21.

7 replies

ashkrisk Jul 29, 2024
Author

Can I raise a PR to fix this?

yhmo Jul 29, 2024
Collaborator

Sure, that would be appreciated. You have found the root cause?

ashkrisk Jul 29, 2024
Author

Most of the issues are because there's a newline right after after the function definition:

func (dit *dropIndexTask) PreExecute(ctx context.Context) error {

	collName, fieldName := dit.CollectionName, dit.FieldName

Removing the newline should fix the issue.

In other cases the tool doesn't seem to like returns nested in else clauses

 getPrimitiveIndexType := func(dataType schemapb.DataType) string {
 	if typeutil.IsBoolType(dataType) {
 		return Params.AutoIndexConfig.ScalarBoolIndexType.GetValue()
 	} else if typeutil.IsIntegerType(dataType) {
 		return Params.AutoIndexConfig.ScalarIntIndexType.GetValue()
 	} else if typeutil.IsFloatingType(dataType) {
 		return Params.AutoIndexConfig.ScalarFloatIndexType.GetValue()
-	} else {
+	}
-		return Params.AutoIndexConfig.ScalarVarcharIndexType.GetValue()
+	return Params.AutoIndexConfig.ScalarVarcharIndexType.GetValue()
-	}
}

I think most of those are easy to fix, will take a look at the others as well

yhmo Jul 30, 2024
Collaborator

@ashkrisk
The pr #35084 has fixed this issue. You can try it again.

Answer selected by ashkrisk

ashkrisk Jul 30, 2024
Author

Pulled and tried again, static-check seems to work now. Thanks @yhmo @congqixia!

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

`make verifiers` doesn't succeed on the master branch #35056

Uh oh!

{{title}}

Uh oh!

Replies: 1 comment 7 replies

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

make verifiers doesn't succeed on the master branch #35056

Uh oh!

ashkrisk Jul 29, 2024

Replies: 1 comment · 7 replies

Uh oh!

yhmo Jul 29, 2024 Collaborator

Uh oh!

ashkrisk Jul 29, 2024 Author

Uh oh!

yhmo Jul 29, 2024 Collaborator

Uh oh!

Uh oh!

ashkrisk Jul 29, 2024 Author

Uh oh!

yhmo Jul 30, 2024 Collaborator

Uh oh!

ashkrisk Jul 30, 2024 Author

`make verifiers` doesn't succeed on the master branch #35056

ashkrisk
Jul 29, 2024

Replies: 1 comment 7 replies

yhmo
Jul 29, 2024
Collaborator

ashkrisk Jul 29, 2024
Author

yhmo Jul 29, 2024
Collaborator

ashkrisk Jul 29, 2024
Author

yhmo Jul 30, 2024
Collaborator

ashkrisk Jul 30, 2024
Author