fix: add missing app property (#4422)

Author: czy88840616

packages/web-koa/src/framework.ts

@@ -19,7 +19,6 @@ import {
   IMidwayKoaApplication,
   IMidwayKoaConfigurationOptions,
   IMidwayKoaContext,
-  IWebMiddleware,
 } from './interface';
 import * as Router from '@koa/router';
 import type { DefaultState, Middleware, Next } from 'koa';
@@ -234,7 +233,10 @@ export class MidwayKoaFramework extends BaseFramework<
       this.webRouterService
     );
 
-    this.defineApplicationProperties();
+    this.defineApplicationProperties({
+      generateController: this.generateController.bind(this),
+      getPort: this.getPort.bind(this),
+    });
 
     // hack use method
     (this.app as any).originUse = this.app.use;
@@ -260,17 +262,6 @@ export class MidwayKoaFramework extends BaseFramework<
     return this.generator.generateKoaController(routeInfo);
   }
 
-  /**
-   * @deprecated
-   * @param middlewareId
-   */
-  public async generateMiddleware(middlewareId: any) {
-    const mwIns = await this.getApplicationContext().getAsync<IWebMiddleware>(
-      middlewareId
-    );
-    return mwIns.resolve();
-  }
-
   public async run(): Promise<void> {
     // load controller
     await this.loadMidwayController();

packages/web-koa/src/interface.ts

@@ -14,11 +14,6 @@ export type IMidwayKoaApplication = IMidwayApplication<IMidwayKoaContext, koa<St
     routeArgsInfo?: RouterParamValue[],
     routerResponseData?: any []
   ): Middleware<State, IMidwayKoaContext>;
-  /**
-   * @deprecated
-   * @param middlewareId
-   */
-  generateMiddleware(middlewareId: any): Promise<Middleware<State, IMidwayKoaContext>>;
   /**
    * Get the port that the application is listening on
    */

packages/web-koa/test/index.test.ts

@@ -774,5 +774,37 @@ describe('/test/feature.test.ts', () => {
 
       await closeApp(app);
     });
+
+    it('should test app methods existence', async () => {
+      @Controller()
+      class HomeController {
+        @Get('/')
+        async query() {
+          return 'hello world'
+        }
+      }
+      const app = await createLightApp('', {
+        imports: [
+          require('../src'),
+        ],
+        preloadModules: [
+          HomeController
+        ],
+        globalConfig: {
+          keys: '123',
+          koa: {
+            port: null, // 不监听端口
+          }
+        }
+      }) as IMidwayKoaApplication;
+
+      await sleep();
+
+      // 验证 app 实例上的方法是否存在
+      expect(typeof app.generateController).toBe('function');
+      expect(typeof app.getPort).toBe('function');
+
+      await closeApp(app);
+    });
   });
 });