Skip to content

Commit 2392502

Browse files
authored
feat: support new cookies options (#4329)
1 parent dd77c8b commit 2392502

File tree

4 files changed

+15
-3
lines changed

4 files changed

+15
-3
lines changed

packages/session/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"@midwayjs/mock": "^3.20.4"
1515
},
1616
"dependencies": {
17-
"@midwayjs/cookies": "^1.0.2"
17+
"@midwayjs/cookies": "^1.3.0"
1818
},
1919
"keywords": [
2020
"midway",

packages/web-koa/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
},
3131
"dependencies": {
3232
"@koa/router": "^12.0.0",
33-
"@midwayjs/cookies": "^1.0.2",
33+
"@midwayjs/cookies": "^1.3.0",
3434
"@midwayjs/core": "^3.20.4",
3535
"@midwayjs/session": "^3.20.4",
3636
"@types/koa": "2.15.0",

packages/web-koa/src/config/config.default.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,12 @@ export const cookies = {
4242
// httpOnly: true | false,
4343
// sameSite: 'none|lax|strict',
4444
};
45+
/**
46+
* default cookie get options
47+
*/
48+
export const cookiesGet = {
49+
// sign: false,
50+
};
4551

4652
export const onerror = {};
4753

packages/web-koa/src/framework.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ export class MidwayKoaFramework extends BaseFramework<
7272
}
7373

7474
const cookieOptions = this.configService.getConfiguration('cookies');
75+
const cookieGetOptions = this.configService.getConfiguration('cookiesGet');
7576

7677
this.app = new koa<DefaultState, IMidwayKoaContext>({
7778
keys: [].concat(appKeys),
@@ -84,7 +85,12 @@ export class MidwayKoaFramework extends BaseFramework<
8485
Object.defineProperty(this.app.context, 'cookies', {
8586
get() {
8687
if (!this[COOKIES]) {
87-
this[COOKIES] = new Cookies(this, this.app.keys, cookieOptions);
88+
this[COOKIES] = new Cookies(
89+
this,
90+
this.app.keys,
91+
cookieOptions,
92+
cookieGetOptions
93+
);
8894
}
8995
return this[COOKIES];
9096
},

0 commit comments

Comments
 (0)