Refactor view logic into helpers and partials (#159)

* First refactor on views and creation of comment and user partial

* Add wdm gem for windows

* Fix comments partial on /posts/show

* Change ruby version back to 2.7.0 and remove username and password from database.yml

Co-authored-by: sarah <sarachamorro@gmail.com>

Author: uryelah

Gemfile

@@ -26,7 +26,8 @@ gem 'jbuilder', '~> 2.5'
 # gem 'redis', '~> 4.0'
 # Use ActiveModel has_secure_password
 # gem 'bcrypt', '~> 3.1.7'
-
+# Install wdm Gem if the platform is Windows
+gem 'wdm', '>= 0.1.0' if Gem.win_platform?
 # Use ActiveStorage variant
 # gem 'mini_magick', '~> 4.8'
 

Gemfile.lock

@@ -69,6 +69,7 @@ GEM
     erubi (1.9.0)
     execjs (2.7.0)
     ffi (1.12.2)
+    ffi (1.12.2-x64-mingw32)
     globalid (0.4.2)
       activesupport (>= 4.2.0)
     i18n (1.8.2)
@@ -93,14 +94,18 @@ GEM
     mini_portile2 (2.4.0)
     minitest (5.14.0)
     msgpack (1.3.3)
+    msgpack (1.3.3-x64-mingw32)
     nio4r (2.5.2)
     nokogiri (1.10.9)
       mini_portile2 (~> 2.4.0)
+    nokogiri (1.10.9-x64-mingw32)
+      mini_portile2 (~> 2.4.0)
     orm_adapter (0.5.0)
     parallel (1.19.1)
     parser (2.7.0.4)
       ast (~> 2.4.0)
     pg (1.2.2)
+    pg (1.2.2-x64-mingw32)
     puma (3.12.6)
     rack (2.2.3)
     rack-test (1.1.0)
@@ -191,11 +196,14 @@ GEM
     turbolinks-source (5.2.0)
     tzinfo (1.2.6)
       thread_safe (~> 0.1)
+    tzinfo-data (1.2020.1)
+      tzinfo (>= 1.0.0)
     uglifier (4.2.0)
       execjs (>= 0.3.0, < 3)
     unicode-display_width (1.6.1)
     warden (1.2.8)
       rack (>= 2.0.6)
+    wdm (0.1.1)
     web-console (3.7.0)
       actionview (>= 5.0)
       activemodel (>= 5.0)
@@ -207,6 +215,7 @@ GEM
 
 PLATFORMS
   ruby
+  x64-mingw32
 
 DEPENDENCIES
   bootsnap (>= 1.1.0)
@@ -226,6 +235,7 @@ DEPENDENCIES
   turbolinks (~> 5)
   tzinfo-data
   uglifier (>= 1.3.0)
+  wdm (>= 0.1.0)
   web-console (>= 3.3.0)
 
 RUBY VERSION

app/helpers/post_helper.rb

@@ -0,0 +1,7 @@
+module PostHelper
+  def display_errors(post)
+    return unless post.errors.full_messages.any?
+
+    content_tag :p, "Post could not be saved. #{post.errors.full_messages.join('. ')}", class: 'errors'
+  end
+end

app/views/comments/_comment.html.erb

@@ -0,0 +1,6 @@
+<div class="post-comments">
+  <p>
+    <b><%= comment.user.name %>:</b> <%= comment.content %>
+  </p>
+  <span> <%= comment.created_at.strftime("%Y/%m/%d") %> </span>
+</div>

app/views/posts/_post.html.erb

@@ -13,14 +13,7 @@
   </p>
 
   <div class='post-comments-section'>
-    <% post.comments.each do |comment| %>
-      <div class="post-comments">
-        <p>
-          <b><%= comment.user.name %>:</b> <%= comment.content %>
-        </p>
-        <span> <%= comment.created_at.strftime("%Y/%m/%d") %> </span>
-      </div>
-    <% end %>
+    <%= render partial: 'comments/comment', collection: post.comments %>
 
     <%= form_for(post.comments.new, url: post_comments_path(post)) do |form| %>
       <%= form.text_field :content, id: :comment_content, class: 'form-control', placeholder: 'Add new Comment' %>

app/views/posts/index.html.erb

@@ -1,11 +1,7 @@
 <%= form_for(@post) do |form| %>
   <%= form.label :content %>
   <%= form.text_field :content, id: :post_content, class: 'form-control', placeholder: 'Add New Post' %>
-  <% if @post.errors.full_messages.any? %>
-    <p class="errors">
-      <%= "Post could not be saved. #{@post.errors.full_messages.join('. ')}" %>
-    </p>
-  <% end %>
+  <%= display_errors(@post) %>
   <%= form.submit 'Save', class: 'btn btn-primary' %>
 <% end %>
 

app/views/users/_user.html.erb

@@ -0,0 +1,6 @@
+<li>
+  Name: <%= user.name %>
+  <span class="profile-link">
+    <%= link_to 'See Profile',  user_path(user), class: 'profile-link' %>
+  </span>
+</li>

app/views/users/index.html.erb

@@ -1,12 +1,5 @@
 <section class="users-section">
   <ul class="users-list">
-    <% @users.each do |user| %>
-      <li>
-        Name: <%= user.name %>
-        <span class="profile-link">
-          <%= link_to 'See Profile',  user_path(user), class: 'profile-link' %>
-        </span>
-      </li>
-    <% end %>
+    <%= render @users %>
   </ul>
 </section>