MS Graph SDK PUT requests do not resend properties unless you use the set*** methods

[willfiddes]

Issue

This might be expected behavior however this behavior should change. This has high risk of accidently removing configurations if not properly implemented.

PUT requests for accessPackageAssignmentPolicy only sends properties when you use set*** methods.
I have not used or tested other API calls that also use PUT so not sure if this is a problem for all PUT related calls.

For example...

AccessPackageAssignmentPolicy accessPackageAssignmentPolicy = graphClient.identityGovernance().entitlementManagement().assignmentPolicies().byAccessPackageAssignmentPolicyId("cfd19f11-c7d8-4ebe-8d22-57c338ce2a1b").get();

ExpirationPattern expirationPattern = new ExpirationPattern();
expirationPattern.setDuration(PeriodAndDuration.ofDuration(Duration.parse("PT4H")));
expirationPattern.setType(ExpirationPatternType.AfterDuration);
accessPackageAssignmentPolicy.setExpiration(expirationPattern);

graphClient.identityGovernance().entitlementManagement().assignmentPolicies().byAccessPackageAssignmentPolicyId(accessPackageAssignmentPolicy.getId()).put(accessPackageAssignmentPolicy);

Expected behavior

I would expect since I have already grabbed the accessPackageAssignmentPolicy, sending the PUT command will send all of the known accessPackageAssignmentPolicy properties along with the ExpirationPattern change. I should not be required to re-set everything.

Actual behavior

MS Graph SDK only sends ExpirationPattern in the request.

Workaround: You have to manually call each set*** method to make sure it gets passed in the PUT request

AccessPackageAssignmentPolicy accessPackageAssignmentPolicy = graphClient.identityGovernance().entitlementManagement().assignmentPolicies().byAccessPackageAssignmentPolicyId("cfd19f11-c7d8-4ebe-8d22-57c338ce2a1b").get();

ExpirationPattern expirationPattern = new ExpirationPattern();
expirationPattern.setDuration(PeriodAndDuration.ofDuration(Duration.parse("PT4H")));
expirationPattern.setType(ExpirationPatternType.AfterDuration);
accessPackageAssignmentPolicy.setExpiration(expirationPattern);

accessPackageAssignmentPolicy.setDisplayName(accessPackageAssignmentPolicy.getDisplayName());
accessPackageAssignmentPolicy.setDescription(accessPackageAssignmentPolicy.getDescription());
accessPackageAssignmentPolicy.setAllowedTargetScope(accessPackageAssignmentPolicy.getAllowedTargetScope());
accessPackageAssignmentPolicy.setAutomaticRequestSettings(accessPackageAssignmentPolicy.getAutomaticRequestSettings());
accessPackageAssignmentPolicy.setSpecificAllowedTargets(accessPackageAssignmentPolicy.getSpecificAllowedTargets());
accessPackageAssignmentPolicy.setRequestorSettings(accessPackageAssignmentPolicy.getRequestorSettings());
accessPackageAssignmentPolicy.setRequestApprovalSettings(accessPackageAssignmentPolicy.getRequestApprovalSettings());
accessPackageAssignmentPolicy.setAccessPackage(accessPackageAssignmentPolicy.getAccessPackage());

graphClient.identityGovernance().entitlementManagement().assignmentPolicies().byAccessPackageAssignmentPolicyId(accessPackageAssignmentPolicy.getId()).put(accessPackageAssignmentPolicy);

[andrueastman]

Thanks for raising this @willfiddes

This behaviour is due to the SDK using the backing store feature from Kiota. https://learn.microsoft.com/en-us/openapi/kiota/backing-store#backing-store-features

To enable the serialization of all propeties you can set the property in the backingstore as below rather than resetting all properties.

  AccessPackageAssignmentPolicy accessPackageAssignmentPolicy = graphClient.identityGovernance().entitlementManagement().assignmentPolicies().byAccessPackageAssignmentPolicyId("cfd19f11-c7d8-4ebe-8d22-57c338ce2a1b").get();
  // make other changes to properties

  accessPackageAssignmentPolicy.getBackingStore().setIsInitializationCompleted(false);// ensure all properties are serialized
  graphClient.identityGovernance().entitlementManagement().assignmentPolicies().byAccessPackageAssignmentPolicyId(accessPackageAssignmentPolicy.getId()).put(accessPackageAssignmentPolicy);

Any chance you can confirm this works for you?

[microsoft-github-policy-service]

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.