Skip to content

Commit ad37299

Browse files
authored
Rename IsRetry -> ShouldRetry
1 parent b6fbd7a commit ad37299

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/Microsoft.Graph.Core/Requests/Middleware/RetryHandler.cs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ protected async override Task<HttpResponseMessage> SendAsync(HttpRequestMessage
6060

6161
var response = await base.SendAsync(httpRequest, cancellationToken);
6262

63-
if(IsRetry(response) && httpRequest.IsBuffered() && RetryOption.MaxRetry > 0 && RetryOption.ShouldRetry(RetryOption.Delay, 0, response))
63+
if(ShouldRetry(response) && httpRequest.IsBuffered() && RetryOption.MaxRetry > 0 && RetryOption.ShouldRetry(RetryOption.Delay, 0, response))
6464
{
6565
response = await SendRetryAsync(response, cancellationToken);
6666
}
@@ -95,7 +95,7 @@ private async Task<HttpResponseMessage> SendRetryAsync(HttpResponseMessage respo
9595
// Call base.SendAsync to send the request
9696
response = await base.SendAsync(request, cancellationToken);
9797

98-
if (!IsRetry(response) || !request.IsBuffered() || !RetryOption.ShouldRetry(RetryOption.Delay, retryCount, response))
98+
if (!ShouldRetry(response) || !request.IsBuffered() || !RetryOption.ShouldRetry(RetryOption.Delay, retryCount, response))
9999
{
100100
return response;
101101
}
@@ -133,7 +133,6 @@ private void AddOrUpdateRetryAttempt(HttpRequestMessage request, int retry_count
133133
/// <returns>The <see cref="Task"/> for delay operation.</returns>
134134
public Task Delay(HttpResponseMessage response, int retry_count, int delay, CancellationToken cancellationToken)
135135
{
136-
//TimeSpan delayTimeSpan = TimeSpan.FromMilliseconds(0);
137136
HttpHeaders headers = response.Headers;
138137
double delayInSeconds = RetryOption.Delay;
139138
if (headers.TryGetValues(RETRY_AFTER, out IEnumerable<string> values))
@@ -161,7 +160,7 @@ public Task Delay(HttpResponseMessage response, int retry_count, int delay, Canc
161160
/// </summary>
162161
/// <param name="response">The <see cref="HttpResponseMessage"/>returned.</param>
163162
/// <returns></returns>
164-
private bool IsRetry(HttpResponseMessage response)
163+
private bool ShouldRetry(HttpResponseMessage response)
165164
{
166165
if ((response.StatusCode == HttpStatusCode.ServiceUnavailable ||
167166
response.StatusCode == (HttpStatusCode)429))

0 commit comments

Comments
 (0)