fix: fixes performance issue when using the AddBatchRequestStepAsync method due to the client trying to authenticate the request on conversion using the

Author: Andrew Omondi

src/Microsoft.Graph.Core/Microsoft.Graph.Core.csproj

@@ -62,16 +62,16 @@
     </None>
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="Microsoft.IdentityModel.Protocols.OpenIdConnect" Version="8.3.0" />
-    <PackageReference Include="Microsoft.IdentityModel.Validators" Version="8.3.0" />
+    <PackageReference Include="Microsoft.IdentityModel.Protocols.OpenIdConnect" Version="8.3.1" />
+    <PackageReference Include="Microsoft.IdentityModel.Validators" Version="8.3.1" />
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All" />
     <PackageReference Include="Microsoft.Kiota.Abstractions" Version="1.16.4" />
     <PackageReference Include="Microsoft.Kiota.Authentication.Azure" Version="1.16.4" />
     <PackageReference Include="Microsoft.Kiota.Serialization.Json" Version="1.16.4" />
-    <PackageReference Include="Microsoft.Kiota.Serialization.Text" Version="1.16.3" />
-    <PackageReference Include="Microsoft.Kiota.Serialization.Form" Version="1.16.3" />
+    <PackageReference Include="Microsoft.Kiota.Serialization.Text" Version="1.16.4" />
+    <PackageReference Include="Microsoft.Kiota.Serialization.Form" Version="1.16.4" />
     <PackageReference Include="Microsoft.Kiota.Http.HttpClientLibrary" Version="1.16.4" />
-    <PackageReference Include="Microsoft.Kiota.Serialization.Multipart" Version="1.16.3" />
+    <PackageReference Include="Microsoft.Kiota.Serialization.Multipart" Version="1.16.4" />
     <PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.12.19">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>

src/Microsoft.Graph.Core/Requests/Content/BatchRequestContent.cs

@@ -17,6 +17,7 @@ namespace Microsoft.Graph
     using System.Threading;
     using System.Threading.Tasks;
     using Microsoft.Kiota.Abstractions;
+    using Microsoft.Kiota.Abstractions.Authentication;
 
     /// <summary>
     /// A <see cref="HttpContent"/> implementation to handle json batch requests.
@@ -71,7 +72,7 @@ public BatchRequestContent(IRequestAdapter requestAdapter, params BatchRequestSt
             if (batchRequestSteps == null)
                 throw new ArgumentNullException(nameof(batchRequestSteps));
 
-            if (batchRequestSteps.Count() > CoreConstants.BatchRequest.MaxNumberOfRequests)
+            if (batchRequestSteps.Length > CoreConstants.BatchRequest.MaxNumberOfRequests)
                 throw new ArgumentException(string.Format(ErrorConstants.Messages.MaximumValueExceeded, "Number of batch request steps", CoreConstants.BatchRequest.MaxNumberOfRequests));
 
             this.Headers.ContentType = new MediaTypeHeaderValue(CoreConstants.MimeTypeNames.Application.Json);
@@ -87,7 +88,12 @@ public BatchRequestContent(IRequestAdapter requestAdapter, params BatchRequestSt
                 AddBatchRequestStep(requestStep);
             }
 
-            this.RequestAdapter = requestAdapter ?? throw new ArgumentNullException(nameof(requestAdapter));
+            // as we only use the adapter to serialize request using the `ConvertToNativeRequestAsync` interface,
+            // we don't want to make extra request to the authentication provider as the request does not need the authentication header.
+            this.RequestAdapter = new BaseGraphRequestAdapter(new AnonymousAuthenticationProvider())
+            {
+                BaseUrl = requestAdapter.BaseUrl
+            };
         }
 
         /// <summary>

tests/Microsoft.Graph.DotnetCore.Core.Test/Requests/Content/BatchRequestContentTests.cs

@@ -181,7 +181,7 @@ public void BatchRequestContent_RemoveBatchRequestStepWithIdForNonExistingId()
 
             Assert.False(isSuccess);
             Assert.True(batchRequestContent.BatchRequestSteps.Count.Equals(2));
-            Assert.Same(batchRequestStep2.DependsOn.First(), batchRequestContent.BatchRequestSteps["2"].DependsOn.First());
+            Assert.Same(batchRequestStep2.DependsOn[0], batchRequestContent.BatchRequestSteps["2"].DependsOn[0]);
         }
 
         [Fact]
@@ -311,6 +311,28 @@ public async System.Threading.Tasks.Task BatchRequestContent_GetBatchRequestCont
             Assert.Equal(expectedContent, requestContent);
         }
 
+        [Fact]
+        public async System.Threading.Tasks.Task BatchRequestContent_GetBatchRequestContentFromRequestInformationDoesNotAddAuthHeaderAsync()
+        {
+            BatchRequestContent batchRequestContent = new BatchRequestContent(client);
+            RequestInformation requestInformation = new RequestInformation() { HttpMethod = Method.GET, UrlTemplate = REQUEST_URL };
+            await batchRequestContent.AddBatchRequestStepAsync(requestInformation, "2");
+
+            string requestContent;
+            // We get the contents of the stream as string for comparison.
+            using (Stream requestStream = await batchRequestContent.GetBatchRequestContentAsync())
+            using (StreamReader reader = new StreamReader(requestStream))
+            {
+                requestContent = await reader.ReadToEndAsync();
+            }
+
+            string expectedContent = "{\"requests\":[{\"id\":\"2\",\"url\":\"/me\",\"method\":\"GET\"}]}";
+
+            Assert.NotNull(requestContent);
+            Assert.True(batchRequestContent.BatchRequestSteps.Count.Equals(1));
+            Assert.Equal(expectedContent, requestContent);
+        }
+
         [Fact]
         public async System.Threading.Tasks.Task BatchRequestContent_GetBatchRequestContentSupportsNonJsonPayloadAsync()
         {
@@ -331,7 +353,7 @@ public async System.Threading.Tasks.Task BatchRequestContent_GetBatchRequestCont
             string requestContent;
             // we do this to get a version of the json that is indented
             using (Stream requestStream = await batchRequestContent.GetBatchRequestContentAsync())
-            using (JsonDocument jsonDocument = JsonDocument.Parse(requestStream))
+            using (JsonDocument jsonDocument = await JsonDocument.ParseAsync(requestStream))
             {
                 requestContent = JsonSerializer.Serialize(jsonDocument.RootElement, new JsonSerializerOptions() { WriteIndented = true });
             }
@@ -409,7 +431,7 @@ public async System.Threading.Tasks.Task BatchRequestContent_GetBatchRequestCont
             string requestContent;
             // we do this to get a version of the json that is indented
             using (Stream requestStream = await batchRequestContent.GetBatchRequestContentAsync())
-            using (JsonDocument jsonDocument = JsonDocument.Parse(requestStream))
+            using (JsonDocument jsonDocument = await JsonDocument.ParseAsync(requestStream))
             {
                 requestContent = JsonSerializer.Serialize(jsonDocument.RootElement, new JsonSerializerOptions() { WriteIndented = true });
             }
@@ -532,7 +554,7 @@ public void BatchRequestContent_AddBatchRequestStepWithHttpRequestMessageToBatch
 
             // Assert
             var exception = Assert.Throws<ArgumentException>(() => batchRequestContent.AddBatchRequestStep(extraHttpRequestMessage));//Assert we throw exception on excess add
-            //Assert.Equal(ErrorConstants.Codes.MaximumValueExceeded, exception.Error.Code);
+            Assert.Equal(ErrorConstants.Messages.MaximumValueExceeded, exception.Message);
             Assert.NotNull(batchRequestContent.BatchRequestSteps);
             Assert.True(batchRequestContent.BatchRequestSteps.Count.Equals(CoreConstants.BatchRequest.MaxNumberOfRequests));
         }
@@ -612,7 +634,7 @@ public async Task BatchRequestContent_AddBatchRequestStepWithBaseRequestToBatchR
             var exception = await Assert.ThrowsAsync<ArgumentException>(() => batchRequestContent.AddBatchRequestStepAsync(extraRequestInformation));
 
             // Assert
-            //Assert.Equal(ErrorConstants.Codes.MaximumValueExceeded, exception.Error.Code);
+            Assert.Equal(ErrorConstants.Messages.MaximumValueExceeded, exception.Message);
             Assert.NotNull(batchRequestContent.BatchRequestSteps);
             Assert.True(batchRequestContent.BatchRequestSteps.Count.Equals(CoreConstants.BatchRequest.MaxNumberOfRequests));
         }