Added AreaPath and IterationPath migration with tests #85
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| using System; | ||
| using System.Linq; | ||
| using System.Threading.Tasks; | ||
| using Common.Config; | ||
| using Logging; | ||
| using Microsoft.Extensions.Logging; | ||
| using Microsoft.TeamFoundation.WorkItemTracking.WebApi.Models; | ||
|
|
||
| namespace Common.Migration | ||
| { | ||
|
|
||
| public class ClassificationNodesPreProcessor : IPhase1PreProcessor | ||
| { | ||
| static ILogger Logger { get; } = MigratorLogging.CreateLogger<ClassificationNodesPreProcessor>(); | ||
| private IMigrationContext context; | ||
|
|
||
| public string Name => "Classification Nodes (Area Paths/Iterations)"; | ||
|
|
||
| public bool IsEnabled(ConfigJson config) | ||
| { | ||
| return config.MoveAreaPaths || config.MoveIterations; | ||
| } | ||
|
|
||
| public async Task Prepare(IMigrationContext context) | ||
| { | ||
| this.context = context; | ||
| } | ||
|
|
||
| public async Task Process(IBatchMigrationContext batchContext) | ||
| { | ||
| int modificationCount = 0; | ||
| await Task.WhenAll( | ||
| Migrator.ReadSourceNodes(context, context.Config.SourceConnection.Project), | ||
| Migrator.ReadTargetNodes(context, context.Config.TargetConnection.Project)); | ||
|
|
||
| if (context.Config.MoveAreaPaths) | ||
| { | ||
| modificationCount += await ProcessAreaPaths(batchContext); | ||
| } | ||
|
|
||
| if (context.Config.MoveIterations) | ||
| { | ||
| modificationCount += await ProcessIterationPaths(batchContext); | ||
| } | ||
|
|
||
| if (modificationCount > 0) | ||
|
There was a problem hiding this comment. i'm not a fan of the pattern of passing an int and then assigning it in the return. Either make it an out or just have two variables. |
||
| { | ||
| await Migrator.ReadTargetNodes(context, context.Config.TargetConnection.Project); | ||
| } | ||
| } | ||
|
|
||
| public async Task<int> ProcessIterationPaths(IBatchMigrationContext batchContext) | ||
| { | ||
| int modificationCount = 0; | ||
| Logger.LogInformation(LogDestination.All, $"Identified {context.SourceAreaAndIterationTree.IterationPathList.Count} iterations in source project."); | ||
|
|
||
| foreach (var iterationPath in context.SourceAreaAndIterationTree.IterationPathList) | ||
| { | ||
| string iterationPathInTarget = AreaAndIterationPathTree.ReplaceLeadingProjectName(iterationPath, | ||
| context.Config.SourceConnection.Project, context.Config.TargetConnection.Project); | ||
|
|
||
| // If the iteration path is not found in the work items we're currently processing then just ignore it. | ||
| if (!batchContext.SourceWorkItems.Any(w => w.Fields.ContainsKey("System.IterationPath") && w.Fields["System.IterationPath"].ToString().ToLower().Equals(iterationPath.ToLower()))) | ||
|
There was a problem hiding this comment. instead of all the tolowers, why not just do a stringcomparison.ignorecase |
||
| continue; | ||
|
|
||
| if (context.TargetAreaAndIterationTree.IterationPathListLookup.ContainsKey(iterationPathInTarget)) | ||
| { | ||
| Logger.LogInformation(LogDestination.All, $"[Exists] {iterationPathInTarget}."); | ||
|
There was a problem hiding this comment. mind including a little more detail, like "[Iteration path exists] |
||
| } | ||
| else | ||
| { | ||
| var sourceIterationNode = context.SourceAreaAndIterationTree.IterationPathListLookup[iterationPath]; | ||
| modificationCount += 1; | ||
| await CreateIterationPath(iterationPath, sourceIterationNode); | ||
|
|
||
| Logger.LogSuccess(LogDestination.All, $"[Created] {iterationPathInTarget}."); | ||
| } | ||
| } | ||
|
|
||
| Logger.LogInformation(LogDestination.All, $"Iterations synchronized."); | ||
| return modificationCount; | ||
| } | ||
|
|
||
| public async virtual Task CreateIterationPath(string iterationPath, WorkItemClassificationNode sourceIterationNode) | ||
| { | ||
| await WorkItemTrackingHelpers.CreateIterationAsync( | ||
| context.TargetClient.WorkItemTrackingHttpClient, | ||
| context.Config.TargetConnection.Project, | ||
| iterationPath, | ||
| sourceIterationNode.Attributes == null ? null : (DateTime?)sourceIterationNode.Attributes?["startDate"], | ||
| sourceIterationNode.Attributes == null ? null : (DateTime?)sourceIterationNode.Attributes["finishDate"]); | ||
| } | ||
|
|
||
| public async Task<int> ProcessAreaPaths(IBatchMigrationContext batchContext) | ||
| { | ||
| int modificationCount = 0; | ||
| Logger.LogInformation(LogDestination.All, $"Identified {context.SourceAreaAndIterationTree.AreaPathListLookup.Count} area paths in source project."); | ||
|
|
||
| foreach (var areaPath in context.SourceAreaAndIterationTree.AreaPathList) | ||
| { | ||
| string areaPathInTarget = AreaAndIterationPathTree.ReplaceLeadingProjectName(areaPath, | ||
| context.Config.SourceConnection.Project, context.Config.TargetConnection.Project); | ||
|
|
||
| // If the area path is not found in the work items we're currently processing then just ignore it. | ||
| if (!batchContext.SourceWorkItems.Any(w => w.Fields.ContainsKey("System.AreaPath") && w.Fields["System.AreaPath"].ToString().ToLower().Equals(areaPath.ToLower()))) | ||
| { | ||
| continue; | ||
| } | ||
| else if (context.TargetAreaAndIterationTree.AreaPathList.Any(a => a.ToLower() == areaPathInTarget.ToLower())) | ||
| { | ||
| Logger.LogInformation(LogDestination.All, $"[Exists] {areaPathInTarget}."); | ||
| } | ||
| else | ||
| { | ||
| modificationCount += 1; | ||
| await CreateAreaPath(areaPathInTarget); | ||
| Logger.LogSuccess(LogDestination.All, $"[Created] {areaPathInTarget}."); | ||
| } | ||
| } | ||
|
|
||
| Logger.LogInformation(LogDestination.All, $"Area paths synchronized."); | ||
| return modificationCount; | ||
| } | ||
|
|
||
| public async virtual Task CreateAreaPath(string areaPathInTarget) | ||
| { | ||
| await WorkItemTrackingHelpers.CreateAreaPathAsync(context.TargetClient.WorkItemTrackingHttpClient, context.Config.TargetConnection.Project, areaPathInTarget); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mind updating the comment block?