Skip to content

Update the initial chunked attachment creation on the target to use an empty content #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update the initial chunked attachment creation on the target to use an empty content #76

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b69215c
Update the Attachment Ref Creation on the target to use an empty content
Dedac Sep 18, 2019
b91aefc
Merge remote-tracking branch 'upstream/master'
Dedac Apr 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions Common/WorkItemTrackingHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,13 @@ public async static Task<AttachmentReference> CreateAttachmentChunkedAsync(WorkI
// can't use the WorkItemTrackingHttpClient since it expects either a file or a stream.
var attachmentReference = await RetryHelper.RetryAsync(async () =>
{
var request = new HttpRequestMessage(HttpMethod.Post, $"{connection.Uri}/_apis/wit/attachments?uploadType=chunked&api-version=3.2");
//Create and empty content for the attachement reference POST so that we don't get an error from the server for sending the
//"The request indicated a Content-Type of "application/x-www-form-urlencoded" for method type "POST" which is not supported"
var content = new ByteArrayContent(new byte[] { });
content.Headers.ContentType = new MediaTypeHeaderValue("application/octet-stream");
content.Headers.ContentLength = 0;

var request = new HttpRequestMessage(HttpMethod.Post, $"{connection.Uri}/_apis/wit/attachments?uploadType=chunked&api-version=3.2") { Content = content };
var response = await httpClient.SendAsync(request);

if (response.IsSuccessStatusCode)
Expand Down Expand Up @@ -223,7 +229,7 @@ public async static Task<IDictionary<int, string>> GetWorkItemIdAndReferenceLink
workItemIdsUris.AddRange(queryResult.WorkItems.Where(w => !workItemIdsUris.ContainsKey(w.Id)).ToDictionary(k => k.Id, v => RemoveProjectGuidFromUrl(v.Url)));

Logger.LogTrace(LogDestination.File, $"Getting work item ids page {page} with last id {id} for {client.BaseAddress.Host} returned {queryResult.WorkItems.Count()} results and total result count is {workItemIdsUris.Count}");

//keeping a list as well because the Dictionary doesnt guarantee ordering
List<int> workItemIdsPage = queryResult.WorkItems.Select(k => k.Id).ToList();
if (!workItemIdsPage.Any())
Expand Down Expand Up @@ -275,7 +281,7 @@ public static string GetPageableQuery(string query, int watermark, int id)
return $"{InjectWhereClause(query, pageableClause)} ORDER BY System.Watermark, System.Id";
}

private static string InjectWhereClause(string query, string clause)
private static string InjectWhereClause(string query, string clause)
{
var lastWhereClauseIndex = query.LastIndexOf(" WHERE ", StringComparison.OrdinalIgnoreCase);
if (lastWhereClauseIndex > 0)
Expand Down