Skip to content

Debt- clean up async ChatModel/IChatEditingSession initialization #247484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roblourens opened this issue Apr 26, 2025 · 0 comments
Open

Debt- clean up async ChatModel/IChatEditingSession initialization #247484

roblourens opened this issue Apr 26, 2025 · 0 comments
Assignees
Labels
chat debt Code quality issues
Milestone

Comments

@roblourens
Copy link
Member

The ChatModel and editing session intialization got complicated after unifying the chat views and loading sessions from disk, async, instead of the storage service, sync.

Since the editing session setup blocks on the ChatModel being ready in the ChatService, the ChatModel creation can't block on the editing session being ready.

Workarounds led to https://github.com/microsoft/vscode-copilot/issues/16038 and https://github.com/microsoft/vscode-copilot/issues/16060, now we have a better workaround, but the whole thing needs to be reworked so that the model and editing session setup are more aligned.

@roblourens roblourens added chat debt Code quality issues labels Apr 26, 2025
@roblourens roblourens added this to the Backlog milestone Apr 26, 2025
@roblourens roblourens self-assigned this Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chat debt Code quality issues
Projects
None yet
Development

No branches or pull requests

1 participant