Skip to content

Commit 69268d9

Browse files
ux: Rephrase the menu names for new Java file command (#800)
1 parent b8e402f commit 69268d9

File tree

6 files changed

+13
-16
lines changed

6 files changed

+13
-16
lines changed

jdtls.ext/com.microsoft.jdtls.ext.target/com.microsoft.jdtls.ext.tp.target

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,8 @@
1414
<unit id="org.eclipse.equinox.sdk.feature.group" version="0.0.0"/>
1515
<unit id="org.eclipse.jdt.source.feature.group" version="0.0.0"/>
1616
<unit id="org.eclipse.sdk.feature.group" version="0.0.0"/>
17-
<repository location="https://download.eclipse.org/eclipse/updates/4.28/R-4.28-202306050440/"/>
18-
</location>
19-
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
2017
<unit id="org.eclipse.xtext.xbase.lib" version="0.0.0"/>
21-
<repository location="https://download.eclipse.org/releases/2023-06/"/>
18+
<repository location="https://download.eclipse.org/releases/2023-12/202311171000/"/>
2219
</location>
2320
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
2421
<unit id="org.eclipse.jdt.ls.core" version="0.0.0"/>

package.nls.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,15 @@
2222
"contributes.commands.java.view.package.copyFilePath": "Copy Path",
2323
"contributes.commands.java.view.package.copyRelativeFilePath": "Copy Relative Path",
2424
"contributes.commands.java.view.package.new": "New...",
25-
"contributes.commands.java.view.package.newJavaClass": "Java Class",
26-
"contributes.commands.java.view.package.newPackage": "Package",
27-
"contributes.commands.java.view.package.newFile": "File",
25+
"contributes.commands.java.view.package.newJavaClass": "Java Class...",
26+
"contributes.commands.java.view.package.newPackage": "Package...",
27+
"contributes.commands.java.view.package.newFile": "File...",
2828
"contributes.commands.java.view.package.newFolder": "Folder",
2929
"contributes.commands.java.view.package.renameFile": "Rename",
3030
"contributes.commands.java.view.package.moveFileToTrash": "Delete",
3131
"contributes.commands.java.view.package.deleteFilePermanently": "Delete Permanently",
3232
"contributes.submenus.javaProject.new": "New",
33-
"contributes.commands.java.view.menus.file.newJavaClass": "New Java Class",
33+
"contributes.commands.java.view.menus.file.newJavaClass": "New Java File",
3434
"configuration.java.dependency.showMembers": "Show the members in the explorer",
3535
"configuration.java.dependency.syncWithFolderExplorer": "Link Java Projects Explorer with the active editor",
3636
"configuration.java.dependency.autoRefresh": "Synchronize Java Projects explorer with changes",

package.nls.zh-cn.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@
2222
"contributes.commands.java.view.package.copyFilePath": "复制路径",
2323
"contributes.commands.java.view.package.copyRelativeFilePath": "复制相对路径",
2424
"contributes.commands.java.view.package.new": "创建...",
25-
"contributes.commands.java.view.package.newJavaClass": "Java 类",
26-
"contributes.commands.java.view.package.newPackage": "",
27-
"contributes.commands.java.view.package.newFile": "文件",
25+
"contributes.commands.java.view.package.newJavaClass": "Java 类...",
26+
"contributes.commands.java.view.package.newPackage": "...",
27+
"contributes.commands.java.view.package.newFile": "文件...",
2828
"contributes.commands.java.view.package.newFolder": "文件夹",
2929
"contributes.commands.java.view.package.renameFile": "重命名",
3030
"contributes.commands.java.view.package.moveFileToTrash": "删除",

package.nls.zh-tw.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@
2020
"contributes.commands.java.view.package.copyFilePath": "複製路徑",
2121
"contributes.commands.java.view.package.copyRelativeFilePath": "複製相對路徑",
2222
"contributes.commands.java.view.package.new": "建立...",
23-
"contributes.commands.java.view.package.newJavaClass": "Java 類別",
24-
"contributes.commands.java.view.package.newPackage": "套件",
25-
"contributes.commands.java.view.package.newFile": "檔案",
23+
"contributes.commands.java.view.package.newJavaClass": "Java 類別...",
24+
"contributes.commands.java.view.package.newPackage": "套件...",
25+
"contributes.commands.java.view.package.newFile": "檔案...",
2626
"contributes.commands.java.view.package.newFolder": "資料夾",
2727
"contributes.commands.java.view.package.renameFile": "重新命名",
2828
"contributes.commands.java.view.package.moveFileToTrash": "刪除",

src/explorerCommands/new.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ export async function newJavaClass(node?: DataNode): Promise<void> {
8282
}
8383

8484
const className: string | undefined = await window.showInputBox({
85-
placeHolder: "Input the class name",
85+
placeHolder: "Enter the Java file name for class/interface/enum/record/@interface",
8686
ignoreFocusOut: true,
8787
validateInput: async (value: string): Promise<string> => {
8888
const checkMessage: string = checkJavaQualifiedName(value);

test/ui/command.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ describe("Command Tests", function() {
121121
assert.ok(quickPick, `Quickpick item "src/main/java" should be found`);
122122
await quickPick!.click();
123123
inputBox = await InputBox.create();
124-
assert.ok(await inputBox.getPlaceHolder() === "Input the class name", `InputBox "Input the class name" should appear`);
124+
assert.ok(await inputBox.getPlaceHolder() === "Enter the Java file name for class/interface/enum/record/@interface", `InputBox "Enter the Java file name" should appear`);
125125
await inputBox.setText("App2");
126126
await inputBox.confirm();
127127
await sleep(1000);

0 commit comments

Comments
 (0)