fix: reg path for system installation (#15)

* fix: reg path for system installation

* fix: /MACHINE flag for arm64

Author: deepak1556

main.gyp

@@ -69,7 +69,7 @@
             ],
           }],
           ['target_arch=="arm64"', {
-            'TargetMachine' : 0,
+            'TargetMachine' : 18,             # /MACHINE:ARM64 https://learn.microsoft.com/en-us/dotnet/api/microsoft.visualstudio.vcprojectengine.machinetypeoption?view=visualstudiosdk-2022
             'defines': [ 
               'DLL_UUID="F5EA5883-1DA8-4A05-864A-D5DE2D2B2854"',
             ],
@@ -100,7 +100,7 @@
             ],
           }],
           ['target_arch=="arm64"', {
-            'TargetMachine' : 0,
+            'TargetMachine' : 18,             # /MACHINE:ARM64
             'defines': [ 
               'DLL_UUID="7D34756D-32DD-4EE6-B99F-2691C0DAD875"',
             ],

src/explorer_command.cc

@@ -91,20 +91,29 @@ class __declspec(uuid(DLL_UUID)) ExplorerCommandHandler final : public RuntimeCl
  public:
   // IExplorerCommand implementation:
   IFACEMETHODIMP GetTitle(IShellItemArray* items, PWSTR* name) {
-    wchar_t value_w[MAX_PATH];
+    const size_t kMaxStringLength = 1024;
+    wchar_t value_w[kMaxStringLength];
+    wchar_t expanded_value_w[kMaxStringLength];
     DWORD value_size_w = sizeof(value_w);
 #if defined(INSIDER)
-    const wchar_t kTitleRegkey[] = L"Software\\Microsoft\\VSCodeInsiders\\ContextMenu";
+    const wchar_t kTitleRegkey[] = L"Software\\Classes\\VSCodeInsidersContextMenu";
 #else
-    const wchar_t kTitleRegkey[] = L"Software\\Microsoft\\VSCode\\ContextMenu";
+    const wchar_t kTitleRegkey[] = L"Software\\Classes\\VSCodeContextMenu";
 #endif
-    LONG result = RegGetValueW(HKEY_LOCAL_MACHINE, kTitleRegkey, L"Title", RRF_RT_REG_EXPAND_SZ | RRF_NOEXPAND,
-                               NULL, reinterpret_cast<LPBYTE>(&value_w), &value_size_w);
-    if (result != ERROR_SUCCESS || value_size_w == 0) {
-      RETURN_IF_FAILED(RegGetValueW(HKEY_CURRENT_USER, kTitleRegkey, L"Title", RRF_RT_REG_EXPAND_SZ | RRF_NOEXPAND,
-                                    NULL, reinterpret_cast<LPBYTE>(&value_w), &value_size_w));
+    HKEY subhkey = nullptr;
+    LONG result = RegOpenKeyEx(HKEY_LOCAL_MACHINE, kTitleRegkey, 0, KEY_READ, &subhkey);
+    if (result != ERROR_SUCCESS) {
+      result = RegOpenKeyEx(HKEY_CURRENT_USER, kTitleRegkey, 0, KEY_READ, &subhkey);
     }
-    return SHStrDup(value_w, name);
+
+    DWORD type = REG_EXPAND_SZ;
+    RegQueryValueEx(subhkey, L"Title", nullptr, &type,
+                    reinterpret_cast<LPBYTE>(&value_w), &value_size_w);
+    RegCloseKey(subhkey);
+    value_size_w = ExpandEnvironmentStrings(value_w, expanded_value_w, kMaxStringLength);
+    return (value_size_w && value_size_w < kMaxStringLength)
+        ? SHStrDup(expanded_value_w, name)
+        : SHStrDup(L"UnExpected Title", name);
   }
 
   IFACEMETHODIMP GetIcon(IShellItemArray* items, PWSTR* icon) {