remove warning logs for ARM (#1251)

michelleangela · web-flow · commit 425bcf822f25 · 2020-05-19T15:53:36.000-07:00
diff --git a/src/cpptools.ts b/src/cpptools.ts
@@ -109,7 +109,7 @@ function parseTargetArch(target: string): Architecture {
   } else if (target.indexOf('arm') >= 0 || is_arm_32(target)) {
     return 'arm';
   }
-  log.warning(localize('unknown.control.gflag.targetArch', 'Unknown target architecture flag: {0}', target));
+  // TODO: whitelist architecture values and add telemetry
   return undefined;
 }
 
@@ -134,7 +134,7 @@ export function parseCompileFlags(cptVersion: cpt.Version, args: string[], lang?
       // tslint:disable-next-line:no-shadowed-variable
       const {done, value} = iter.next();
       if (done) {
-        rollbar.error(localize('unexpected.end.of.arguments', 'Unexpected end of parsing command line arguments'));
+        // TODO: whitelist architecture values and add telemetry
         continue;
       }
       targetArch = parseTargetArch(value.toLowerCase());
@@ -148,7 +148,7 @@ export function parseCompileFlags(cptVersion: cpt.Version, args: string[], lang?
       // tslint:disable-next-line:no-shadowed-variable
       const {done, value} = iter.next();
       if (done) {
-        rollbar.error(localize('unexpected.end.of.arguments', 'Unexpected end of parsing command line arguments'));
+        // TODO: whitelist architecture values and add telemetry
         continue;
       }
       targetArch = parseTargetArch(value.toLowerCase());

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ function parseTargetArch(target: string): Architecture {`
`109`	`109`	`} else if (target.indexOf('arm') >= 0 \|\| is_arm_32(target)) {`
`110`	`110`	`return 'arm';`
`111`	`111`	`}`
`112`		`- log.warning(localize('unknown.control.gflag.targetArch', 'Unknown target architecture flag: {0}', target));`
	`112`	`+ // TODO: whitelist architecture values and add telemetry`
`113`	`113`	`return undefined;`
`114`	`114`	`}`
`115`	`115`
`@@ -134,7 +134,7 @@ export function parseCompileFlags(cptVersion: cpt.Version, args: string[], lang?`
`134`	`134`	`// tslint:disable-next-line:no-shadowed-variable`
`135`	`135`	`const {done, value} = iter.next();`
`136`	`136`	`if (done) {`
`137`		`- rollbar.error(localize('unexpected.end.of.arguments', 'Unexpected end of parsing command line arguments'));`
	`137`	`+ // TODO: whitelist architecture values and add telemetry`
`138`	`138`	`continue;`
`139`	`139`	`}`
`140`	`140`	`targetArch = parseTargetArch(value.toLowerCase());`
`@@ -148,7 +148,7 @@ export function parseCompileFlags(cptVersion: cpt.Version, args: string[], lang?`
`148`	`148`	`// tslint:disable-next-line:no-shadowed-variable`
`149`	`149`	`const {done, value} = iter.next();`
`150`	`150`	`if (done) {`
`151`		`- rollbar.error(localize('unexpected.end.of.arguments', 'Unexpected end of parsing command line arguments'));`
	`151`	`+ // TODO: whitelist architecture values and add telemetry`
`152`	`152`	`continue;`
`153`	`153`	`}`
`154`	`154`	`targetArch = parseTargetArch(value.toLowerCase());`