Fixed top-level binding element declaration emit (#1336)

Author: Andarist

internal/checker/emitresolver.go

@@ -148,7 +148,7 @@ func (r *emitResolver) determineIfDeclarationIsVisible(node *ast.Node) bool {
 		ast.KindImportEqualsDeclaration:
 		if ast.IsVariableDeclaration(node) {
 			if ast.IsBindingPattern(node.Name()) &&
-				len(node.Name().AsBindingPattern().Elements.Nodes) > 0 {
+				len(node.Name().AsBindingPattern().Elements.Nodes) == 0 {
 				// If the binding pattern is empty, this variable declaration is not visible
 				return false
 			}

internal/transformers/declarations/transform.go

@@ -673,9 +673,6 @@ func (tx *DeclarationTransformer) recreateBindingPattern(input *ast.BindingPatte
 }
 
 func (tx *DeclarationTransformer) recreateBindingElement(e *ast.BindingElement) *ast.Node {
-	if e.Kind == ast.KindBindingElement {
-		return nil
-	}
 	if e.Name() == nil {
 		return nil
 	}

testdata/baselines/reference/submodule/compiler/declarationEmitDestructuringArrayPattern1.js

@@ -21,4 +21,9 @@ var [x3, y3, z3] = a; // emit x3, y3, z3
 
 
 //// [declarationEmitDestructuringArrayPattern1.d.ts]
+declare var x: number; // emit x: number
+declare var x1: number, y1: string; // emit x1: number, y1: string
+declare var z1: number; // emit z1: number
 declare var a: (string | number)[];
+declare var x2: string | number; // emit x2: number | string
+declare var x3: string | number, y3: string | number, z3: string | number; // emit x3, y3, z3 

testdata/baselines/reference/submodule/compiler/declarationEmitDestructuringArrayPattern1.js.diff

@@ -7,6 +7,11 @@
 -declare var x: number;
 -declare var x1: number, y1: string;
 -declare var z1: number;
++declare var x: number; // emit x: number
++declare var x1: number, y1: string; // emit x1: number, y1: string
++declare var z1: number; // emit z1: number
  declare var a: (string | number)[];
 -declare var x2: string | number;
--declare var x3: string | number, y3: string | number, z3: string | number;
+-declare var x3: string | number, y3: string | number, z3: string | number;
++declare var x2: string | number; // emit x2: number | string
++declare var x3: string | number, y3: string | number, z3: string | number; // emit x3, y3, z3 

testdata/baselines/reference/submodule/compiler/declarationEmitDestructuringArrayPattern2.js

@@ -22,3 +22,12 @@ var [a3, b3] = [[x13, y13], { x: x13, y: y13 }];
 
 
 //// [declarationEmitDestructuringArrayPattern2.d.ts]
+declare var x10: number, y10: string, z10: boolean;
+declare var x11: number, y11: string;
+declare var a11: undefined, b11: undefined, c11: undefined;
+declare var a2: number, b2: string, x12: number, c2: boolean;
+declare var x13: number, y13: string;
+declare var a3: (string | number)[], b3: {
+    x: number;
+    y: string;
+};

testdata/baselines/reference/submodule/compiler/declarationEmitDestructuringArrayPattern2.js.diff

@@ -14,4 +14,5 @@ var M;
 
 //// [declarationEmitDestructuringArrayPattern3.d.ts]
 declare namespace M {
+    var a: number, b: number;
 }

testdata/baselines/reference/submodule/compiler/declarationEmitDestructuringArrayPattern3.js

@@ -9,8 +9,3 @@
 +    [M.a, M.b] = [1, 2];
  })(M || (M = {}));
 
-
- //// [declarationEmitDestructuringArrayPattern3.d.ts]
- declare namespace M {
--    var a: number, b: number;
- }

testdata/baselines/reference/submodule/compiler/declarationEmitDestructuringArrayPattern3.js.diff

@@ -23,3 +23,11 @@ var [x19, y19, z19, ...a13] = [1, "hello", true];
 
 
 //// [declarationEmitDestructuringArrayPattern4.d.ts]
+declare var a5: number[];
+declare var x14: number, a6: [number, number];
+declare var x15: number, y15: number, a7: [number];
+declare var x16: number, y16: number, z16: number, a8: [];
+declare var a9: (string | number | boolean)[];
+declare var x17: number, a10: [string, boolean];
+declare var x18: number, y18: string, a12: [boolean];
+declare var x19: number, y19: string, z19: boolean, a13: [];