Do not create SourceFiles for non-existent files (#1148)

Author: jakebailey

internal/compiler/host.go

@@ -74,7 +74,10 @@ func (h *compilerHost) Trace(msg string) {
 }
 
 func (h *compilerHost) GetSourceFile(fileName string, path tspath.Path, options *core.SourceFileAffectingCompilerOptions, metadata *ast.SourceFileMetaData) *ast.SourceFile {
-	text, _ := h.FS().ReadFile(fileName)
+	text, ok := h.FS().ReadFile(fileName)
+	if !ok {
+		return nil
+	}
 	if tspath.FileExtensionIs(fileName, tspath.ExtensionJson) {
 		return parser.ParseJSONText(fileName, path, text)
 	}

internal/compiler/program.go

@@ -265,7 +265,8 @@ func (p *Program) initCheckerPool() {
 
 func canReplaceFileInProgram(file1 *ast.SourceFile, file2 *ast.SourceFile) bool {
 	// TODO(jakebailey): metadata??
-	return file1.FileName() == file2.FileName() &&
+	return file2 != nil &&
+		file1.FileName() == file2.FileName() &&
 		file1.Path() == file2.Path() &&
 		file1.LanguageVersion == file2.LanguageVersion &&
 		file1.LanguageVariant == file2.LanguageVariant &&

internal/testutil/harnessutil/harnessutil.go

@@ -497,7 +497,10 @@ func GetSourceFileCacheKey(
 }
 
 func (h *cachedCompilerHost) GetSourceFile(fileName string, path tspath.Path, options *core.SourceFileAffectingCompilerOptions, metadata *ast.SourceFileMetaData) *ast.SourceFile {
-	text, _ := h.FS().ReadFile(fileName)
+	text, ok := h.FS().ReadFile(fileName)
+	if !ok {
+		return nil
+	}
 
 	key := GetSourceFileCacheKey(
 		fileName,

testdata/baselines/reference/submodule/compiler/declarationEmitInvalidReference.js

@@ -4,12 +4,10 @@
 /// <reference path="invalid.ts" />
 var x = 0;
 
-//// [invalid.js]
 //// [declarationEmitInvalidReference.js]
 /// <reference path="invalid.ts" />
 var x = 0;
 
 
-//// [invalid.d.ts]
 //// [declarationEmitInvalidReference.d.ts]
 declare var x: number;

testdata/baselines/reference/submodule/compiler/declarationEmitInvalidReference.js.diff

@@ -4,12 +4,10 @@
 /// <reference path="invalid.ts" />
 var x = 0;
 
-//// [invalid.js]
 //// [declarationEmitInvalidReference2.js]
 /// <reference path="invalid.ts" />
 var x = 0;
 
 
-//// [invalid.d.ts]
 //// [declarationEmitInvalidReference2.d.ts]
 declare var x: number;

testdata/baselines/reference/submodule/compiler/declarationEmitInvalidReference2.js

@@ -25,4 +25,3 @@ export {};
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 /// <reference path="./file1" />
-//// [file1.js]

testdata/baselines/reference/submodule/compiler/declarationEmitInvalidReference2.js.diff

@@ -9,5 +9,4 @@
  "use strict";
 -/// <reference path="./file1" />
  Object.defineProperty(exports, "__esModule", { value: true });
-+/// <reference path="./file1" />
-+//// [file1.js]
++/// <reference path="./file1" />

testdata/baselines/reference/submodule/compiler/duplicateIdentifierRelatedSpans6.js

@@ -37,4 +37,3 @@ export {};
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 /// <reference path="./file1" />
-//// [file1.js]