Skip to content

Commit 4389109

Browse files
authored
Fix shorthand property assignment type resolution (#646)
1 parent af508df commit 4389109

File tree

299 files changed

+576
-2995
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

299 files changed

+576
-2995
lines changed

internal/checker/checker.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15027,7 +15027,7 @@ func (c *Checker) getTypeOfVariableOrParameterOrPropertyWorker(symbol *ast.Symbo
1502715027
case ast.KindPropertyAssignment:
1502815028
result = c.checkPropertyAssignment(declaration, CheckModeNormal)
1502915029
case ast.KindShorthandPropertyAssignment:
15030-
result = c.checkExpressionForMutableLocation(declaration, CheckModeNormal)
15030+
result = c.checkExpressionForMutableLocation(declaration.Name(), CheckModeNormal)
1503115031
case ast.KindMethodDeclaration:
1503215032
result = c.checkObjectLiteralMethod(declaration, CheckModeNormal)
1503315033
case ast.KindExportAssignment:

testdata/baselines/reference/submodule/compiler/abstractPropertyInConstructor.types

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ abstract class C1 {
276276
>({ x, y: y1, "y": y1 } = this) : this
277277
>{ x, y: y1, "y": y1 } = this : this
278278
>{ x, y: y1, "y": y1 } : { x: string; y: string; }
279-
>x : any
279+
>x : string
280280
>y : string
281281
>y1 : string
282282
>"y" : string
@@ -309,7 +309,7 @@ class C2 {
309309
>({ x, y: y1, "y": y1 } = this) : this
310310
>{ x, y: y1, "y": y1 } = this : this
311311
>{ x, y: y1, "y": y1 } : { x: string; y: string; }
312-
>x : any
312+
>x : string
313313
>y : string
314314
>y1 : string
315315
>"y" : string

testdata/baselines/reference/submodule/compiler/abstractPropertyInConstructor.types.diff

Lines changed: 0 additions & 20 deletions
This file was deleted.

testdata/baselines/reference/submodule/compiler/argumentsAsPropertyName2.types

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ function foo() {
3535
({ arguments });
3636
>({ arguments }) : { arguments: IArguments; }
3737
>{ arguments } : { arguments: IArguments; }
38-
>arguments : any
38+
>arguments : IArguments
3939

4040
({ arguments: arguments });
4141
>({ arguments: arguments }) : { arguments: IArguments; }

testdata/baselines/reference/submodule/compiler/argumentsAsPropertyName2.types.diff

Lines changed: 0 additions & 11 deletions
This file was deleted.

testdata/baselines/reference/submodule/compiler/arrayBindingPatternOmittedExpressions.types

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ var results: string[];
1515
>{ a, b } : { a: string; b: string; }
1616

1717
a,
18-
>a : any
18+
>a : string
1919

2020
b
21-
>b : any
21+
>b : string
2222
}
2323
}
2424

testdata/baselines/reference/submodule/compiler/arrayBindingPatternOmittedExpressions.types.diff

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,7 @@
1010
>a : string
1111
>results : string[]
1212

13-
@@= skipped -11, +9 lines =@@
14-
>{ a, b } : { a: string; b: string; }
15-
16-
a,
17-
->a : string
18-
+>a : any
19-
20-
b
21-
->b : string
22-
+>b : any
23-
}
24-
}
13+
@@= skipped -20, +18 lines =@@
2514

2615

2716
function f([, a, , b, , , , s, , , ] = results) {

testdata/baselines/reference/submodule/compiler/arrayFromAsync.types

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -285,6 +285,6 @@ const withIndexResult = await Array.fromAsync(["a", "b"], (str, index) => ({ ind
285285
>index : number
286286
>({ index, str }) : { index: number; str: string; }
287287
>{ index, str } : { index: number; str: string; }
288-
>index : any
289-
>str : any
288+
>index : number
289+
>str : string
290290

testdata/baselines/reference/submodule/compiler/arrayFromAsync.types.diff

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -152,12 +152,3 @@
152152
>["a", "b"] : string[]
153153
>"a" : "a"
154154
>"b" : "b"
155-
@@= skipped -20, +20 lines =@@
156-
>index : number
157-
>({ index, str }) : { index: number; str: string; }
158-
>{ index, str } : { index: number; str: string; }
159-
->index : number
160-
->str : string
161-
+>index : any
162-
+>str : any
163-

testdata/baselines/reference/submodule/compiler/awaitedType.types

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ async function f17_usage() {
415415

416416
return { x };
417417
>{ x } : { x: 123; }
418-
>x : any
418+
>x : 123
419419
}
420420

421421
// https://github.com/microsoft/TypeScript/issues/47144

0 commit comments

Comments
 (0)