Test incremental edit

// Options are always detected as changed so everything is refreshed on incremental build

Author: sheetalkamat

internal/execute/testsys_test.go

@@ -313,3 +313,12 @@ func (s *testSys) WriteFileNoError(path string, content string, writeByteOrderMa
 		panic(err)
 	}
 }
+
+func (s *testSys) ReplaceFileText(path string, oldText string, newText string) {
+	content, ok := s.FS().ReadFile(path)
+	if !ok {
+		panic("File not found: " + path)
+	}
+	content = strings.Replace(content, oldText, newText, 1)
+	s.WriteFileNoError(path, content, false)
+}

internal/execute/tscincremental_test.go

@@ -71,19 +71,23 @@ func TestIncremental(t *testing.T) {
                     type InstanceType<T extends abstract new (...args: any) => any> = T extends abstract new (...args: any) => infer R ? R : any;`,
 			}, "/home/src/workspaces/project"),
 			commandLineArgs: []string{"--incremental"},
-			// edits: [
-			//     noChangeRun,
-			//     {
-			//         caption: "modify public to protected",
-			//         edit: sys => sys.replaceFileText("/home/src/workspaces/project/MessageablePerson.ts", "public", "protected"),
-			//     },
-			//     noChangeRun,
-			//     {
-			//         caption: "modify protected to public",
-			//         edit: sys => sys.replaceFileText("/home/src/workspaces/project/MessageablePerson.ts", "protected", "public"),
-			//     },
-			//     noChangeRun,
-			// ],
+			edits: []*testTscEdit{
+				noChange,
+				{
+					caption: "modify public to protected",
+					edit: func(sys *testSys) {
+						sys.ReplaceFileText("/home/src/workspaces/project/MessageablePerson.ts", "public", "protected")
+					},
+				},
+				noChange,
+				{
+					caption: "modify protected to public",
+					edit: func(sys *testSys) {
+						sys.ReplaceFileText("/home/src/workspaces/project/MessageablePerson.ts", "protected", "public")
+					},
+				},
+				noChange,
+			},
 		},
 		{
 			subScenario: "change to modifier of class expression field",
@@ -108,19 +112,23 @@ func TestIncremental(t *testing.T) {
                     type InstanceType<T extends abstract new (...args: any) => any> = T extends abstract new (...args: any) => infer R ? R : any;`,
 			}, "/home/src/workspaces/project"),
 			commandLineArgs: []string{"--incremental"},
-			// edits: [
-			//     noChangeRun,
-			//     {
-			//         caption: "modify public to protected",
-			//         edit: sys => sys.replaceFileText("/home/src/workspaces/project/MessageablePerson.ts", "public", "protected"),
-			//     },
-			//     noChangeRun,
-			//     {
-			//         caption: "modify protected to public",
-			//         edit: sys => sys.replaceFileText("/home/src/workspaces/project/MessageablePerson.ts", "protected", "public"),
-			//     },
-			//     noChangeRun,
-			// ],
+			edits: []*testTscEdit{
+				noChange,
+				{
+					caption: "modify public to protected",
+					edit: func(sys *testSys) {
+						sys.ReplaceFileText("/home/src/workspaces/project/MessageablePerson.ts", "public", "protected")
+					},
+				},
+				noChange,
+				{
+					caption: "modify protected to public",
+					edit: func(sys *testSys) {
+						sys.ReplaceFileText("/home/src/workspaces/project/MessageablePerson.ts", "protected", "public")
+					},
+				},
+				noChange,
+			},
 		},
 	}
 

internal/execute/tsctestrunner_test.go

@@ -8,6 +8,7 @@ import (
 	"strings"
 	"testing"
 
+	"github.com/microsoft/typescript-go/internal/core"
 	"github.com/microsoft/typescript-go/internal/execute"
 	"github.com/microsoft/typescript-go/internal/incremental"
 	"github.com/microsoft/typescript-go/internal/testutil/baseline"
@@ -19,6 +20,11 @@ type testTscEdit struct {
 	edit            func(*testSys)
 }
 
+var noChange = &testTscEdit{
+	caption: "no change",
+	edit:    func(sys *testSys) {},
+}
+
 type tscInput struct {
 	subScenario     string
 	commandLineArgs []string
@@ -50,7 +56,7 @@ func (test *tscInput) run(t *testing.T, scenario string) {
 
 				var incrementalProgram *incremental.Program
 				if watcher == nil {
-					exit, parsedCommandLine, incrementalProgram, watcher = execute.CommandLine(test.sys, test.commandLineArgs, true)
+					exit, parsedCommandLine, incrementalProgram, watcher = execute.CommandLine(test.sys, core.IfElse(do.commandLineArgs == nil, test.commandLineArgs, do.commandLineArgs), true)
 					baselineBuilder.WriteString("ExitStatus:: " + fmt.Sprint(exit))
 				} else {
 					watcher.DoCycle()