feat: moving nil check to call sites of IsFunctionLikeDeclaration

Author: SoulPancake

internal/ast/utilities.go

@@ -494,9 +494,9 @@ func isFunctionLikeDeclarationKind(kind Kind) bool {
 }
 
 // Determines if a node is function-like (but is not a signature declaration)
+// ensure node != nil before calling this
 func IsFunctionLikeDeclaration(node *Node) bool {
-	// TODO(rbuckton): Move `node != nil` test to call sites
-	return node != nil && isFunctionLikeDeclarationKind(node.Kind)
+	return isFunctionLikeDeclarationKind(node.Kind)
 }
 
 func isFunctionLikeKind(kind Kind) bool {
@@ -2369,12 +2369,12 @@ func GetImpliedNodeFormatForEmitWorker(sourceFile *SourceFile, options *core.Com
 	}
 	if sourceFile.ImpliedNodeFormat == core.ModuleKindCommonJS &&
 		( /*sourceFile.packageJsonScope.contents.packageJsonContent.type == "commonjs" ||*/ // !!!
-		tspath.FileExtensionIsOneOf(sourceFile.FileName(), []string{tspath.ExtensionCjs, tspath.ExtensionCts})) {
+			tspath.FileExtensionIsOneOf(sourceFile.FileName(), []string{tspath.ExtensionCjs, tspath.ExtensionCts})) {
 		return core.ModuleKindCommonJS
 	}
 	if sourceFile.ImpliedNodeFormat == core.ModuleKindESNext &&
 		( /*sourceFile.packageJsonScope?.contents.packageJsonContent.type === "module" ||*/ // !!!
-		tspath.FileExtensionIsOneOf(sourceFile.fileName, []string{tspath.ExtensionMjs, tspath.ExtensionMts})) {
+			tspath.FileExtensionIsOneOf(sourceFile.fileName, []string{tspath.ExtensionMjs, tspath.ExtensionMts})) {
 		return core.ModuleKindESNext
 	}
 	return core.ModuleKindNone

internal/checker/checker.go

@@ -7365,7 +7365,7 @@ func (c *Checker) checkSuperExpression(node *ast.Node) *Type {
 
 func (c *Checker) isInConstructorArgumentInitializer(node *ast.Node, constructorDecl *ast.Node) bool {
 	return ast.FindAncestorOrQuit(node, func(n *ast.Node) ast.FindAncestorResult {
-		if ast.IsFunctionLikeDeclaration(n) {
+		if n != nil && ast.IsFunctionLikeDeclaration(n) {
 			return ast.FindAncestorQuit
 		}
 		if ast.IsParameter(n) && n.Parent == constructorDecl {
@@ -11128,7 +11128,7 @@ func (c *Checker) isNodeUsedDuringClassInitialization(node *ast.Node) bool {
 	return ast.FindAncestorOrQuit(node, func(element *ast.Node) ast.FindAncestorResult {
 		if ast.IsConstructorDeclaration(element) && ast.NodeIsPresent(element.Body()) || ast.IsPropertyDeclaration(element) {
 			return ast.FindAncestorTrue
-		} else if ast.IsClassLike(element) || ast.IsFunctionLikeDeclaration(element) {
+		} else if ast.IsClassLike(element) || (element != nil && ast.IsFunctionLikeDeclaration(element)) {
 			return ast.FindAncestorQuit
 		}
 		return ast.FindAncestorFalse
@@ -18582,7 +18582,7 @@ func (c *Checker) createGeneratorType(yieldType *Type, returnType *Type, nextTyp
 
 func (c *Checker) reportErrorsFromWidening(declaration *ast.Node, t *Type, wideningKind WideningKind) {
 	if c.noImplicitAny && t.objectFlags&ObjectFlagsContainsWideningType != 0 {
-		if wideningKind == WideningKindNormal || ast.IsFunctionLikeDeclaration(declaration) && c.shouldReportErrorsFromWideningWithContextualSignature(declaration, wideningKind) {
+		if wideningKind == WideningKindNormal || declaration != nil && ast.IsFunctionLikeDeclaration(declaration) && c.shouldReportErrorsFromWideningWithContextualSignature(declaration, wideningKind) {
 			// Report implicit any error within type if possible, otherwise report error on declaration
 			if !c.reportWideningErrorsInType(t) {
 				c.reportImplicitAny(declaration, t, wideningKind)

internal/checker/grammarchecks.go

@@ -294,7 +294,7 @@ func (c *Checker) checkGrammarModifiers(node *ast.Node /*Union[HasModifiers, Has
 				parent := node.Parent
 
 				if node.Kind == ast.KindTypeParameter {
-					if !(ast.IsFunctionLikeDeclaration(parent) || ast.IsClassLike(parent) ||
+					if !((parent != nil && ast.IsFunctionLikeDeclaration(parent)) || ast.IsClassLike(parent) ||
 						ast.IsFunctionTypeNode(parent) || ast.IsConstructorTypeNode(parent) ||
 						ast.IsCallSignatureDeclaration(parent) || ast.IsConstructSignatureDeclaration(parent) ||
 						ast.IsMethodSignatureDeclaration(parent)) {