Skip to content

Commit 3c40349

Browse files
committed
PR feedback, apply fix suggested by @rbuckton
1 parent 1749474 commit 3c40349

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

tsdoc/src/parser/NodeParser.ts

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -339,8 +339,8 @@ export class NodeParser {
339339
* an input like `@param {string} [x="]"] - the X value`. It detects nested balanced pairs of delimiters
340340
* and escaped string literals.
341341
*/
342-
private _tryParseJSDocTypeOrValueRest(tokenReader: TokenReader, openKind: TokenKind, closeKind: TokenKind): TokenSequence | undefined {
343-
const startMarker: number = tokenReader.createMarker();
342+
private _tryParseJSDocTypeOrValueRest(tokenReader: TokenReader, openKind: TokenKind, closeKind: TokenKind,
343+
startMarker: number): TokenSequence | undefined {
344344

345345
let quoteKind: TokenKind | undefined;
346346
let openCount: number = 1;
@@ -398,9 +398,13 @@ export class NodeParser {
398398
tokenReader.peekTokenAfterKind() === TokenKind.AtSign) {
399399
return undefined;
400400
}
401+
402+
const startMarker: number = tokenReader.createMarker();
401403
tokenReader.readToken(); // read the "{"
402404

403-
let jsdocTypeExcerpt: TokenSequence | undefined = this._tryParseJSDocTypeOrValueRest(tokenReader, TokenKind.LeftCurlyBracket, TokenKind.RightCurlyBracket);
405+
let jsdocTypeExcerpt: TokenSequence | undefined = this._tryParseJSDocTypeOrValueRest(tokenReader,
406+
TokenKind.LeftCurlyBracket, TokenKind.RightCurlyBracket, startMarker);
407+
404408
if (jsdocTypeExcerpt) {
405409
this._parserContext.log.addMessageForTokenSequence(
406410
TSDocMessageId.ParamTagWithInvalidType,
@@ -427,7 +431,9 @@ export class NodeParser {
427431
private _tryParseJSDocOptionalNameRest(tokenReader: TokenReader): TokenSequence | undefined {
428432
tokenReader.assertAccumulatedSequenceIsEmpty();
429433
if (tokenReader.peekTokenKind() !== TokenKind.EndOfInput) {
430-
return this._tryParseJSDocTypeOrValueRest(tokenReader, TokenKind.LeftSquareBracket, TokenKind.RightSquareBracket);
434+
const startMarker: number = tokenReader.createMarker();
435+
return this._tryParseJSDocTypeOrValueRest(tokenReader,
436+
TokenKind.LeftSquareBracket, TokenKind.RightSquareBracket, startMarker);
431437
}
432438
return undefined;
433439
}

0 commit comments

Comments
 (0)