remove redundant Empty constructor and mark as warning (#5378)

Co-authored-by: Jakub Jareš <me@jakubjares.com>

Author: SimonCropp

.editorconfig

@@ -683,6 +683,9 @@ csharp_style_unused_value_expression_statement_preference = discard_variable:sil
 # IDE0290: Use primary constructor
 csharp_style_prefer_primary_constructors = false
 
+# Empty constructor
+resharper_empty_constructor_highlighting = warning
+
 # Redundant empty argument list on object creation expression
 resharper_redundant_empty_object_creation_argument_list_highlighting = warning
 

samples/Playground/Program.cs

@@ -76,7 +76,7 @@ public static async Task<int> Main(string[] args)
     }
 }
 
-internal sealed class DummyAdapter() : ITestFramework, IDataProducer
+internal sealed class DummyAdapter : ITestFramework, IDataProducer
 {
     public string Uid => nameof(DummyAdapter);
 

src/Platform/Microsoft.Testing.Extensions.HangDump/Serializers/ExitSignalActivityIndicatorTaskRequest.cs

@@ -6,7 +6,7 @@
 
 namespace Microsoft.Testing.Extensions.HangDump.Serializers;
 
-internal sealed class ExitSignalActivityIndicatorTaskRequest() : IRequest;
+internal sealed class ExitSignalActivityIndicatorTaskRequest : IRequest;
 
 internal sealed class ExitSignalActivityIndicatorTaskRequestSerializer : BaseSerializer, INamedPipeSerializer
 {

src/Platform/Microsoft.Testing.Extensions.HangDump/Serializers/GetInProgressTestsRequest.cs

@@ -6,7 +6,7 @@
 
 namespace Microsoft.Testing.Extensions.HangDump.Serializers;
 
-internal sealed class GetInProgressTestsRequest() : IRequest;
+internal sealed class GetInProgressTestsRequest : IRequest;
 
 internal sealed class GetInProgressTestsRequestSerializer : BaseSerializer, INamedPipeSerializer
 {

src/Platform/Microsoft.Testing.Extensions.HangDump/Serializers/SessionEndSerializer.cs

@@ -6,7 +6,7 @@
 
 namespace Microsoft.Testing.Extensions.HangDump.Serializers;
 
-internal sealed class SessionEndSerializerRequest() : IRequest;
+internal sealed class SessionEndSerializerRequest : IRequest;
 
 internal sealed class SessionEndSerializerRequestSerializer : BaseSerializer, INamedPipeSerializer
 {

src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/RpcMessages.cs

@@ -6,7 +6,7 @@
 
 namespace Microsoft.Testing.Platform.ServerMode;
 
-internal abstract record RpcMessage();
+internal abstract record RpcMessage;
 
 /// <summary>
 /// A request is a message for which the server should return a corresponding