Correcting display of Vector dimension in data type label, adding test (#2483)

* Correcting display of Vector dimension in data type label, adding test

* fixing linter error

Author: Benjin

src/Microsoft.SqlTools.SqlCore/ObjectExplorer/SmoModel/SmoColumnCustomNode.cs

@@ -156,7 +156,7 @@ private static string GetCustomizedLabel(Column column, UserDefinedDataTypeColle
             return string.Empty;
         }
 
-        private static string GetTypeSpecifierLabel(DataType dataType, UserDefinedDataTypeCollection uddts)
+        internal static string GetTypeSpecifierLabel(DataType dataType, UserDefinedDataTypeCollection uddts)
         {
             string typeName = string.Empty;
             if (dataType != null)
@@ -195,7 +195,6 @@ private static string GetTypeSpecifierLabel(DataType dataType, UserDefinedDataTy
                     case SqlDataType.VarChar:
                     case SqlDataType.NVarChar:
                     case SqlDataType.VarBinary:
-                    case SqlDataType.Vector:
                         typeName += $"({dataType.MaximumLength})";
                         break;
                     case SqlDataType.Numeric:
@@ -212,6 +211,14 @@ private static string GetTypeSpecifierLabel(DataType dataType, UserDefinedDataTy
                     case SqlDataType.VarCharMax:
                         typeName += "(max)";
                         break;
+                    case SqlDataType.Vector:
+                        // Temporary workaround to convert the maxLength to dimensions for vector types
+                        // until SMO is updated to store the actual dimensions of the vector type.
+                        // https://msdata.visualstudio.com/SQLToolsAndLibraries/_workitems/edit/3906463
+                        // dimensions = (length - 8) / 4
+                        // https://learn.microsoft.com/sql/t-sql/data-types/vector-data-type
+                        typeName += $"({(dataType.MaximumLength - 8) / 4})";
+                        break;
                 }
             }
             return typeName;

test/Microsoft.SqlTools.ServiceLayer.UnitTests/ObjectExplorer/SmoColumnCustomNodeHelperTests.cs

@@ -0,0 +1,62 @@
+//
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+//
+
+using Microsoft.SqlServer.Management.Smo;
+using Microsoft.SqlTools.SqlCore.ObjectExplorer.SmoModel;
+using NUnit.Framework;
+
+namespace Microsoft.SqlTools.ServiceLayer.UnitTests.ObjectExplorer
+{
+    public class SmoColumnCustomNodeHelperTests
+    {
+        [Test]
+        public void ShouldCalculateTypeLabels()
+        {
+            var cases = new[]
+            {
+                // Numbers
+                new { Type = DataType.Int, Label = "int" },
+                new { Type = DataType.BigInt, Label = "bigint" },
+                new { Type = DataType.SmallInt, Label = "smallint" },
+                new { Type = DataType.TinyInt, Label = "tinyint" },
+                new { Type = DataType.Bit, Label = "bit" },
+                new { Type = DataType.Decimal(10, 2), Label = "decimal(2,10)" }, // precision then scale is standard, opposite order from the constructor
+                new { Type = DataType.Float, Label = "float" },
+                new { Type = DataType.Real, Label = "real" },
+                new { Type = DataType.Money, Label = "money" },
+                new { Type = DataType.SmallMoney, Label = "smallmoney" },
+
+                // Binary types
+                new { Type = DataType.Binary(10), Label = "binary(10)" },
+                new { Type = DataType.VarBinary(10), Label = "varbinary(10)" },
+                new { Type = DataType.VarBinaryMax, Label = "varbinary(max)" },
+
+                // String types
+                new { Type = DataType.Char(10), Label = "char(10)" },
+                new { Type = DataType.NChar(10), Label = "nchar(10)" },
+                new { Type = DataType.NVarChar(10), Label = "nvarchar(10)" },
+                new { Type = DataType.NVarCharMax, Label = "nvarchar(max)" },
+                new { Type = DataType.VarChar(20), Label = "varchar(20)" },
+                new { Type = DataType.VarCharMax, Label = "varchar(max)" },
+
+                // Date Types
+                new { Type = DataType.DateTime, Label = "datetime" },
+                new { Type = DataType.Date, Label = "date" },
+                new { Type = DataType.DateTime2(7), Label = "datetime2(7)" },
+                new { Type = DataType.DateTimeOffset(5), Label = "datetimeoffset(5)" },
+                new { Type = DataType.Time(3), Label = "time(3)" },
+
+                // Specialty types
+                new { Type = DataType.Vector(17), Label = "vector(17)" },
+            };
+
+            foreach (var testCase in cases)
+            {
+                string label = SmoColumnCustomNodeHelper.GetTypeSpecifierLabel(testCase.Type, uddts: null);
+                Assert.That(label, Is.EqualTo(testCase.Label), $"Expected label to be {testCase.Label}");
+            }
+        }
+    }
+}