From 9b753e02ddf8e6feb219527a27126d60f3c62c14 Mon Sep 17 00:00:00 2001 From: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com> Date: Thu, 19 Jun 2025 13:20:51 +0000 Subject: [PATCH 1/2] Removing default maxtokens to be optional --- .../GeminiPromptExecutionSettingsTests.cs | 2 +- .../Connectors.Google/GeminiPromptExecutionSettings.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dotnet/src/Connectors/Connectors.Google.UnitTests/GeminiPromptExecutionSettingsTests.cs b/dotnet/src/Connectors/Connectors.Google.UnitTests/GeminiPromptExecutionSettingsTests.cs index 5ba6895da18b..f368ac054f88 100644 --- a/dotnet/src/Connectors/Connectors.Google.UnitTests/GeminiPromptExecutionSettingsTests.cs +++ b/dotnet/src/Connectors/Connectors.Google.UnitTests/GeminiPromptExecutionSettingsTests.cs @@ -29,7 +29,7 @@ public void ItCreatesGeminiExecutionSettingsWithCorrectDefaults() Assert.Null(executionSettings.AudioTimestamp); Assert.Null(executionSettings.ResponseMimeType); Assert.Null(executionSettings.ResponseSchema); - Assert.Equal(GeminiPromptExecutionSettings.DefaultTextMaxTokens, executionSettings.MaxTokens); + Assert.Null(executionSettings.MaxTokens); } [Fact] diff --git a/dotnet/src/Connectors/Connectors.Google/GeminiPromptExecutionSettings.cs b/dotnet/src/Connectors/Connectors.Google/GeminiPromptExecutionSettings.cs index c4d4514feb5f..e82f3c326c53 100644 --- a/dotnet/src/Connectors/Connectors.Google/GeminiPromptExecutionSettings.cs +++ b/dotnet/src/Connectors/Connectors.Google/GeminiPromptExecutionSettings.cs @@ -358,7 +358,7 @@ public static GeminiPromptExecutionSettings FromExecutionSettings(PromptExecutio switch (executionSettings) { case null: - return new GeminiPromptExecutionSettings() { MaxTokens = DefaultTextMaxTokens }; + return new GeminiPromptExecutionSettings(); case GeminiPromptExecutionSettings settings: return settings; } From 59e782d805ac45c3b7396bf865c7d723d2f2e0fb Mon Sep 17 00:00:00 2001 From: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com> Date: Thu, 19 Jun 2025 15:56:10 +0100 Subject: [PATCH 2/2] Remove unused constant as well --- .../Connectors.Google/GeminiPromptExecutionSettings.cs | 5 ----- 1 file changed, 5 deletions(-) diff --git a/dotnet/src/Connectors/Connectors.Google/GeminiPromptExecutionSettings.cs b/dotnet/src/Connectors/Connectors.Google/GeminiPromptExecutionSettings.cs index e82f3c326c53..82f21bdd99f9 100644 --- a/dotnet/src/Connectors/Connectors.Google/GeminiPromptExecutionSettings.cs +++ b/dotnet/src/Connectors/Connectors.Google/GeminiPromptExecutionSettings.cs @@ -33,11 +33,6 @@ public sealed class GeminiPromptExecutionSettings : PromptExecutionSettings private GeminiToolCallBehavior? _toolCallBehavior; private GeminiThinkingConfig? _thinkingConfig; - /// - /// Default max tokens for a text generation. - /// - public static int DefaultTextMaxTokens { get; } = 256; - /// /// Temperature controls the randomness of the completion. /// The higher the temperature, the more random the completion.