From 537163e6e3224d67222f1151ea83b5d3e2ffd0ae Mon Sep 17 00:00:00 2001 From: Tomasz Jaworski Date: Wed, 6 Nov 2024 17:28:37 +0000 Subject: [PATCH 1/2] fix: incremental building with LegacySkipPlugin when no-op operations are present --- libraries/rush-lib/src/logic/operations/LegacySkipPlugin.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libraries/rush-lib/src/logic/operations/LegacySkipPlugin.ts b/libraries/rush-lib/src/logic/operations/LegacySkipPlugin.ts index 651ec7849f8..0e3a02fadbe 100644 --- a/libraries/rush-lib/src/logic/operations/LegacySkipPlugin.ts +++ b/libraries/rush-lib/src/logic/operations/LegacySkipPlugin.ts @@ -79,7 +79,7 @@ export class LegacySkipPlugin implements IPhasedCommandPlugin { const { operation } = record; const { associatedProject, runner, logFilenameIdentifier } = operation; if (!associatedProject || !runner) { - return; + continue; } if (!runner.cacheable) { @@ -88,7 +88,7 @@ export class LegacySkipPlugin implements IPhasedCommandPlugin { packageDeps: undefined, packageDepsPath: '' }); - return; + continue; } const packageDepsFilename: string = `package-deps_${logFilenameIdentifier}.json`; @@ -109,7 +109,7 @@ export class LegacySkipPlugin implements IPhasedCommandPlugin { if (!fileHashes) { logGitWarning = true; - return; + continue; } const files: Record = {}; From 3900bd85d4ded26dff4ca13def2db8fa75b79c2a Mon Sep 17 00:00:00 2001 From: Tomasz Jaworski Date: Wed, 6 Nov 2024 17:29:54 +0000 Subject: [PATCH 2/2] chore: rush change --- ...x-legacy-incremental-building_2024-11-06-17-29.json | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 common/changes/@microsoft/rush/fix-legacy-incremental-building_2024-11-06-17-29.json diff --git a/common/changes/@microsoft/rush/fix-legacy-incremental-building_2024-11-06-17-29.json b/common/changes/@microsoft/rush/fix-legacy-incremental-building_2024-11-06-17-29.json new file mode 100644 index 00000000000..4b1c475d3c5 --- /dev/null +++ b/common/changes/@microsoft/rush/fix-legacy-incremental-building_2024-11-06-17-29.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@microsoft/rush", + "comment": "Fix an issue where incremental building (with LegacySkipPlugin) would not work when no-op operations were present in the process", + "type": "none" + } + ], + "packageName": "@microsoft/rush" +} \ No newline at end of file