Skip to content

Commit bd0ac5c

Browse files
authored
Add required PR Check action (#249)
Our PR jobs now call into templates and use a matrix strategy for all tested configurations. GitHub Actions branch protections do not let you set "all jobs are required" nor even "all matrix permutations of this one job" are required. You literally have to set every individual permutation as required manually, which makes it hard to maintain. This PR adds a final "Successful PR Check" job that is dependent on all the others, that can be the *one* set to required.
1 parent 531347d commit bd0ac5c

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

.github/workflows/pr.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,3 +84,10 @@ jobs:
8484
vmImage: windows-2022
8585
configuration: ${{ matrix.configuration }}
8686
platform: ${{ matrix.platform }}
87+
88+
prcheck:
89+
name: Successful PR Check
90+
runs-on: ubuntu-latest
91+
needs: [setupcheck, call-runcodegen, call-testcli, call-testcli-old, call-buildnpmpackage, call-buildrnx]
92+
steps:
93+
- uses: actions/checkout@v3

0 commit comments

Comments
 (0)