Skip to content

Commit 8f15fc0

Browse files
committed
Fix specification of Windows SDK versions
1 parent 2a3344c commit 8f15fc0

File tree

7 files changed

+9
-10
lines changed

7 files changed

+9
-10
lines changed

example/windows/example.sln

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "Mso", "..\..\node_modules\r
3333
EndProject
3434
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "Include", "..\..\node_modules\react-native-windows\include\Include.vcxitems", "{EF074BA1-2D54-4D49-A28E-5E040B47CD2E}"
3535
EndProject
36-
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "ReactNativeXaml", "..\..\package\windows\ReactNativeXaml\ReactNativeXaml.vcxproj", "{0FF7027A-222C-4FFB-8F17-91D18BBAF7A8}"
36+
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "ReactNativeXaml", "..\..\node_modules\react-native-xaml\windows\ReactNativeXaml\ReactNativeXaml.vcxproj", "{0FF7027A-222C-4FFB-8F17-91D18BBAF7A8}"
3737
EndProject
3838
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Codegen", "..\..\package\Codegen\Codegen.csproj", "{5B4C219B-2178-4226-B5C1-DFAD6919790A}"
3939
EndProject

example/windows/example/AutolinkedNativeModules.g.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<!-- AutolinkedNativeModules.g.targets contents generated by "react-native autolink-windows" -->
44
<ItemGroup>
55
<!-- Projects from react-native-xaml -->
6-
<ProjectReference Include="$(ProjectDir)..\..\..\package\windows\ReactNativeXaml\ReactNativeXaml.vcxproj">
6+
<ProjectReference Include="$(ProjectDir)..\..\..\node_modules\react-native-xaml\windows\ReactNativeXaml\ReactNativeXaml.vcxproj">
77
<Project>{0ff7027a-222c-4ffb-8f17-91d18bbaf7a8}</Project>
88
</ProjectReference>
99
</ItemGroup>

example/windows/example/example.vcxproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
<AppContainerApplication>true</AppContainerApplication>
1515
<ApplicationType>Windows Store</ApplicationType>
1616
<ApplicationTypeRevision>10.0</ApplicationTypeRevision>
17-
<WindowsTargetPlatformVersion Condition=" '$(WindowsTargetPlatformVersion)' == '' ">10.0.18362.0</WindowsTargetPlatformVersion>
18-
<WindowsTargetPlatformMinVersion>10.0.16299.0</WindowsTargetPlatformMinVersion>
1917
<PackageCertificateKeyFile>example_TemporaryKey.pfx</PackageCertificateKeyFile>
2018
<PackageCertificateThumbprint>1186AA7FAEBFC52FD1266A30874E87DAF3561449</PackageCertificateThumbprint>
2119
<PackageCertificatePassword>password</PackageCertificatePassword>

examplenuget/windows/examplenuget.sln

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ VisualStudioVersion = 17.3.32929.385
55
MinimumVisualStudioVersion = 10.0.40219.1
66
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "examplenuget", "examplenuget\examplenuget.vcxproj", "{0E5E86FE-DB24-4DB3-96CF-5F97DA8558F1}"
77
EndProject
8-
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "ReactNativeXaml", "..\..\package\windows\ReactNativeXaml\ReactNativeXaml.vcxproj", "{0FF7027A-222C-4FFB-8F17-91D18BBAF7A8}"
8+
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "ReactNativeXaml", "..\..\node_modules\react-native-xaml\windows\ReactNativeXaml\ReactNativeXaml.vcxproj", "{0FF7027A-222C-4FFB-8F17-91D18BBAF7A8}"
99
EndProject
1010
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Codegen", "..\..\package\Codegen\Codegen.csproj", "{A9EBFB79-DB42-4839-B369-EFA601A98706}"
1111
EndProject

examplenuget/windows/examplenuget/AutolinkedNativeModules.g.targets

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33
<!-- AutolinkedNativeModules.g.targets contents generated by "react-native autolink-windows" -->
44
<ItemGroup>
5-
<!-- Projects from react-native-xaml -->
6-
<ProjectReference Include="$(ProjectDir)..\..\..\package\windows\ReactNativeXaml\ReactNativeXaml.vcxproj">
5+
<!-- Projects from react-native-xaml -->
6+
<ProjectReference Include="$(ProjectDir)..\..\..\node_modules\react-native-xaml\windows\ReactNativeXaml\ReactNativeXaml.vcxproj">
77
<Project>{0ff7027a-222c-4ffb-8f17-91d18bbaf7a8}</Project>
88
</ProjectReference>
99
</ItemGroup>

examplenuget/windows/examplenuget/examplenuget.vcxproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
<AppContainerApplication>true</AppContainerApplication>
1515
<ApplicationType>Windows Store</ApplicationType>
1616
<ApplicationTypeRevision>10.0</ApplicationTypeRevision>
17-
<WindowsTargetPlatformVersion Condition=" '$(WindowsTargetPlatformVersion)' == '' ">10.0.18362.0</WindowsTargetPlatformVersion>
18-
<WindowsTargetPlatformMinVersion>10.0.16299.0</WindowsTargetPlatformMinVersion>
1917
<PackageCertificateKeyFile>examplenuget_TemporaryKey.pfx</PackageCertificateKeyFile>
2018
<PackageCertificatePassword>password</PackageCertificatePassword>
2119
<ReactNativeWindowsAllowNugetNpmMismatch>true</ReactNativeWindowsAllowNugetNpmMismatch>

package/windows/ReactNativeXaml/ReactNativeXaml.vcxproj

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,11 @@
2727
<AppContainerApplication>true</AppContainerApplication>
2828
<ApplicationType>Windows Store</ApplicationType>
2929
<ApplicationTypeRevision>10.0</ApplicationTypeRevision>
30+
</PropertyGroup>
31+
<Import Project="$(ReactNativeWindowsDir)\PropertySheets\External\Microsoft.ReactNative.WindowsSdk.Default.props" Condition="Exists('$(ReactNativeWindowsDir)\PropertySheets\External\Microsoft.ReactNative.WindowsSdk.Default.props')" />
32+
<PropertyGroup Label="Fallback Windows SDK Versions">
3033
<WindowsTargetPlatformVersion Condition=" '$(WindowsTargetPlatformVersion)' == '' ">10.0.18362.0</WindowsTargetPlatformVersion>
31-
<WindowsTargetPlatformMinVersion>10.0.16299.0</WindowsTargetPlatformMinVersion>
34+
<WindowsTargetPlatformMinVersion Condition=" '$(WindowsTargetPlatformMinVersion)' == '' ">10.0.16299.0</WindowsTargetPlatformMinVersion>
3235
</PropertyGroup>
3336
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
3437
<ItemGroup Label="ProjectConfigurations">

0 commit comments

Comments
 (0)