From b24fa3b257411786299c36239880a3791c5324d4 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Mon, 10 Jun 2024 16:54:01 +0200 Subject: [PATCH 01/41] test --- t | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 t diff --git a/t b/t new file mode 100644 index 000000000..e69de29bb From 57cb3b82f928d9e38f9e2de1c9e8daef17f53c49 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Mon, 10 Jun 2024 16:57:41 +0200 Subject: [PATCH 02/41] change gradle-action config --- .github/workflows/react-native-code-push-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 9fdf01fc9..c5f9d97f0 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -18,7 +18,7 @@ jobs: - name: Start adb server run: adb devices - name: Gradle cache - uses: gradle/gradle-build-action@v2 + uses: gradle/actions/setup-gradle@v3 - name: Download system image "android-${{ matrix.api-level }}" run: $ANDROID_HOME/tools/bin/sdkmanager "system-images;android-${{ matrix.api-level }};google_apis;x86" - name: Create android emulator From fb7b47317758c4f073aa967f41b39f877131c470 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Mon, 17 Jun 2024 15:32:48 +0200 Subject: [PATCH 03/41] Bump api version --- .github/workflows/react-native-code-push-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index c5f9d97f0..80ce004c2 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -11,7 +11,7 @@ jobs: runs-on: macos-latest strategy: matrix: - api-level: [ 27 ] + api-level: [ 34 ] steps: - name: Checkout uses: actions/checkout@v3 From 82bcbbea50bd17d1610c4959742f96192c3f322a Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Mon, 17 Jun 2024 15:58:56 +0200 Subject: [PATCH 04/41] Change java version to 8 --- .github/workflows/react-native-code-push-ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 80ce004c2..83e413ae7 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -11,7 +11,8 @@ jobs: runs-on: macos-latest strategy: matrix: - api-level: [ 34 ] + api-level: [ 27 ] + java-version: [8] steps: - name: Checkout uses: actions/checkout@v3 From 4492590cba50c6e35dcd1015bfa61a7029774fdc Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Mon, 17 Jun 2024 16:03:37 +0200 Subject: [PATCH 05/41] setup java first --- .github/workflows/react-native-code-push-ci.yml | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 83e413ae7..43d1b2499 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -12,10 +12,14 @@ jobs: strategy: matrix: api-level: [ 27 ] - java-version: [8] steps: - name: Checkout uses: actions/checkout@v3 + - name: Setup Java + uses: actions/setup-java@v3 + with: + distribution: 'microsoft' + java-version: '11' - name: Start adb server run: adb devices - name: Gradle cache @@ -31,11 +35,6 @@ jobs: - run: adb shell settings put global window_animation_scale 0.0 - run: adb shell settings put global transition_animation_scale 0.0 - run: adb shell settings put global animator_duration_scale 0.0 - - name: Setup Java - uses: actions/setup-java@v3 - with: - distribution: 'microsoft' - java-version: '11' - name: Setup Ruby uses: ruby/setup-ruby@v1 with: From c6658ee052c273ac79fe4883e6330b955091794d Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Mon, 17 Jun 2024 16:04:55 +0200 Subject: [PATCH 06/41] setup java first --- .github/workflows/react-native-code-push-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 43d1b2499..8f97ceac8 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -19,7 +19,7 @@ jobs: uses: actions/setup-java@v3 with: distribution: 'microsoft' - java-version: '11' + java-version: '8' - name: Start adb server run: adb devices - name: Gradle cache From 213617a74b1defecf192a3ef9c94cde245fc4815 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Mon, 17 Jun 2024 16:18:45 +0200 Subject: [PATCH 07/41] use java 8 --- .github/workflows/react-native-code-push-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 8f97ceac8..00ebd6c30 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -18,7 +18,7 @@ jobs: - name: Setup Java uses: actions/setup-java@v3 with: - distribution: 'microsoft' + distribution: 'oracle' java-version: '8' - name: Start adb server run: adb devices From 3797c5765a6df782fb0b67b4cec662e0415c0f35 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Mon, 17 Jun 2024 16:22:18 +0200 Subject: [PATCH 08/41] bump --- .github/workflows/react-native-code-push-ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 00ebd6c30..6aa49c689 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -11,15 +11,15 @@ jobs: runs-on: macos-latest strategy: matrix: - api-level: [ 27 ] + api-level: [ 34 ] steps: - name: Checkout uses: actions/checkout@v3 - name: Setup Java uses: actions/setup-java@v3 with: - distribution: 'oracle' - java-version: '8' + distribution: 'microsoft' + java-version: '17.0.10' - name: Start adb server run: adb devices - name: Gradle cache From 0cc265fcdaf5863d4a36cc1f8956f552c59a7807 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Mon, 17 Jun 2024 23:38:00 +0200 Subject: [PATCH 09/41] test java version --- .github/workflows/react-native-code-push-ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 6aa49c689..e8f6e05dc 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -18,8 +18,8 @@ jobs: - name: Setup Java uses: actions/setup-java@v3 with: - distribution: 'microsoft' - java-version: '17.0.10' + distribution: 'temurin' + java-version: '8' - name: Start adb server run: adb devices - name: Gradle cache From 1e6ce08f3f2fbbc63b4dd53cc9227efa5a22e310 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Mon, 17 Jun 2024 23:41:37 +0200 Subject: [PATCH 10/41] test --- .github/workflows/react-native-code-push-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index e8f6e05dc..1787aec74 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -18,7 +18,7 @@ jobs: - name: Setup Java uses: actions/setup-java@v3 with: - distribution: 'temurin' + distribution: 'adopt' java-version: '8' - name: Start adb server run: adb devices From 28c9ec1a5aad79d8e2181e016d618931f5d06d43 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Mon, 17 Jun 2024 23:52:29 +0200 Subject: [PATCH 11/41] Use java 11 --- .github/workflows/react-native-code-push-ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 1787aec74..dec185477 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -18,14 +18,14 @@ jobs: - name: Setup Java uses: actions/setup-java@v3 with: - distribution: 'adopt' - java-version: '8' + distribution: 'microsoft' + java-version: '11.0.19' - name: Start adb server run: adb devices - name: Gradle cache uses: gradle/actions/setup-gradle@v3 - name: Download system image "android-${{ matrix.api-level }}" - run: $ANDROID_HOME/tools/bin/sdkmanager "system-images;android-${{ matrix.api-level }};google_apis;x86" + run: "system-images;android-${{ matrix.api-level }};google_apis;x86" - name: Create android emulator run: $ANDROID_HOME/tools/bin/avdmanager create avd --force --name TestEmulator --abi google_apis/x86 --package 'system-images;android-${{ matrix.api-level }};google_apis;x86' --device "Nexus 6P" - name: Start android emulator From 1cd0dda0b69b3549090c0d15da0da4896c0be233 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Mon, 17 Jun 2024 23:53:38 +0200 Subject: [PATCH 12/41] revert api-level --- .github/workflows/react-native-code-push-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index dec185477..94ca14bcb 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -11,7 +11,7 @@ jobs: runs-on: macos-latest strategy: matrix: - api-level: [ 34 ] + api-level: [ 27 ] steps: - name: Checkout uses: actions/checkout@v3 From 0aa12feba1c3446fd93436cff0504598ae408d00 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Mon, 17 Jun 2024 23:55:16 +0200 Subject: [PATCH 13/41] revert run command --- .github/workflows/react-native-code-push-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 94ca14bcb..3af756fad 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -25,7 +25,7 @@ jobs: - name: Gradle cache uses: gradle/actions/setup-gradle@v3 - name: Download system image "android-${{ matrix.api-level }}" - run: "system-images;android-${{ matrix.api-level }};google_apis;x86" + run: $ANDROID_HOME/tools/bin/sdkmanager "system-images;android-${{ matrix.api-level }};google_apis;x86" - name: Create android emulator run: $ANDROID_HOME/tools/bin/avdmanager create avd --force --name TestEmulator --abi google_apis/x86 --package 'system-images;android-${{ matrix.api-level }};google_apis;x86' --device "Nexus 6P" - name: Start android emulator From 66342698506c96b2abd0a0ff816796c2408d3a04 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Tue, 18 Jun 2024 00:16:02 +0200 Subject: [PATCH 14/41] user java 8 coreto --- .github/workflows/react-native-code-push-ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 3af756fad..353689f9b 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -18,8 +18,8 @@ jobs: - name: Setup Java uses: actions/setup-java@v3 with: - distribution: 'microsoft' - java-version: '11.0.19' + distribution: 'corretto' + java-version: '8.0.412' - name: Start adb server run: adb devices - name: Gradle cache From f8cf8a076eb2c112137ad6c9d99d36a227b4769f Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Tue, 18 Jun 2024 00:17:26 +0200 Subject: [PATCH 15/41] fix java version of coretto --- .github/workflows/react-native-code-push-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 353689f9b..f40fef75a 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -19,7 +19,7 @@ jobs: uses: actions/setup-java@v3 with: distribution: 'corretto' - java-version: '8.0.412' + java-version: '8' - name: Start adb server run: adb devices - name: Gradle cache From 27f633a91e885868103b53da3fc3b526c3382c60 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Tue, 18 Jun 2024 00:23:34 +0200 Subject: [PATCH 16/41] Use java 8 temurin --- .github/workflows/react-native-code-push-ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index f40fef75a..cc6f0c314 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -18,8 +18,8 @@ jobs: - name: Setup Java uses: actions/setup-java@v3 with: - distribution: 'corretto' - java-version: '8' + distribution: 'temurin' + java-version: '8.0.412+8' - name: Start adb server run: adb devices - name: Gradle cache From ad2db73c24389c1d48c40f0d96306f27a8f25ec7 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Tue, 18 Jun 2024 00:27:19 +0200 Subject: [PATCH 17/41] Use zulu java distribution --- .github/workflows/react-native-code-push-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index cc6f0c314..72f6ad055 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -18,7 +18,7 @@ jobs: - name: Setup Java uses: actions/setup-java@v3 with: - distribution: 'temurin' + distribution: 'zulu' java-version: '8.0.412+8' - name: Start adb server run: adb devices From 62d93865ec65ffafbf45ece71bf411dd146c0673 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Tue, 18 Jun 2024 00:28:32 +0200 Subject: [PATCH 18/41] User java 8 zulu version --- .github/workflows/react-native-code-push-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 72f6ad055..08db4a1e0 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -19,7 +19,7 @@ jobs: uses: actions/setup-java@v3 with: distribution: 'zulu' - java-version: '8.0.412+8' + java-version: '8' - name: Start adb server run: adb devices - name: Gradle cache From eec40cc82955c691a98b629bf2eef8fcc1702ba1 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Tue, 18 Jun 2024 00:44:15 +0200 Subject: [PATCH 19/41] use macos-13 runner --- .github/workflows/react-native-code-push-ci.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 08db4a1e0..92bcc32b6 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -8,18 +8,13 @@ on: jobs: test-android: name: Test Android app - runs-on: macos-latest + runs-on: macos-13 strategy: matrix: api-level: [ 27 ] steps: - name: Checkout uses: actions/checkout@v3 - - name: Setup Java - uses: actions/setup-java@v3 - with: - distribution: 'zulu' - java-version: '8' - name: Start adb server run: adb devices - name: Gradle cache @@ -35,6 +30,11 @@ jobs: - run: adb shell settings put global window_animation_scale 0.0 - run: adb shell settings put global transition_animation_scale 0.0 - run: adb shell settings put global animator_duration_scale 0.0 + - name: Setup Java + uses: actions/setup-java@v3 + with: + distribution: 'zulu' + java-version: '8' - name: Setup Ruby uses: ruby/setup-ruby@v1 with: From 04fc2fcd366719a5551a17f748d51a947f8dc79d Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Tue, 18 Jun 2024 00:47:05 +0200 Subject: [PATCH 20/41] user java 8 on runner --- .github/workflows/react-native-code-push-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 92bcc32b6..2ad0e10f4 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -12,6 +12,7 @@ jobs: strategy: matrix: api-level: [ 27 ] + java-version: [8] steps: - name: Checkout uses: actions/checkout@v3 From 2fdd53a1776ee708e67702190bd639642b4b6bf7 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Tue, 18 Jun 2024 00:51:14 +0200 Subject: [PATCH 21/41] Add java env variable --- .github/workflows/react-native-code-push-ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 2ad0e10f4..1d15cf0c1 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -9,10 +9,11 @@ jobs: test-android: name: Test Android app runs-on: macos-13 + env: + JAVA_HOME: $(JAVA_HOME_8_X64) strategy: matrix: api-level: [ 27 ] - java-version: [8] steps: - name: Checkout uses: actions/checkout@v3 From 312a9f291f710d3ff7fa9fd8cb86b55848b830c9 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Tue, 18 Jun 2024 00:53:45 +0200 Subject: [PATCH 22/41] Add path to java 8 --- .github/workflows/react-native-code-push-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 1d15cf0c1..c77c5a8e4 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -11,6 +11,7 @@ jobs: runs-on: macos-13 env: JAVA_HOME: $(JAVA_HOME_8_X64) + PATH: $(JAVA_HOME_8_X64)/bin:$(PATH) strategy: matrix: api-level: [ 27 ] From a0639fa01668782f877780ed7c3a1e125ebddf83 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Tue, 18 Jun 2024 00:55:56 +0200 Subject: [PATCH 23/41] Update env --- .github/workflows/react-native-code-push-ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index c77c5a8e4..d1cf1c28c 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -10,8 +10,7 @@ jobs: name: Test Android app runs-on: macos-13 env: - JAVA_HOME: $(JAVA_HOME_8_X64) - PATH: $(JAVA_HOME_8_X64)/bin:$(PATH) + JAVA_HOME: JAVA_HOME_8_X64 strategy: matrix: api-level: [ 27 ] From 1bdc101eef853bef4558e1c21d29c80162d78e4d Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Tue, 18 Jun 2024 01:00:54 +0200 Subject: [PATCH 24/41] Set env variable --- .github/workflows/react-native-code-push-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index d1cf1c28c..496386a4d 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -10,7 +10,7 @@ jobs: name: Test Android app runs-on: macos-13 env: - JAVA_HOME: JAVA_HOME_8_X64 + JAVA_HOME: $JAVA_HOME_8_X64 strategy: matrix: api-level: [ 27 ] From a8864d7895abe1e00e7253dcc0662127e612de4e Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Tue, 18 Jun 2024 10:55:22 +0200 Subject: [PATCH 25/41] Check java version --- .github/workflows/react-native-code-push-ci.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 496386a4d..f6e41a287 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -11,10 +11,13 @@ jobs: runs-on: macos-13 env: JAVA_HOME: $JAVA_HOME_8_X64 + PATH: $(JAVA_HOME_8_X64)/bin:$(PATH) strategy: matrix: api-level: [ 27 ] steps: + - name: Check java version + uses: java --version - name: Checkout uses: actions/checkout@v3 - name: Start adb server From 25f50be16834a28dd803e80b4345e7c45442e42c Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Tue, 18 Jun 2024 10:57:23 +0200 Subject: [PATCH 26/41] Fix typo --- .github/workflows/react-native-code-push-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index f6e41a287..80a705505 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -17,7 +17,7 @@ jobs: api-level: [ 27 ] steps: - name: Check java version - uses: java --version + run: java --version - name: Checkout uses: actions/checkout@v3 - name: Start adb server From 274d2bcf2f8794618bccdabac3e0198d5963b21b Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Tue, 18 Jun 2024 11:42:19 +0200 Subject: [PATCH 27/41] Revert java env changes --- .github/workflows/react-native-code-push-ci.yml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 80a705505..92bcc32b6 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -9,15 +9,10 @@ jobs: test-android: name: Test Android app runs-on: macos-13 - env: - JAVA_HOME: $JAVA_HOME_8_X64 - PATH: $(JAVA_HOME_8_X64)/bin:$(PATH) strategy: matrix: api-level: [ 27 ] steps: - - name: Check java version - run: java --version - name: Checkout uses: actions/checkout@v3 - name: Start adb server From 294b5f0e85fdc271dba3cc6a20ce4e7f9f6ff142 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Tue, 18 Jun 2024 13:19:03 +0200 Subject: [PATCH 28/41] Add java step with java 8 version --- .github/workflows/react-native-code-push-ci.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 92bcc32b6..65055d78a 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -12,9 +12,14 @@ jobs: strategy: matrix: api-level: [ 27 ] + java-version: [ 8 ] steps: - name: Checkout uses: actions/checkout@v3 + - name: Setup Java + uses: actions/setup-java@v3 + with: + java-version: ${{ matrix.java-version }} - name: Start adb server run: adb devices - name: Gradle cache @@ -30,11 +35,6 @@ jobs: - run: adb shell settings put global window_animation_scale 0.0 - run: adb shell settings put global transition_animation_scale 0.0 - run: adb shell settings put global animator_duration_scale 0.0 - - name: Setup Java - uses: actions/setup-java@v3 - with: - distribution: 'zulu' - java-version: '8' - name: Setup Ruby uses: ruby/setup-ruby@v1 with: From ba0acf4fe4a1fef071732eac6a7567df7970d4c6 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Tue, 18 Jun 2024 13:23:29 +0200 Subject: [PATCH 29/41] Add distribution for java step --- .github/workflows/react-native-code-push-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 65055d78a..ebc21ebaf 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -19,6 +19,7 @@ jobs: - name: Setup Java uses: actions/setup-java@v3 with: + distribution: zulu java-version: ${{ matrix.java-version }} - name: Start adb server run: adb devices From c89d947f311454888aa9b65d588211f3c2d69efe Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Tue, 18 Jun 2024 13:39:35 +0200 Subject: [PATCH 30/41] Use 2 types of java versions --- .github/workflows/react-native-code-push-ci.yml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index ebc21ebaf..a4c469cde 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -12,15 +12,14 @@ jobs: strategy: matrix: api-level: [ 27 ] - java-version: [ 8 ] steps: - name: Checkout uses: actions/checkout@v3 - - name: Setup Java + - name: Setup Java for sdkmanager uses: actions/setup-java@v3 with: distribution: zulu - java-version: ${{ matrix.java-version }} + java-version: '8' - name: Start adb server run: adb devices - name: Gradle cache @@ -36,6 +35,11 @@ jobs: - run: adb shell settings put global window_animation_scale 0.0 - run: adb shell settings put global transition_animation_scale 0.0 - run: adb shell settings put global animator_duration_scale 0.0 + - name: Setup Java for Android build + uses: actions/setup-java@v3 + with: + distribution: microsoft + java-version: '11' - name: Setup Ruby uses: ruby/setup-ruby@v1 with: From 82cedeaf161aef6e3b6fe1b4b2928d111bae9809 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Wed, 19 Jun 2024 09:34:24 +0200 Subject: [PATCH 31/41] Add automatic cocoapods usage --- react-native.config.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/react-native.config.js b/react-native.config.js index 29f627a4d..52ca04c02 100644 --- a/react-native.config.js +++ b/react-native.config.js @@ -1,4 +1,9 @@ module.exports = { + project:{ + ios:{ + automaticPodsInstallation:true + } + }, dependency: { platforms: { android: { From 11477f4429e12221f45be243510eeb7fd4a07672 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Wed, 19 Jun 2024 17:42:09 +0200 Subject: [PATCH 32/41] Enable corepack --- .github/workflows/react-native-code-push-ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index a4c469cde..66a38c161 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -60,6 +60,8 @@ jobs: steps: - name: Checkout uses: actions/checkout@v2 + - name: Enable Corepack + run: corepack enable - name: Setup Ruby uses: ruby/setup-ruby@v1 with: From 87874968d87efdc55f180ce14ed1f8bae9da37fd Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Wed, 19 Jun 2024 18:03:56 +0200 Subject: [PATCH 33/41] Use macos-13 runner for IOS --- .github/workflows/react-native-code-push-ci.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 66a38c161..ddce669c7 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -54,14 +54,12 @@ jobs: test-iOS: name: Test iOS app - runs-on: macos-latest + runs-on: macos-13 env: NO_FLIPPER: ${{ secrets.NO_FLIPPER }} steps: - name: Checkout uses: actions/checkout@v2 - - name: Enable Corepack - run: corepack enable - name: Setup Ruby uses: ruby/setup-ruby@v1 with: From e4d774e300b018342ed34a89df281343f4923575 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Wed, 19 Jun 2024 21:13:30 +0200 Subject: [PATCH 34/41] Add step for installing cocoapods --- .github/workflows/react-native-code-push-ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index ddce669c7..19848ee9c 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -65,6 +65,8 @@ jobs: with: ruby-version: '2.7.6' bundler-cache: true + - name: (Workaround) Install Cocoapods + run: gem install cocoapods - name: (Workaround) Install activesupport 7.0.8 run: gem install activesupport -v 7.0.8 - name: Install dependencies From 25f11ef9fad2685e40eee10d50e05b8eacb1a725 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Thu, 20 Jun 2024 11:42:11 +0200 Subject: [PATCH 35/41] Try out macos-12 image --- .github/workflows/react-native-code-push-ci.yml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 19848ee9c..7d2dc4d04 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -8,18 +8,13 @@ on: jobs: test-android: name: Test Android app - runs-on: macos-13 + runs-on: macOS-12 strategy: matrix: api-level: [ 27 ] steps: - name: Checkout uses: actions/checkout@v3 - - name: Setup Java for sdkmanager - uses: actions/setup-java@v3 - with: - distribution: zulu - java-version: '8' - name: Start adb server run: adb devices - name: Gradle cache @@ -65,8 +60,6 @@ jobs: with: ruby-version: '2.7.6' bundler-cache: true - - name: (Workaround) Install Cocoapods - run: gem install cocoapods - name: (Workaround) Install activesupport 7.0.8 run: gem install activesupport -v 7.0.8 - name: Install dependencies From 4354e7bcdfdb80149cb72688904f95398146c8a2 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Thu, 20 Jun 2024 11:56:58 +0200 Subject: [PATCH 36/41] Check manual install cocoapods --- test/test.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/test.ts b/test/test.ts index daf7ecc31..fbe89dc07 100644 --- a/test/test.ts +++ b/test/test.ts @@ -308,7 +308,8 @@ class RNProjectManager extends ProjectManager { mkdirp.sync(projectDirectory); return TestUtil.getProcessOutput("npx react-native init " + appName + " --version 0.71.3 --install-pods", { cwd: projectDirectory, timeout: 30 * 60 * 1000 }) - .then((e) => { console.log(`"npx react-native init ${appName}" success. cwd=${projectDirectory}`); return e; }) + .then(()=>{TestUtil.getProcessOutput("gem install cocoapods", { cwd: projectDirectory, timeout: 30 * 60 * 1000 })}) + .then((e) => { console.log(`"npx react-native init ${appName}" success. cwd=${projectDirectory}`); return e; }) .then(this.copyTemplate.bind(this, templatePath, projectDirectory)) .then(TestUtil.getProcessOutput.bind(undefined, TestConfig.thisPluginInstallString, { cwd: path.join(projectDirectory, TestConfig.TestAppName) })) .then(() => { return null; }) From 684880af3e8e9454b1b32e6fcf76776c5f25487b Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Thu, 20 Jun 2024 12:01:31 +0200 Subject: [PATCH 37/41] Test cocoapods manual install --- test/test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test.ts b/test/test.ts index fbe89dc07..13789d8f8 100644 --- a/test/test.ts +++ b/test/test.ts @@ -307,9 +307,9 @@ class RNProjectManager extends ProjectManager { } mkdirp.sync(projectDirectory); - return TestUtil.getProcessOutput("npx react-native init " + appName + " --version 0.71.3 --install-pods", { cwd: projectDirectory, timeout: 30 * 60 * 1000 }) - .then(()=>{TestUtil.getProcessOutput("gem install cocoapods", { cwd: projectDirectory, timeout: 30 * 60 * 1000 })}) + return TestUtil.getProcessOutput("npx react-native init " + appName + " --version 0.71.3 --install-pods", { cwd: projectDirectory, timeout: 30 * 60 * 1000 }) .then((e) => { console.log(`"npx react-native init ${appName}" success. cwd=${projectDirectory}`); return e; }) + .then(()=>{TestUtil.getProcessOutput("gem install cocoapods", { cwd: projectDirectory, timeout: 30 * 60 * 1000 })}) .then(this.copyTemplate.bind(this, templatePath, projectDirectory)) .then(TestUtil.getProcessOutput.bind(undefined, TestConfig.thisPluginInstallString, { cwd: path.join(projectDirectory, TestConfig.TestAppName) })) .then(() => { return null; }) From c3b4a7cad51f36074ae206b84e73ef0442675fc1 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Thu, 20 Jun 2024 14:25:50 +0200 Subject: [PATCH 38/41] Revert test.ts changes and use macos-12 for ios --- .github/workflows/react-native-code-push-ci.yml | 2 +- test/test.ts | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 7d2dc4d04..34c4bcee7 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -49,7 +49,7 @@ jobs: test-iOS: name: Test iOS app - runs-on: macos-13 + runs-on: macOS-12 env: NO_FLIPPER: ${{ secrets.NO_FLIPPER }} steps: diff --git a/test/test.ts b/test/test.ts index 13789d8f8..e56b2a75a 100644 --- a/test/test.ts +++ b/test/test.ts @@ -309,7 +309,6 @@ class RNProjectManager extends ProjectManager { return TestUtil.getProcessOutput("npx react-native init " + appName + " --version 0.71.3 --install-pods", { cwd: projectDirectory, timeout: 30 * 60 * 1000 }) .then((e) => { console.log(`"npx react-native init ${appName}" success. cwd=${projectDirectory}`); return e; }) - .then(()=>{TestUtil.getProcessOutput("gem install cocoapods", { cwd: projectDirectory, timeout: 30 * 60 * 1000 })}) .then(this.copyTemplate.bind(this, templatePath, projectDirectory)) .then(TestUtil.getProcessOutput.bind(undefined, TestConfig.thisPluginInstallString, { cwd: path.join(projectDirectory, TestConfig.TestAppName) })) .then(() => { return null; }) From 13825c7859acdb10dfbf436a24fdc5937ad13764 Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Fri, 21 Jun 2024 00:46:43 +0200 Subject: [PATCH 39/41] check single failing test android --- .github/workflows/react-native-code-push-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 34c4bcee7..67225e718 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -45,7 +45,7 @@ jobs: - name: Setup Android tests run: npm run build:tests && npm run test:setup:android - name: Run Android test - run: npm run test:fast:android + run: mocha --recursive bin/test -g "window.codePush.sync.2x.checkerror" --android test-iOS: name: Test iOS app From 14a80a36fcc14dd27f1078482da0438b90208b4e Mon Sep 17 00:00:00 2001 From: Djordje Dimitrijev Date: Fri, 21 Jun 2024 01:21:32 +0200 Subject: [PATCH 40/41] Update pckg json test file --- .github/workflows/react-native-code-push-ci.yml | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 67225e718..68f061cd3 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -45,7 +45,7 @@ jobs: - name: Setup Android tests run: npm run build:tests && npm run test:setup:android - name: Run Android test - run: mocha --recursive bin/test -g "window.codePush.sync.2x.checkerror" --android + run: npm run test:fast:android test-iOS: name: Test iOS app diff --git a/package.json b/package.json index a8a97ac74..ae9f80990 100644 --- a/package.json +++ b/package.json @@ -24,7 +24,7 @@ "test:setup:android": "mocha --recursive bin/test --android --setup", "test:setup:ios": "mocha --recursive bin/test --ios --setup", "test:fast": "mocha --recursive bin/test --android --ios", - "test:fast:android": "mocha --recursive bin/test --android", + "test:fast:android": "mocha --recursive bin/test --android -g 'window.codePush.sync.2x.checkerror' ", "test:fast:ios": "mocha --recursive bin/test --ios", "test:debugger:android": "mocha --recursive --inspect-brk=0.0.0.0 bin/test --android", "test:debugger:ios": "mocha --recursive --inspect-brk=0.0.0.0 bin/test --ios", From 99d55c4616b5abcbce2260b10aa08248842a377f Mon Sep 17 00:00:00 2001 From: Dmitriy Kirakosyan Date: Fri, 21 Jun 2024 12:54:17 +0700 Subject: [PATCH 41/41] set timeout --- .github/workflows/react-native-code-push-ci.yml | 3 ++- package.json | 2 +- test/test.ts | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/react-native-code-push-ci.yml b/.github/workflows/react-native-code-push-ci.yml index 68f061cd3..c1d0ea4c7 100644 --- a/.github/workflows/react-native-code-push-ci.yml +++ b/.github/workflows/react-native-code-push-ci.yml @@ -9,6 +9,7 @@ jobs: test-android: name: Test Android app runs-on: macOS-12 + timeout-minutes: 90 strategy: matrix: api-level: [ 27 ] @@ -20,7 +21,7 @@ jobs: - name: Gradle cache uses: gradle/actions/setup-gradle@v3 - name: Download system image "android-${{ matrix.api-level }}" - run: $ANDROID_HOME/tools/bin/sdkmanager "system-images;android-${{ matrix.api-level }};google_apis;x86" + run: $ANDROID_HOME/tools/bin/sdkmanager "system-images;android-${{ matrix.api-level }};google_apis;x86" - name: Create android emulator run: $ANDROID_HOME/tools/bin/avdmanager create avd --force --name TestEmulator --abi google_apis/x86 --package 'system-images;android-${{ matrix.api-level }};google_apis;x86' --device "Nexus 6P" - name: Start android emulator diff --git a/package.json b/package.json index ae9f80990..a8a97ac74 100644 --- a/package.json +++ b/package.json @@ -24,7 +24,7 @@ "test:setup:android": "mocha --recursive bin/test --android --setup", "test:setup:ios": "mocha --recursive bin/test --ios --setup", "test:fast": "mocha --recursive bin/test --android --ios", - "test:fast:android": "mocha --recursive bin/test --android -g 'window.codePush.sync.2x.checkerror' ", + "test:fast:android": "mocha --recursive bin/test --android", "test:fast:ios": "mocha --recursive bin/test --ios", "test:debugger:android": "mocha --recursive --inspect-brk=0.0.0.0 bin/test --android", "test:debugger:ios": "mocha --recursive --inspect-brk=0.0.0.0 bin/test --ios", diff --git a/test/test.ts b/test/test.ts index e56b2a75a..daf7ecc31 100644 --- a/test/test.ts +++ b/test/test.ts @@ -307,8 +307,8 @@ class RNProjectManager extends ProjectManager { } mkdirp.sync(projectDirectory); - return TestUtil.getProcessOutput("npx react-native init " + appName + " --version 0.71.3 --install-pods", { cwd: projectDirectory, timeout: 30 * 60 * 1000 }) - .then((e) => { console.log(`"npx react-native init ${appName}" success. cwd=${projectDirectory}`); return e; }) + return TestUtil.getProcessOutput("npx react-native init " + appName + " --version 0.71.3 --install-pods", { cwd: projectDirectory, timeout: 30 * 60 * 1000 }) + .then((e) => { console.log(`"npx react-native init ${appName}" success. cwd=${projectDirectory}`); return e; }) .then(this.copyTemplate.bind(this, templatePath, projectDirectory)) .then(TestUtil.getProcessOutput.bind(undefined, TestConfig.thisPluginInstallString, { cwd: path.join(projectDirectory, TestConfig.TestAppName) })) .then(() => { return null; })