Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Commit eee43ec

Browse files
committed
Fix bundle location
1 parent 841ff90 commit eee43ec

File tree

4 files changed

+13
-5
lines changed

4 files changed

+13
-5
lines changed

ios/CodePush/CodePush.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ failCallback:(void (^)(NSError *err))failCallback;
7070
@interface CodePushPackage : NSObject
7171

7272
+ (void)downloadPackage:(NSDictionary *)updatePackage
73+
expectedBundleFileName:(NSString *)expectedBundleFileName
7374
progressCallback:(void (^)(long long, long long))progressCallback
7475
doneCallback:(void (^)())doneCallback
7576
failCallback:(void (^)(NSError *err))failCallback;
@@ -113,6 +114,7 @@ failCallback:(void (^)(NSError *err))failCallback;
113114
error:(NSError **)error;
114115

115116
+ (NSString *)findMainBundleInFolder:(NSString *)folderPath
117+
expectedFileName:(NSString *)expectedFileName
116118
error:(NSError **)error;
117119

118120
+ (NSString *)assetsFolderName;

ios/CodePush/CodePush.m

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -419,7 +419,9 @@ - (void)applicationWillResignActive
419419
forKey:BinaryBundleDateKey];
420420
}
421421

422-
[CodePushPackage downloadPackage:mutableUpdatePackage
422+
[CodePushPackage
423+
downloadPackage:mutableUpdatePackage
424+
expectedBundleFileName:[bundleResourceName stringByAppendingPathExtension:bundleResourceExtension]
423425
// The download is progressing forward
424426
progressCallback:^(long long expectedContentLength, long long receivedContentLength) {
425427
dispatch_async(_methodQueue, ^{

ios/CodePush/CodePushPackage.m

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,7 @@ + (BOOL)isCodePushError:(NSError *)err
205205
}
206206

207207
+ (void)downloadPackage:(NSDictionary *)updatePackage
208+
expectedBundleFileName:(NSString *)expectedBundleFileName
208209
progressCallback:(void (^)(long long, long long))progressCallback
209210
doneCallback:(void (^)())doneCallback
210211
failCallback:(void (^)(NSError *err))failCallback
@@ -360,7 +361,9 @@ + (void)downloadPackage:(NSDictionary *)updatePackage
360361
}
361362

362363
NSString *relativeBundlePath = [CodePushUpdateUtils findMainBundleInFolder:newUpdateFolderPath
364+
expectedFileName:expectedBundleFileName
363365
error:&error];
366+
364367
if (error) {
365368
failCallback(error);
366369
return;

ios/CodePush/CodePushUpdateUtils.m

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ + (void)copyEntriesInFolder:(NSString *)sourceFolder
118118
}
119119

120120
+ (NSString *)findMainBundleInFolder:(NSString *)folderPath
121+
expectedFileName:(NSString *)expectedFileName
121122
error:(NSError **)error
122123
{
123124
NSArray* folderFiles = [[NSFileManager defaultManager]
@@ -132,17 +133,17 @@ + (NSString *)findMainBundleInFolder:(NSString *)folderPath
132133
BOOL isDir = NO;
133134
if ([[NSFileManager defaultManager] fileExistsAtPath:fullFilePath
134135
isDirectory:&isDir] && isDir) {
135-
NSString *mainBundlePathInFolder = [self findMainBundleInFolder:fullFilePath error:error];
136+
NSString *mainBundlePathInFolder = [self findMainBundleInFolder:fullFilePath
137+
expectedFileName:expectedFileName
138+
error:error];
136139
if (*error) {
137140
return nil;
138141
}
139142

140143
if (mainBundlePathInFolder) {
141144
return [fileName stringByAppendingPathComponent:mainBundlePathInFolder];
142145
}
143-
} else if ([[fileName pathExtension] isEqualToString:@"bundle"] ||
144-
[[fileName pathExtension] isEqualToString:@"jsbundle"] ||
145-
[[fileName pathExtension] isEqualToString:@"js"]) {
146+
} else if ([fileName isEqualToString:expectedFileName]) {
146147
return fileName;
147148
}
148149
}

0 commit comments

Comments
 (0)