Merge pull request #397 from convoyinc/nevir/status-report-bugfix

lostintangent · web-flow · commit d82c7f1c4b47 · 2016-06-23T14:06:37.000-07:00
Bug fix for #379 where status report can be undefined on notifyApplicationReady
diff --git a/CodePush.js b/CodePush.js
@@ -173,7 +173,7 @@ const notifyApplicationReady = (() => {
 async function notifyApplicationReadyInternal() {
   await NativeCodePush.notifyApplicationReady();
   const statusReport = await NativeCodePush.getNewStatusReport();
-  tryReportStatus(statusReport); // Don't wait for this to complete.
+  statusReport && tryReportStatus(statusReport); // Don't wait for this to complete.
 
   return statusReport;
 }
diff --git a/typings/react-native-code-push.d.ts b/typings/react-native-code-push.d.ts
@@ -243,7 +243,7 @@ declare namespace CodePush {
     /**
      * Notifies the CodePush runtime that an installed update is considered successful.
      */
-    function notifyAppReady(): Promise<StatusReport>;
+    function notifyAppReady(): Promise<StatusReport|void>;
 
     /**
      * Allow CodePush to restart the app.

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ const notifyApplicationReady = (() => {`
`173`	`173`	`async function notifyApplicationReadyInternal() {`
`174`	`174`	`await NativeCodePush.notifyApplicationReady();`
`175`	`175`	`const statusReport = await NativeCodePush.getNewStatusReport();`
`176`		`- tryReportStatus(statusReport); // Don't wait for this to complete.`
	`176`	`+ statusReport && tryReportStatus(statusReport); // Don't wait for this to complete.`
`177`	`177`
`178`	`178`	`return statusReport;`
`179`	`179`	`}`