Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Commit d1ae918

Browse files
committed
CR feedback
1 parent 9f0b3e6 commit d1ae918

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ After installing the plugin and syncing your Android Studio project with Gradle,
269269
}
270270
```
271271

272-
2. Ensure that the `android.defaultConfig.versionName` property in your `android/app/build.gradle` file is set to a semver compliant value. Note that if the value provided is missing a patch version, the CodePush server will assume it is `0`, i.e. `1.0` will be treated as `1.0.0`.
272+
2. Ensure that the `android.defaultConfig.versionName` property in your `android/app/build.gradle` file is set to a semver-compliant value. Note that if the value provided is missing a patch version, the CodePush server will assume it is `0`, i.e. `1.0` will be treated as `1.0.0`.
273273

274274
```gradle
275275
android {
@@ -312,15 +312,15 @@ After installing the plugin and syncing your Android Studio project with Gradle,
312312
// have it, you can run "code-push deployment ls <appName> -k" to retrieve your key.
313313
return Arrays.<ReactPackage>asList(
314314
new MainReactPackage(),
315-
new CodePush("0dsIDongIcoH0mqAmoR0CYb5FhBZNy1w4Bf-l", this, BuildConfig.DEBUG)
315+
new CodePush("deployment-key-here", this, BuildConfig.DEBUG)
316316
);
317317
}
318318
319319
...
320320
}
321321
```
322322

323-
2. Ensure that the `android.defaultConfig.versionName` property in your `android/app/build.gradle` file is set to a semver compliant value. Note that if the value provided is missing a patch version, the CodePush server will assume it is `0`, i.e. `1.0` will be treated as `1.0.0`.
323+
2. Ensure that the `android.defaultConfig.versionName` property in your `android/app/build.gradle` file is set to a semver-compliant value. Note that if the value provided is missing a patch version, the CodePush server will assume it is `0`, i.e. `1.0` will be treated as `1.0.0`.
324324

325325
```gradle
326326
android {

android/app/src/main/java/com/microsoft/codepush/react/CodePushNotInitializedException.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.microsoft.codepush.react;
22

3-
public class CodePushNotInitializedException extends RuntimeException {
3+
public final class CodePushNotInitializedException extends RuntimeException {
44

55
public CodePushNotInitializedException(String message, Throwable cause) {
66
super(message, cause);

0 commit comments

Comments
 (0)