Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Commit c7b6dd2

Browse files
committed
Fixing typos
1 parent a3bd17a commit c7b6dd2

File tree

4 files changed

+7
-11
lines changed

4 files changed

+7
-11
lines changed

CodePush.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,8 @@ async function getCurrentPackage() {
106106
async function getUpdateMetadata(updateState) {
107107
const updateMetadata = await NativeCodePush.getUpdateMetadata(updateState || CodePush.UpdateState.RUNNING);
108108
if (updateMetadata) {
109-
updateMetadata.failedInstall = await NativeCodePush.isFailedUpdate(updateMetadata.packageHash);
110-
updateMetadata.isFirstRun = await NativeCodePush.isFirstRun(updateMetadata.packageHash);
109+
updateMetadata.failedInstall = await NativeCodePush.isFailedUpdate(updateMetadata.packageHash);
110+
updateMetadata.isFirstRun = await NativeCodePush.isFirstRun(updateMetadata.packageHash);
111111
}
112112
return updateMetadata;
113113
}

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,7 @@ Example Usage:
441441
```javascript
442442
// Check if there is currently a CodePush update running, and if
443443
// so, register it with the HockeyApp SDK (https://github.com/slowpath/react-native-hockeyapp)
444-
// so that crash reports will correctly display the JS bundle version the user was running.
444+
// so that crash reports will correctly display the JS bundle version the user was running.
445445
codePush.getUpdateMetadata().then((update) => {
446446
if (update) {
447447
hockeyApp.addMetadata({ CodePushRelease: update.label });

android/app/src/main/java/com/microsoft/codepush/react/CodePush.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -519,17 +519,15 @@ protected Void doInBackground(Void... params) {
519519
// The current package satisfies the request:
520520
// 1) Caller wanted a pending, and there is a pending update
521521
// 2) Caller wanted the running update, and there isn't a pending
522-
// 3) Calers wants the latest update, regardless if it's pending or not
523-
522+
// 3) Caller wants the latest update, regardless if it's pending or not
524523
if (isRunningBinaryVersion) {
525524
// This only matters in Debug builds. Since we do not clear "outdated" updates,
526525
// we need to indicate to the JS side that somehow we have a current update on
527526
// disk that is not actually running.
528527
currentPackage.putBoolean("_isDebugOnly", true);
529528
}
530529

531-
// To support differentiating pending vs. non-pending updates
532-
// when request an update state of LATEST, provide an isPending flag
530+
// Enable differentiating pending vs. non-pending updates
533531
currentPackage.putBoolean("isPending", currentUpdateIsPending);
534532
promise.resolve(currentPackage);
535533
}

ios/CodePush/CodePush.m

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -569,17 +569,15 @@ - (void)applicationWillResignActive
569569
// The current package satisfies the request:
570570
// 1) Caller wanted a pending, and there is a pending update
571571
// 2) Caller wanted the running update, and there isn't a pending
572-
// 3) Calers wants the latest update, regardless if it's pending or not
573-
572+
// 3) Caller wants the latest update, regardless if it's pending or not
574573
if (isRunningBinaryVersion) {
575574
// This only matters in Debug builds. Since we do not clear "outdated" updates,
576575
// we need to indicate to the JS side that somehow we have a current update on
577576
// disk that is not actually running.
578577
[package setObject:@(YES) forKey:@"_isDebugOnly"];
579578
}
580579

581-
// To support differentiating pending vs. non-pending updates
582-
// when request an update state of LATEST, provide an isPending flag
580+
// Enable differentiating pending vs. non-pending updates
583581
[package setObject:@(currentUpdateIsPending) forKey:PackageIsPendingKey];
584582
resolve(package);
585583
}

0 commit comments

Comments
 (0)