Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Commit c4860a7

Browse files
Merge pull request #385 from Microsoft/logs
Improving "update is invalid" error message
2 parents 8ec0c4b + d530bab commit c4860a7

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

android/app/src/main/java/com/microsoft/codepush/react/CodePushPackage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ public void downloadPackage(ReadableMap updatePackage, String expectedBundleFile
253253
String relativeBundlePath = CodePushUpdateUtils.findJSBundleInUpdateContents(newUpdateFolderPath, expectedBundleFileName);
254254

255255
if (relativeBundlePath == null) {
256-
throw new CodePushInvalidUpdateException("Update is invalid - A JS bundle file named \"" + expectedBundleFileName + "\" could not be found within the downloaded contents. Please check that you are releasing your CodePush updates using the exact same JS bundle file name that was shipped with your app's binary.");
256+
throw new CodePushInvalidUpdateException("Update is invalid - A JS bundle file named \"" + expectedBundleFileName + "\" could not be found within the downloaded contents. Please ensure that your app is syncing with the correct deployment and that you are releasing your CodePush updates using the exact same JS bundle file name that was shipped with your app's binary.");
257257
} else {
258258
if (FileUtils.fileAtPathExists(newUpdateMetadataPath)) {
259259
File metadataFileFromOldUpdate = new File(newUpdateMetadataPath);

ios/CodePush/CodePushPackage.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ + (void)downloadPackage:(NSDictionary *)updatePackage
214214
if (relativeBundlePath) {
215215
[mutableUpdatePackage setValue:relativeBundlePath forKey:RelativeBundlePathKey];
216216
} else {
217-
NSString *errorMessage = [NSString stringWithFormat:@"Update is invalid - A JS bundle file named \"%@\" could not be found within the downloaded contents. Please check that you are releasing your CodePush updates using the exact same JS bundle file name that was shipped with your app's binary.", expectedBundleFileName];
217+
NSString *errorMessage = [NSString stringWithFormat:@"Update is invalid - A JS bundle file named \"%@\" could not be found within the downloaded contents. Please ensure that your app is syncing with the correct deployment and that you are releasing your CodePush updates using the exact same JS bundle file name that was shipped with your app's binary.", expectedBundleFileName];
218218

219219
error = [CodePushErrorUtils errorWithMessage:errorMessage];
220220

0 commit comments

Comments
 (0)