Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Commit c34ee95

Browse files
committed
Changing all internal methods from static to instance
1 parent 13cae8e commit c34ee95

File tree

1 file changed

+18
-25
lines changed

1 file changed

+18
-25
lines changed

CodePush.m

Lines changed: 18 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ @implementation CodePush
77

88
RCT_EXPORT_MODULE()
99

10-
RCTBridge *_bridge;
1110
NSTimer *_timer;
1211
BOOL usingTestFolder = NO;
1312

@@ -38,34 +37,28 @@ + (NSURL *)getBundleUrl
3837
}
3938

4039
// Internal API methods
41-
+ (void)cancelRollbackTimer
40+
- (void)cancelRollbackTimer
4241
{
4342
dispatch_async(dispatch_get_main_queue(), ^{
4443
[_timer invalidate];
4544
});
4645
}
4746

48-
+ (BOOL)isFailedHash:(NSString*)packageHash {
47+
- (BOOL)isFailedHash:(NSString*)packageHash {
4948
NSUserDefaults *preferences = [NSUserDefaults standardUserDefaults];
5049
NSMutableArray *failedUpdates = [preferences objectForKey:FailedUpdatesKey];
5150
return (failedUpdates != nil && [failedUpdates containsObject:packageHash]);
5251
}
5352

54-
+ (void)loadBundle
53+
- (void)loadBundle
5554
{
56-
dispatch_async(dispatch_get_main_queue(), ^{
57-
RCTRootView *rootView = [[RCTRootView alloc] initWithBundleURL:[self getBundleUrl]
58-
moduleName:[CodePushConfig getRootComponent]
59-
initialProperties:nil
60-
launchOptions:nil];
61-
62-
UIViewController *rootViewController = [[UIViewController alloc] init];
63-
rootViewController.view = rootView;
64-
[UIApplication sharedApplication].delegate.window.rootViewController = rootViewController;
65-
});
55+
// Reset the runtime's bundle to be
56+
// the latest URL, and then force a refresh
57+
_bridge.bundleURL = [CodePush getBundleUrl];
58+
[_bridge reload];
6659
}
6760

68-
+ (void)rollbackPackage
61+
- (void)rollbackPackage
6962
{
7063
NSError *error;
7164
NSString *packageHash = [CodePushPackage getCurrentPackageHash:&error];
@@ -79,7 +72,7 @@ + (void)rollbackPackage
7972
[self loadBundle];
8073
}
8174

82-
+ (void)saveFailedUpdate:(NSString *)packageHash {
75+
- (void)saveFailedUpdate:(NSString *)packageHash {
8376
NSUserDefaults *preferences = [NSUserDefaults standardUserDefaults];
8477
NSMutableArray *failedUpdates = [preferences objectForKey:FailedUpdatesKey];
8578
if (failedUpdates == nil) {
@@ -95,7 +88,7 @@ + (void)saveFailedUpdate:(NSString *)packageHash {
9588
[preferences synchronize];
9689
}
9790

98-
+ (void)startRollbackTimer:(int)rollbackTimeout
91+
- (void)startRollbackTimer:(int)rollbackTimeout
9992
{
10093
double timeoutInSeconds = rollbackTimeout / 1000;
10194
_timer = [NSTimer scheduledTimerWithTimeInterval:timeoutInSeconds
@@ -121,11 +114,11 @@ + (void)startRollbackTimer:(int)rollbackTimeout
121114
reject(error);
122115
}
123116

124-
[CodePush loadBundle];
117+
[self loadBundle];
125118

126119
if (0 != rollbackTimeout) {
127120
dispatch_async(dispatch_get_main_queue(), ^{
128-
[CodePush startRollbackTimer:rollbackTimeout];
121+
[self startRollbackTimer:rollbackTimeout];
129122
});
130123

131124
}
@@ -177,23 +170,23 @@ + (void)startRollbackTimer:(int)rollbackTimeout
177170
}
178171

179172
RCT_EXPORT_METHOD(isFailedUpdate:(NSString *)packageHash
180-
resolve:(RCTPromiseResolveBlock)resolve
181-
reject:(RCTPromiseRejectBlock)reject)
173+
resolve:(RCTPromiseResolveBlock)resolve
174+
reject:(RCTPromiseRejectBlock)reject)
182175
{
183-
BOOL isFailedHash = [CodePush isFailedHash:packageHash];
176+
BOOL isFailedHash = [self isFailedHash:packageHash];
184177
resolve(@(isFailedHash));
185178
}
186179

187180
RCT_EXPORT_METHOD(notifyApplicationReady:(RCTPromiseResolveBlock)resolve
188-
rejecter:(RCTPromiseRejectBlock)reject)
181+
rejecter:(RCTPromiseRejectBlock)reject)
189182
{
190-
[CodePush cancelRollbackTimer];
183+
[self cancelRollbackTimer];
191184
resolve([NSNull null]);
192185
}
193186

194187
RCT_EXPORT_METHOD(setUsingTestFolder:(BOOL)shouldUseTestFolder)
195188
{
196189
usingTestFolder = shouldUseTestFolder;
197190
}
198-
191+
199192
@end

0 commit comments

Comments
 (0)