CR feedback

Author: geof90

ios/CodePush/CodePush.m

@@ -492,17 +492,19 @@ - (void)applicationWillResignActive
                                 forKey:BinaryBundleDateKey];
     }
 
+    if (notifyProgress) {
+        [self setupFrameObserverForDownloadProgress];
+    }
+    
     [CodePushPackage
         downloadPackage:mutableUpdatePackage
         expectedBundleFileName:[bundleResourceName stringByAppendingPathExtension:bundleResourceExtension]
         operationQueue:_methodQueue
         // The download is progressing forward
         progressCallback:^(long long expectedContentLength, long long receivedContentLength) {
             // Notify the script-side about the progress
-            if (notifyProgress) {
-                [self updateDownloadProgressForNextFrame:expectedContentLength
-                                   receivedContentLength:receivedContentLength];
-            }
+            [self updateDownloadProgressForNextFrame:expectedContentLength
+                               receivedContentLength:receivedContentLength];
         }
         // The download completed
         doneCallback:^{
@@ -512,15 +514,17 @@ - (void)applicationWillResignActive
             if (err) {
                 return reject([NSString stringWithFormat: @"%lu", (long)err.code], err.localizedDescription, err);
             }
-
+            
+            [self pauseFrameObserver];
             resolve(newPackage);
         }
         // The download failed
         failCallback:^(NSError *err) {
             if ([CodePushErrorUtils isCodePushError:err]) {
                 [self saveFailedUpdate:mutableUpdatePackage];
             }
-
+            
+            [self pauseFrameObserver];
             reject([NSString stringWithFormat: @"%lu", (long)err.code], err.localizedDescription, err);
         }];
 }
@@ -760,25 +764,43 @@ - (void)applicationWillResignActive
 
 long long latestExpectedContentLength = -1;
 long long latestReceivedConentLength = -1;
+BOOL didUpdateProgress = NO;
 
 - (void)didUpdateFrame:(RCTFrameUpdate *)update
 {
+    if (!didUpdateProgress) {
+        return;
+    }
+    
     // Notify the script-side about the progress
     [self.bridge.eventDispatcher
      sendDeviceEventWithName:@"CodePushDownloadProgress"
      body:@{
             @"totalBytes":[NSNumber numberWithLongLong:latestExpectedContentLength],
             @"receivedBytes":[NSNumber numberWithLongLong:latestReceivedConentLength]
            }];
-    _paused = YES;
+    didUpdateProgress = NO;
+    
 }
 
 - (void)updateDownloadProgressForNextFrame:(long long)expectedContentLength
                      receivedContentLength:(long long)receivedContentLength
 {
     latestExpectedContentLength = expectedContentLength;
     latestReceivedConentLength = receivedContentLength;
+    didUpdateProgress = YES;
+}
+
+
+- (void)setupFrameObserverForDownloadProgress
+{
+    didUpdateProgress = NO;
     _paused = NO;
 }
 
+- (void)pauseFrameObserver
+{
+    _paused = YES;
+}
+
 @end